-
Notifications
You must be signed in to change notification settings - Fork 450
Closed
Labels
TwiDi-InReviewSolution is under reviewSolution is under reviewtype: docs updatedocumentation change not affecting the codedocumentation change not affecting the code
Description
Issue Summary
RequestValidator only has one example in its test, RequestValidatorTest.
I'm attempting to use RequestValidator but it's not working - it says all requests that come from Twilio are invalid. As there's only one example that makes it very difficult to diagnose what the problem is. It would help massively to have more examples.
As RequestValidator is part of security, good test coverage is really important, especially edge cases.
Here's a starting list of the test cases to be added
- A request with and without form parameters
- A request with and without query parameters
- A request with and without non-Twilio query parameters (e.g. I set a Voice Callback URL to be
https://my-website.abc/twilio/callback/?type=thiswontbeusedinthesignaturegeneratorandsoshouldbeignored
- A request with URL encoded query parameters
And just a lot more tests in general. At the moment the RequestValidator is unusable.
Technical details:
- twilio-java version: 8.19.1
- java version: 11
muratakbalCopilot
Metadata
Metadata
Assignees
Labels
TwiDi-InReviewSolution is under reviewSolution is under reviewtype: docs updatedocumentation change not affecting the codedocumentation change not affecting the code