Skip to content

Commit cdf29f5

Browse files
committed
fix!: rename execute_batch to executeBatch + tests
1 parent f9bb212 commit cdf29f5

File tree

2 files changed

+25
-5
lines changed

2 files changed

+25
-5
lines changed

Sources/Libsql/Libsql.swift

+7-5
Original file line numberDiff line numberDiff line change
@@ -307,8 +307,9 @@ public class Transaction: Prepareable {
307307
self.inner = inner
308308
}
309309

310-
public func execute_batch(_ sql: String) {
311-
libsql_transaction_batch(self.inner, sql)
310+
public func executeBatch(_ sql: String) throws {
311+
let batch = libsql_transaction_batch(self.inner, sql)
312+
try errIf(batch.err)
312313
}
313314

314315
public func prepare(_ sql: String) throws -> Statement {
@@ -334,12 +335,13 @@ public class Connection: Prepareable {
334335
public func transaction() throws -> Transaction {
335336
let tx = libsql_connection_transaction(self.inner)
336337
try errIf(tx.err);
337-
338+
338339
return Transaction(from: tx)
339340
}
340341

341-
public func execute_batch(_ sql: String) {
342-
libsql_connection_batch(self.inner, sql)
342+
public func executeBatch(_ sql: String) throws {
343+
let batch = libsql_connection_batch(self.inner, sql)
344+
try errIf(batch.err)
343345
}
344346

345347
public func prepare(_ sql: String) throws -> Statement {

Tests/LibsqlTests/LibsqlTests.swift

+18
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,29 @@ final class LibsqlTests: XCTestCase {
1919
let conn = try db.connect()
2020
_ = try conn.execute("create table test (i integer, s text)")
2121
_ = try conn.execute("insert into test values (?, ?)", [1, "lorem ipsum"])
22+
let row = try conn.query("select * from test").next()!;
23+
24+
XCTAssertEqual(try row.getInt(0), 1)
25+
XCTAssertEqual(try row.getString(1), "lorem ipsum")
26+
}
27+
28+
func testExecuteBatch() throws {
29+
let db = try Database(":memory:")
30+
let conn = try db.connect()
31+
_ = try conn.executeBatch("""
32+
create table test (i integer, s text);
33+
insert into test values (1, \"lorem ipsum\");
34+
""")
35+
let row = try conn.query("select * from test").next()!;
36+
37+
XCTAssertEqual(try row.getInt(0), 1)
38+
XCTAssertEqual(try row.getString(1), "lorem ipsum")
2239
}
2340

2441
func testQuerySimple() throws {
2542
let db = try Database(":memory:")
2643
let conn = try db.connect()
44+
2745
XCTAssertEqual(try conn.query("select 1").next()!.getInt(0), 1)
2846
XCTAssertEqual(try conn.query("select :named", [":named": 1]).next()!.getInt(0), 1)
2947
XCTAssertEqual(try conn.query("select ?", [1]).next()!.getInt(0), 1)

0 commit comments

Comments
 (0)