Drop support for Ruby 2.3 and 32-bit Windows builds

Ruby 2.3 reached EOL on March 31, 2019:
https://www.ruby-lang.org/en/news/2019/03/31/support-of-ruby-2-3-has-ended/

As part of this, we needed run an autocorrect with RuboCop.

We also removed 32-bit Windows builds from the AppVeyor matrix. There's
no serious need to support 32-bit builds. Furthermore, these additional
builds make feedback take that much longer to receive.

Author: sds

.rubocop.yml

@@ -1,5 +1,5 @@
 AllCops:
-  TargetRubyVersion: 2.3
+  TargetRubyVersion: 2.4
 
 Layout/ClosingParenthesisIndentation:
   Enabled: false

.travis.yml

@@ -3,7 +3,6 @@ language: ruby
 cache: bundler
 
 rvm:
-  - 2.3.8
   - 2.4.6
   - 2.5.5
   - 2.6.2

CHANGELOG.md

@@ -2,7 +2,7 @@
 
 ## master (unreleased)
 
-* Drop support for Ruby 2.2
+* Drop support for Ruby 2.3 or older
 * Add `FileSize` pre-commit hook
 
 ## 0.47.0

README.md

@@ -54,7 +54,7 @@ any Ruby code.
 
 This project aims to support the following Ruby runtimes on both \*nix and Windows:
 
-* MRI 2.3+
+* Ruby 2.4+
 
 ### Dependencies
 

appveyor.yml

@@ -4,13 +4,8 @@ clone_depth: 1
 
 environment:
   matrix:
-    - RUBY_FOLDER_VERSION: "23"
-    - RUBY_FOLDER_VERSION: "23-x64"
-    - RUBY_FOLDER_VERSION: "24"
     - RUBY_FOLDER_VERSION: "24-x64"
-    - RUBY_FOLDER_VERSION: "25"
     - RUBY_FOLDER_VERSION: "25-x64"
-    - RUBY_FOLDER_VERSION: "26"
     - RUBY_FOLDER_VERSION: "26-x64"
 matrix:
   fast_finish: true

lib/overcommit/configuration_validator.rb

@@ -102,7 +102,7 @@ def check_hook_name_format(hash)
         hash.fetch(hook_type) { {} }.each_key do |hook_name|
           next if hook_name == 'ALL'
 
-          unless hook_name =~ /\A[A-Za-z0-9]+\z/
+          unless hook_name.match?(/\A[A-Za-z0-9]+\z/)
             errors << "#{hook_type}::#{hook_name} has an invalid name " \
                       "#{hook_name}. It must contain only alphanumeric " \
                       'characters (no underscores or dashes, etc.)'

lib/overcommit/hook/commit_msg/message_format.rb

@@ -19,7 +19,7 @@ def validate_pattern(message)
       expected_pattern_message = config['expected_pattern_message']
       sample_message = config['sample_message']
 
-      unless message =~ /#{pattern}/m
+      unless message.match?(/#{pattern}/m)
         [
           'Commit message pattern mismatch.',
           "Expected : #{expected_pattern_message}",

lib/overcommit/hook/pre_commit/author_email.rb

@@ -12,7 +12,7 @@ def run
           result.stdout.chomp
         end
 
-      unless email =~ /#{config['pattern']}/
+      unless email.match?(/#{config['pattern']}/)
         return :fail,
                "Author has an invalid email address: '#{email}'\n" \
                'Set your email with ' \

lib/overcommit/hook/pre_commit/cook_style.rb

@@ -6,7 +6,7 @@ module Overcommit::Hook::PreCommit
   # @see https://docs.chef.io/cookstyle.html
   class CookStyle < Base
     GENERIC_MESSAGE_TYPE_CATEGORIZER = lambda do |type|
-      type =~ /^warn/ ? :warning : :error
+      type.match?(/^warn/) ? :warning : :error
     end
 
     COP_MESSAGE_TYPE_CATEGORIZER = lambda do |type|

lib/overcommit/hook/pre_commit/go_vet.rb

@@ -9,7 +9,7 @@ def run
       result = execute(command, args: applicable_files)
       return :pass if result.success?
 
-      if result.stderr =~ /no such tool "vet"/
+      if result.stderr.match?(/no such tool "vet"/)
         return :fail, "`go tool vet` is not installed#{install_command_prompt}"
       end
 

lib/overcommit/hook/pre_commit/jsl.rb

@@ -8,7 +8,7 @@ class Jsl < Base
     MESSAGE_REGEX = /(?<file>(?:\w:)?.+)\((?<line>\d+)\):(?<type>[^:]+)/
 
     MESSAGE_TYPE_CATEGORIZER = lambda do |type|
-      type =~ /warning/ ? :warning : :error
+      type.match?(/warning/) ? :warning : :error
     end
 
     def run

lib/overcommit/hook/pre_commit/rubo_cop.rb

@@ -6,7 +6,7 @@ module Overcommit::Hook::PreCommit
   # @see http://batsov.com/rubocop/
   class RuboCop < Base
     GENERIC_MESSAGE_TYPE_CATEGORIZER = lambda do |type|
-      type =~ /^warn/ ? :warning : :error
+      type.match?(/^warn/) ? :warning : :error
     end
 
     COP_MESSAGE_TYPE_CATEGORIZER = lambda do |type|

lib/overcommit/hook/prepare_commit_msg/replace_branch.rb

@@ -11,7 +11,7 @@ def run
       Overcommit::Utils.log.debug(
         "Checking if '#{Overcommit::GitRepo.current_branch}' matches #{branch_pattern}"
       )
-      if branch_pattern.match(Overcommit::GitRepo.current_branch)
+      if branch_pattern.match?(Overcommit::GitRepo.current_branch)
         Overcommit::Utils.log.debug("Writing #{commit_message_filename} with #{new_template}")
         modify_commit_message do |old_contents|
           "#{new_template}\n#{old_contents}"

overcommit.gemspec

@@ -25,7 +25,7 @@ Gem::Specification.new do |s|
                             Dir['libexec/**/*'] +
                             Dir['template-dir/**/*']
 
-  s.required_ruby_version = '>= 2.3'
+  s.required_ruby_version = '>= 2.4'
 
   s.add_dependency          'childprocess', '~> 0.6', '>= 0.6.3'
   s.add_dependency          'iniparse', '~> 1.4'