Skip to content

Commit 41e8b7b

Browse files
committed
Pin Rubocop in Gemfile instead of gemspec
We don't want to declare this as a development dependency because it's not really a dependency--it's simply a tool we run against the repository as part of our CI runs. Change-Id: Ica1bdbe5de39ee88f8e114a7cbce4cc6e3937844 Reviewed-on: http://gerrit.causes.com/45031 Tested-by: jenkins <jenkins@brigade.com> Reviewed-by: Shane da Silva <shane.dasilva@brigade.com>
1 parent 280efb6 commit 41e8b7b

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

Gemfile

+3
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
11
source 'http://rubygems.org'
22

3+
# Pin Rubocop for Travis builds.
4+
gem 'rubocop', '0.26.0'
5+
36
gemspec

overcommit.gemspec

-1
Original file line numberDiff line numberDiff line change
@@ -30,5 +30,4 @@ Gem::Specification.new do |s|
3030

3131
s.add_development_dependency 'image_optim', '~> 0.15.0'
3232
s.add_development_dependency 'rspec', '~> 3.0'
33-
s.add_development_dependency 'rubocop', '0.26.0' # Pin for Travis builds
3433
end

0 commit comments

Comments
 (0)