refactor/gpio: improve config of pins

* The pins are pulled down now by default.
* set to active high so they interpret phy HIGH
as a 1 and vice versa
* rm redundant code

Signed-off-by: Dhruva Gole <goledhruva@gmail.com>

Author: DhruvaG2000

cores/arduino/zephyrCommon.cpp

@@ -6,28 +6,28 @@
 
 #include "Arduino.h"
 
+/*
+ *  We have initialised all pins by default to pull down
+ *  inorder to not have random floating voltages in pins
+ *  The ACTIVE_HIGH flag is set so that A low physical
+ *  level on the pin will be interpreted as value 0.
+ *  A high physical level will be interpreted as value 1
+ */
 void pinMode(pin_size_t pinNumber, PinMode pinMode) {
   if (pinMode == INPUT || pinMode == INPUT_PULLDOWN) { // input mode
     gpio_pin_configure_dt(arduino_pins[pinNumber],
-                          GPIO_INPUT | GPIO_ACTIVE_LOW);
+                          GPIO_INPUT | GPIO_PULL_DOWN | GPIO_ACTIVE_HIGH);
   } else { // output mode
-    gpio_pin_configure_dt(arduino_pins[pinNumber], GPIO_OUTPUT);
+    gpio_pin_configure_dt(arduino_pins[pinNumber],
+                          GPIO_OUTPUT_LOW | GPIO_PULL_DOWN | GPIO_ACTIVE_HIGH);
   }
 }
 
 void digitalWrite(pin_size_t pinNumber, PinStatus status) {
-  if (status == HIGH) {
-    gpio_pin_set_dt(arduino_pins[pinNumber], GPIO_ACTIVE_HIGH);
-  } else if (status == LOW) {
-    gpio_pin_set_dt(arduino_pins[pinNumber], GPIO_ACTIVE_LOW);
-  }
+  gpio_pin_set_dt(arduino_pins[pinNumber], status);
 }
 
 PinStatus digitalRead(pin_size_t pinNumber) {
-  if (pinNumber >= 100) {
-    pinNumber -= 100;
-    return (gpio_pin_get_dt(arduino_pins[pinNumber]) == 1) ? HIGH : LOW;
-  }
   return (gpio_pin_get_dt(arduino_pins[pinNumber]) == 1) ? HIGH : LOW;
 }
 

variants/ARDUINO_NANO33BLE/arduino_nano_ble_sense_pinmap.h

@@ -14,8 +14,7 @@
 static struct gpio_dt_spec d0 = GPIO_DT_SPEC_GET(DT_PATH(zephyr_user), d0_gpios);
 static struct gpio_dt_spec d1 = GPIO_DT_SPEC_GET(DT_PATH(zephyr_user), d1_gpios);
 static struct gpio_dt_spec d2 = GPIO_DT_SPEC_GET(DT_PATH(zephyr_user), d2_gpios);
-static struct gpio_dt_spec d3 =
-    GPIO_DT_SPEC_GET(DT_PATH(zephyr_user), d3_gpios);
+static struct gpio_dt_spec d3 = GPIO_DT_SPEC_GET(DT_PATH(zephyr_user), d3_gpios);
 static struct gpio_dt_spec d4 =
     GPIO_DT_SPEC_GET(DT_PATH(zephyr_user), d4_gpios);
 static struct gpio_dt_spec d5 =