Allow tags to be created without the tagger object. (KnpLabs#780)

* Allow tags to be created without the tagger object.

* Drop hhvm support

* Allow tags to be created without the tagger object.

* Allow tags to be created without the tagger object.

Author: owenconti

lib/Github/Api/GitData/Tags.php

@@ -56,11 +56,7 @@ public function create($username, $repository, array $params)
             throw new MissingArgumentException(['tag', 'message', 'object', 'type']);
         }
 
-        if (!isset($params['tagger'])) {
-            throw new MissingArgumentException('tagger');
-        }
-
-        if (!isset($params['tagger']['name'], $params['tagger']['email'], $params['tagger']['date'])) {
+        if (isset($params['tagger']) && !isset($params['tagger']['name'], $params['tagger']['email'], $params['tagger']['date'])) {
             throw new MissingArgumentException(['tagger.name', 'tagger.email', 'tagger.date']);
         }
 

test/Github/Tests/Api/GitData/TagsTest.php

@@ -89,9 +89,8 @@ public function shouldNotCreateTagWithoutMessageParam()
 
     /**
      * @test
-     * @expectedException \Github\Exception\MissingArgumentException
      */
-    public function shouldNotCreateTagWithoutTaggerParam()
+    public function shouldCreateTagWithoutTaggerParam()
     {
         $data = [
             'message' => 'some message',
@@ -101,7 +100,7 @@ public function shouldNotCreateTagWithoutTaggerParam()
         ];
 
         $api = $this->getApiMock();
-        $api->expects($this->never())
+        $api->expects($this->once())
             ->method('post');
 
         $api->create('KnpLabs', 'php-github-api', $data);