Skip to content

Commit cdab07e

Browse files
committed
fixed modify wild pointer
fixed Tencent#125
1 parent ffa1a5e commit cdab07e

File tree

5 files changed

+31
-6
lines changed

5 files changed

+31
-6
lines changed

mars/comm/messagequeue/message_queue.cc

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
#include "comm/anr.h"
3434
#include "comm/messagequeue/message_queue.h"
3535
#include "comm/time_utils.h"
36+
#include "comm/xlogger/xlogger.h"
3637
#ifdef __APPLE__
3738
#include "comm/debugger/debugger_utils.h"
3839
#endif
@@ -630,6 +631,8 @@ void RunLoop::Run() {
630631
ScopedLock lock(sg_messagequeue_map_mutex);
631632
sg_messagequeue_map[id].lst_runloop_info.push_back(RunLoopInfo());
632633
}
634+
635+
xinfo_function(TSF"messagequeue id:%_", id);
633636

634637
while (true) {
635638
ScopedLock lock(sg_messagequeue_map_mutex);
@@ -766,7 +769,7 @@ void MessageQueueCreater::__ThreadRunloop() {
766769
lock.unlock();
767770

768771
RunLoop().Run();
769-
messagequeue_id_ = 0;
772+
770773
}
771774

772775
MessageQueue_t MessageQueueCreater::GetMessageQueue() {
@@ -780,7 +783,8 @@ MessageQueue_t MessageQueueCreater::CreateMessageQueue() {
780783

781784
if (0 != thread_.start()) { return KInvalidQueueID;}
782785
messagequeue_id_ = __CreateMessageQueueInfo(breaker_, thread_.tid());
783-
786+
xinfo2(TSF"create messageqeue id:%_", messagequeue_id_);
787+
784788
return messagequeue_id_;
785789
}
786790

mars/libraries/mars_android_sdk/jni/decode_mars_log_file.py.rewriteme

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ def DecodeBuffer(_buffer, _offset, _outbuffer):
9393
decompressor = zlib.decompressobj(-zlib.MAX_WBITS)
9494
decompress_data = bytearray()
9595
while len(tmpbuffer) > 0:
96-
single_log_len = struct.unpack_from("H", tmpbuffer[0:2])[0]
96+
single_log_len = struct.unpack_from("H", buffer(tmpbuffer, 0, 2))[0]
9797
#decompress_data.extend(base64.decodestring(tmpbuffer[2:single_log_len+2]))
9898
decompress_data.extend(tmpbuffer[2:single_log_len+2])
9999
tmpbuffer[:] = tmpbuffer[single_log_len+2:len(tmpbuffer)]

mars/libraries/mars_android_sdk/jni/longlink_packer.h

Lines changed: 22 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212

1313

1414
/*
15-
* longlink_packer.cpp
15+
* longlink_packer.h
1616
*
1717
* Created on: 2012-7-18
1818
* Author: yerungui
@@ -34,7 +34,24 @@
3434

3535
class AutoBuffer;
3636

37+
/**
38+
* package the request data
39+
* _cmdid: business identifier
40+
* _seq: task id
41+
* _raw: business send buffer
42+
* _packed: business send buffer + request header
43+
*/
3744
void longlink_pack(uint32_t _cmdid, uint32_t _seq, const void* _raw, size_t _raw_len, AutoBuffer& _packed);
45+
46+
/**
47+
* unpackage the response data
48+
* _packed: data received from server
49+
* _cmdid: business identifier
50+
* _seq: task id
51+
* _package_len:
52+
* _body: business receive buffer
53+
* return: 0 if unpackage succ
54+
*/
3855
int longlink_unpack(const AutoBuffer& _packed, uint32_t& _cmdid, uint32_t& _seq, size_t& _package_len, AutoBuffer& _body);
3956

4057
//heartbeat signal to keep longlink network alive
@@ -47,6 +64,10 @@ void longlink_noop_resp_body(AutoBuffer& _body);
4764
uint32_t longlink_noop_interval();
4865

4966
bool longlink_complexconnect_need_verify();
67+
68+
/**
69+
* return: whether the received data is pushing from server or not
70+
*/
5071
bool is_push_data(uint32_t _cmdid, uint32_t _taskid);
5172

5273
#endif // STN_SRC_LONGLINKPACKER_H_

mars/log/crypt/decode_mars_log_file.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ def DecodeBuffer(_buffer, _offset, _outbuffer):
9393
decompressor = zlib.decompressobj(-zlib.MAX_WBITS)
9494
decompress_data = bytearray()
9595
while len(tmpbuffer) > 0:
96-
single_log_len = struct.unpack_from("H", tmpbuffer[0:2])[0]
96+
single_log_len = struct.unpack_from("H", buffer(tmpbuffer, 0, 2))[0]
9797
#decompress_data.extend(base64.decodestring(tmpbuffer[2:single_log_len+2]))
9898
decompress_data.extend(tmpbuffer[2:single_log_len+2])
9999
tmpbuffer[:] = tmpbuffer[single_log_len+2:len(tmpbuffer)]

samples/iOS/iOSDemoXlog/PublicComponentV2/decode_mars_log_file.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ def DecodeBuffer(_buffer, _offset, _outbuffer):
9393
decompressor = zlib.decompressobj(-zlib.MAX_WBITS)
9494
decompress_data = bytearray()
9595
while len(tmpbuffer) > 0:
96-
single_log_len = struct.unpack_from("H", tmpbuffer[0:2])[0]
96+
single_log_len = struct.unpack_from("H", buffer(tmpbuffer, 0, 2))[0]
9797
#decompress_data.extend(base64.decodestring(tmpbuffer[2:single_log_len+2]))
9898
decompress_data.extend(tmpbuffer[2:single_log_len+2])
9999
tmpbuffer[:] = tmpbuffer[single_log_len+2:len(tmpbuffer)]

0 commit comments

Comments
 (0)