Utilize the recommended way to handle the icu namespace

weltling · weltling · commit 8d35a423838e · 2018-03-31T18:51:56.000+02:00
diff --git a/ext/intl/breakiterator/breakiterator_class.cpp b/ext/intl/breakiterator/breakiterator_class.cpp
@@ -38,6 +38,7 @@ extern "C" {
 }
 
 using PHP::CodePointBreakIterator;
+using U_ICU_NAMESPACE::RuleBasedBreakIterator;
 
 /* {{{ Global variables */
 zend_class_entry *BreakIterator_ce_ptr;
diff --git a/ext/intl/breakiterator/breakiterator_class.h b/ext/intl/breakiterator/breakiterator_class.h
@@ -26,6 +26,8 @@
 
 #ifndef USE_BREAKITERATOR_POINTER
 typedef void BreakIterator;
+#else
+using U_ICU_NAMESPACE::BreakIterator;
 #endif
 
 typedef struct {
diff --git a/ext/intl/breakiterator/breakiterator_methods.cpp b/ext/intl/breakiterator/breakiterator_methods.cpp
@@ -32,6 +32,8 @@ extern "C" {
 }
 
 using PHP::CodePointBreakIterator;
+using U_ICU_NAMESPACE::BreakIterator;
+using U_ICU_NAMESPACE::Locale;
 
 U_CFUNC PHP_METHOD(BreakIterator, __construct)
 {
diff --git a/ext/intl/breakiterator/codepointiterator_internal.cpp b/ext/intl/breakiterator/codepointiterator_internal.cpp
@@ -33,6 +33,8 @@ typedef union {
 
 using namespace PHP;
 
+using U_ICU_NAMESPACE::UCharCharacterIterator;
+
 UOBJECT_DEFINE_RTTI_IMPLEMENTATION(CodePointBreakIterator);
 
 CodePointBreakIterator::CodePointBreakIterator()
diff --git a/ext/intl/breakiterator/codepointiterator_internal.h b/ext/intl/breakiterator/codepointiterator_internal.h
@@ -18,8 +18,11 @@
 #define CODEPOINTITERATOR_INTERNAL_H
 
 #include <unicode/brkiter.h>
+#include <unicode/unistr.h>
 
 using U_ICU_NAMESPACE::BreakIterator;
+using U_ICU_NAMESPACE::CharacterIterator;
+using U_ICU_NAMESPACE::UnicodeString;
 
 namespace PHP {
 
diff --git a/ext/intl/breakiterator/rulebasedbreakiterator_methods.cpp b/ext/intl/breakiterator/rulebasedbreakiterator_methods.cpp
@@ -26,6 +26,9 @@ extern "C" {
 #include "../intl_convertcpp.h"
 #include "../intl_common.h"
 
+using U_ICU_NAMESPACE::RuleBasedBreakIterator;
+using U_ICU_NAMESPACE::Locale;
+
 static inline RuleBasedBreakIterator *fetch_rbbi(BreakIterator_object *bio) {
 	return (RuleBasedBreakIterator*)bio->biter;
 }
diff --git a/ext/intl/calendar/calendar_class.cpp b/ext/intl/calendar/calendar_class.cpp
@@ -34,6 +34,9 @@ extern "C" {
 #include <assert.h>
 }
 
+using U_ICU_NAMESPACE::GregorianCalendar;
+using U_ICU_NAMESPACE::Locale;
+
 /* {{{ Global variables */
 zend_class_entry *Calendar_ce_ptr;
 zend_class_entry *GregorianCalendar_ce_ptr;
diff --git a/ext/intl/calendar/calendar_class.h b/ext/intl/calendar/calendar_class.h
@@ -26,6 +26,8 @@
 
 #ifndef USE_CALENDAR_POINTER
 typedef void Calendar;
+#else
+using U_ICU_NAMESPACE::Calendar;
 #endif
 
 typedef struct {
diff --git a/ext/intl/calendar/calendar_methods.cpp b/ext/intl/calendar/calendar_methods.cpp
@@ -43,6 +43,8 @@ extern "C" {
 }
 #include "../common/common_enum.h"
 
+using U_ICU_NAMESPACE::Locale;
+
 U_CFUNC PHP_METHOD(IntlCalendar, __construct)
 {
 	zend_throw_exception( NULL,
diff --git a/ext/intl/calendar/gregoriancalendar_methods.cpp b/ext/intl/calendar/gregoriancalendar_methods.cpp
@@ -23,6 +23,8 @@
 #include <unicode/locid.h>
 #include <unicode/calendar.h>
 #include <unicode/gregocal.h>
+#include <unicode/ustring.h>
+
 extern "C" {
 #include "../php_intl.h"
 #include "../intl_common.h"
@@ -34,6 +36,11 @@ extern "C" {
 #include "zend_exceptions.h"
 }
 
+using U_ICU_NAMESPACE::GregorianCalendar;
+using U_ICU_NAMESPACE::Locale;
+using U_ICU_NAMESPACE::UnicodeString;
+using U_ICU_NAMESPACE::StringPiece;
+
 static inline GregorianCalendar *fetch_greg(Calendar_object *co) {
 	return (GregorianCalendar*)co->ucal;
 }
diff --git a/ext/intl/common/common_date.cpp b/ext/intl/common/common_date.cpp
@@ -25,6 +25,9 @@ extern "C" {
 #include <ext/date/php_date.h>
 }
 
+using U_ICU_NAMESPACE::TimeZone;
+using U_ICU_NAMESPACE::UnicodeString;
+
 #include "zend_portability.h"
 
 /* {{{ timezone_convert_datetimezone
diff --git a/ext/intl/common/common_date.h b/ext/intl/common/common_date.h
@@ -28,6 +28,8 @@ U_CDECL_END
 
 #include <unicode/timezone.h>
 
+using U_ICU_NAMESPACE::TimeZone;
+
 U_CFUNC TimeZone *timezone_convert_datetimezone(int type, void *object, int is_datetime, intl_error *outside_error, const char *func);
 U_CFUNC int intl_datetime_decompose(zval *z, double *millis, TimeZone **tz,
 		intl_error *err, const char *func);
diff --git a/ext/intl/common/common_enum.h b/ext/intl/common/common_enum.h
@@ -75,6 +75,7 @@ U_CFUNC zval *zoi_with_current_get_current_data(zend_object_iterator *iter);
 U_CFUNC void zoi_with_current_invalidate_current(zend_object_iterator *iter);
 
 #ifdef __cplusplus
+using U_ICU_NAMESPACE::StringEnumeration;
 U_CFUNC void IntlIterator_from_StringEnumeration(StringEnumeration *se, zval *object);
 #endif
 
diff --git a/ext/intl/dateformat/dateformat_format_object.cpp b/ext/intl/dateformat/dateformat_format_object.cpp
@@ -33,6 +33,12 @@ extern "C" {
 #include "../common/common_date.h"
 }
 
+using U_ICU_NAMESPACE::Locale;
+using U_ICU_NAMESPACE::DateFormat;
+using U_ICU_NAMESPACE::GregorianCalendar;
+using U_ICU_NAMESPACE::StringPiece;
+using U_ICU_NAMESPACE::SimpleDateFormat;
+
 static const DateFormat::EStyle valid_styles[] = {
 		DateFormat::kNone,
 		DateFormat::kFull,
diff --git a/ext/intl/dateformat/dateformat_helpers.cpp b/ext/intl/dateformat/dateformat_helpers.cpp
@@ -28,6 +28,8 @@ extern "C" {
 #include "../calendar/calendar_class.h"
 }
 
+using U_ICU_NAMESPACE::GregorianCalendar;
+
 int datefmt_process_calendar_arg(zval* calendar_zv,
 								 Locale const& locale,
 								 const char *func_name,
diff --git a/ext/intl/dateformat/dateformat_helpers.h b/ext/intl/dateformat/dateformat_helpers.h
@@ -22,11 +22,16 @@
 #endif
 
 #include <unicode/calendar.h>
+#include <unicode/datefmt.h>
 
 extern "C" {
 #include "../php_intl.h"
 }
 
+using U_ICU_NAMESPACE::Locale;
+using U_ICU_NAMESPACE::Calendar;
+using U_ICU_NAMESPACE::DateFormat;
+
 int datefmt_process_calendar_arg(zval* calendar_zv,
 								 Locale const& locale,
 								 const char *func_name,
diff --git a/ext/intl/intl_convertcpp.h b/ext/intl/intl_convertcpp.h
@@ -26,6 +26,8 @@
 #include <unicode/unistr.h>
 #include <zend_types.h>
 
+using U_ICU_NAMESPACE::UnicodeString;
+
 int intl_stringFromChar(UnicodeString &ret, char *str, size_t str_len, UErrorCode *status);
 
 zend_string* intl_charFromString(const UnicodeString &from, UErrorCode *status);
diff --git a/ext/intl/msgformat/msgformat_helpers.cpp b/ext/intl/msgformat/msgformat_helpers.cpp
@@ -76,6 +76,16 @@ MessageFormatAdapter::getMessagePattern(MessageFormat* m) {
 #endif
 U_NAMESPACE_END
 
+using U_ICU_NAMESPACE::Formattable;
+using U_ICU_NAMESPACE::Format;
+using U_ICU_NAMESPACE::DateFormat;
+using U_ICU_NAMESPACE::MessageFormat;
+#ifdef HAS_MESSAGE_PATTERN
+using U_ICU_NAMESPACE::MessagePattern;
+#endif
+using U_ICU_NAMESPACE::MessageFormatAdapter;
+using U_ICU_NAMESPACE::FieldPosition;
+
 U_CFUNC int32_t umsg_format_arg_count(UMessageFormat *fmt)
 {
 	int32_t fmt_count = 0;
diff --git a/ext/intl/timezone/timezone_class.cpp b/ext/intl/timezone/timezone_class.cpp
@@ -37,6 +37,8 @@ extern "C" {
 #include <ext/date/php_date.h>
 }
 
+using U_ICU_NAMESPACE::Calendar;
+
 /* {{{ Global variables */
 U_CDECL_BEGIN
 zend_class_entry *TimeZone_ce_ptr = NULL;
diff --git a/ext/intl/timezone/timezone_class.h b/ext/intl/timezone/timezone_class.h
@@ -29,6 +29,8 @@
 
 #ifndef USE_TIMEZONE_POINTER
 typedef void TimeZone;
+#else
+using U_ICU_NAMESPACE::TimeZone;
 #endif
 
 typedef struct {
diff --git a/ext/intl/timezone/timezone_methods.cpp b/ext/intl/timezone/timezone_methods.cpp
@@ -23,6 +23,7 @@
 #include <unicode/locid.h>
 #include <unicode/timezone.h>
 #include <unicode/ustring.h>
+#include <unicode/calendar.h>
 #include "intl_convertcpp.h"
 
 #include "../common/common_date.h"
@@ -37,6 +38,9 @@ extern "C" {
 }
 #include "common/common_enum.h"
 
+using U_ICU_NAMESPACE::Locale;
+using U_ICU_NAMESPACE::Calendar;
+
 U_CFUNC PHP_METHOD(IntlTimeZone, __construct)
 {
 	zend_throw_exception( NULL,

Original file line number	Diff line number	Diff line change
`@@ -38,6 +38,7 @@ extern "C" {`
`38`	`38`	`}`
`39`	`39`
`40`	`40`	`using PHP::CodePointBreakIterator;`
	`41`	`+using U_ICU_NAMESPACE::RuleBasedBreakIterator;`
`41`	`42`
`42`	`43`	`/* {{{ Global variables */`
`43`	`44`	`zend_class_entry *BreakIterator_ce_ptr;`
Original file line number	Diff line number	Diff line change
`@@ -32,6 +32,8 @@ extern "C" {`
`32`	`32`	`}`
`33`	`33`
`34`	`34`	`using PHP::CodePointBreakIterator;`
	`35`	`+using U_ICU_NAMESPACE::BreakIterator;`
	`36`	`+using U_ICU_NAMESPACE::Locale;`
`35`	`37`
`36`	`38`	`U_CFUNC PHP_METHOD(BreakIterator, __construct)`
`37`	`39`	`{`
Original file line number	Diff line number	Diff line change
`@@ -26,6 +26,9 @@ extern "C" {`
`26`	`26`	`#include "../intl_convertcpp.h"`
`27`	`27`	`#include "../intl_common.h"`
`28`	`28`
	`29`	`+using U_ICU_NAMESPACE::RuleBasedBreakIterator;`
	`30`	`+using U_ICU_NAMESPACE::Locale;`
	`31`	`+`
`29`	`32`	`static inline RuleBasedBreakIterator fetch_rbbi(BreakIterator_object bio) {`
`30`	`33`	`return (RuleBasedBreakIterator*)bio->biter;`
`31`	`34`	`}`
Original file line number	Diff line number	Diff line change
`@@ -34,6 +34,9 @@ extern "C" {`
`34`	`34`	`#include <assert.h>`
`35`	`35`	`}`
`36`	`36`
	`37`	`+using U_ICU_NAMESPACE::GregorianCalendar;`
	`38`	`+using U_ICU_NAMESPACE::Locale;`
	`39`	`+`
`37`	`40`	`/* {{{ Global variables */`
`38`	`41`	`zend_class_entry *Calendar_ce_ptr;`
`39`	`42`	`zend_class_entry *GregorianCalendar_ce_ptr;`
Original file line number	Diff line number	Diff line change
`@@ -43,6 +43,8 @@ extern "C" {`
`43`	`43`	`}`
`44`	`44`	`#include "../common/common_enum.h"`
`45`	`45`
	`46`	`+using U_ICU_NAMESPACE::Locale;`
	`47`	`+`
`46`	`48`	`U_CFUNC PHP_METHOD(IntlCalendar, __construct)`
`47`	`49`	`{`
`48`	`50`	`zend_throw_exception( NULL,`
Original file line number	Diff line number	Diff line change
`@@ -25,6 +25,9 @@ extern "C" {`
`25`	`25`	`#include <ext/date/php_date.h>`
`26`	`26`	`}`
`27`	`27`
	`28`	`+using U_ICU_NAMESPACE::TimeZone;`
	`29`	`+using U_ICU_NAMESPACE::UnicodeString;`
	`30`	`+`
`28`	`31`	`#include "zend_portability.h"`
`29`	`32`
`30`	`33`	`/* {{{ timezone_convert_datetimezone`
Original file line number	Diff line number	Diff line change
`@@ -28,6 +28,8 @@ extern "C" {`
`28`	`28`	`#include "../calendar/calendar_class.h"`
`29`	`29`	`}`
`30`	`30`
	`31`	`+using U_ICU_NAMESPACE::GregorianCalendar;`
	`32`	`+`
`31`	`33`	`int datefmt_process_calendar_arg(zval* calendar_zv,`
`32`	`34`	`Locale const& locale,`
`33`	`35`	`const char *func_name,`
Original file line number	Diff line number	Diff line change
`@@ -37,6 +37,8 @@ extern "C" {`
`37`	`37`	`#include <ext/date/php_date.h>`
`38`	`38`	`}`
`39`	`39`
	`40`	`+using U_ICU_NAMESPACE::Calendar;`
	`41`	`+`
`40`	`42`	`/* {{{ Global variables */`
`41`	`43`	`U_CDECL_BEGIN`
`42`	`44`	`zend_class_entry *TimeZone_ce_ptr = NULL;`