Skip to content

Commit b887b63

Browse files
committed
Minor updates
1 parent 8e0526c commit b887b63

File tree

10 files changed

+68
-69
lines changed

10 files changed

+68
-69
lines changed

Gemfile

+6-6
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,13 @@
1717

1818
source 'https://rubygems.org'
1919

20-
gem "rake", "~> 12"
21-
gem "elasticsearch"
22-
gem "pry"
23-
gem "ansi"
24-
gem "cane"
20+
gem 'ansi'
21+
gem 'cane'
22+
gem 'elasticsearch', '~> 7'
23+
gem 'pry'
24+
gem 'rake', '~> 12'
2525

2626
group :development do
27-
gem 'yard'
2827
gem 'rspec'
28+
gem 'yard'
2929
end

elasticsearch-model/Rakefile

+3-3
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,12 @@ require 'rake/testtask'
4848
namespace :test do
4949
desc 'Run all tests. Optionally define env variable RAILS_VERSIONS. E.g. RAILS_VERSIONS=3.0,5.0'
5050
task :all, [:rails_versions] do |task, args|
51-
gemfiles = ENV['RAILS_VERSIONS'] ? ENV['RAILS_VERSIONS'].split(',').map {|v| "#{v}.gemfile"} : GEMFILES
51+
gemfiles = ENV['RAILS_VERSIONS'] ? ENV['RAILS_VERSIONS'].split(',').map { |v| "#{v}.gemfile" } : GEMFILES
5252
puts '-' * 80
5353
gemfiles.each do |gemfile|
5454
puts "GEMFILE: #{gemfile}"
55-
sh "BUNDLE_GEMFILE='#{File.expand_path("../gemfiles/#{gemfile}", __FILE__)}' " +
56-
" bundle exec rspec"
55+
sh "BUNDLE_GEMFILE='#{File.expand_path("../gemfiles/#{gemfile}", __FILE__)}' " \
56+
' bundle exec rspec'
5757
puts '-' * 80
5858
end
5959
end

elasticsearch-model/elasticsearch-model.gemspec

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ Gem::Specification.new do |s|
2525
s.name = 'elasticsearch-model'
2626
s.version = Elasticsearch::Model::VERSION
2727
s.authors = ['Karel Minarik']
28-
s.email = ['karel.minarik@elasticsearch.org']
28+
s.email = ['support@elastic.co']
2929
s.description = 'ActiveModel/Record integrations for Elasticsearch.'
3030
s.summary = 'ActiveModel/Record integrations for Elasticsearch.'
3131
s.homepage = 'https://github.com/elasticsearch/elasticsearch-rails/'

elasticsearch-model/gemfiles/6.0.gemfile

+2-3
Original file line numberDiff line numberDiff line change
@@ -20,17 +20,16 @@
2020
# $ BUNDLE_GEMFILE=./gemfiles/6.0.gemfile bundle install
2121
# $ BUNDLE_GEMFILE=./gemfiles/6.0.gemfile bundle exec rake test:integration
2222

23-
2423
source 'https://rubygems.org'
2524

2625
gemspec path: '../'
2726

2827
gem 'activemodel', '6.0.0'
2928
gem 'activerecord', '6.0.0'
3029
gem 'sqlite3' unless defined?(JRUBY_VERSION)
31-
#gem 'mongoid', '~> 6'
30+
# gem 'mongoid', '~> 6'
3231

3332
group :development, :testing do
34-
gem 'rspec'
3533
gem 'pry-nav'
34+
gem 'rspec'
3635
end

elasticsearch-model/lib/elasticsearch/model/adapters/mongoid.rb

+9-11
Original file line numberDiff line numberDiff line change
@@ -18,18 +18,21 @@
1818
module Elasticsearch
1919
module Model
2020
module Adapter
21-
2221
# An adapter for Mongoid-based models
2322
#
2423
# @see http://mongoid.org
2524
#
2625
module Mongoid
27-
28-
Adapter.register self,
29-
lambda { |klass| !!defined?(::Mongoid::Document) && klass.respond_to?(:ancestors) && klass.ancestors.include?(::Mongoid::Document) }
26+
Adapter.register(
27+
self,
28+
lambda do |klass|
29+
!!defined?(::Mongoid::Document) &&
30+
klass.respond_to?(:ancestors) &&
31+
klass.ancestors.include?(::Mongoid::Document)
32+
end
33+
)
3034

3135
module Records
32-
3336
# Return a `Mongoid::Criteria` instance
3437
#
3538
def records
@@ -59,7 +62,6 @@ def records
5962
end
6063

6164
module Callbacks
62-
6365
# Handle index updates (creating, updating or deleting documents)
6466
# when the model changes, by hooking into the lifecycle
6567
#
@@ -73,7 +75,6 @@ def self.included(base)
7375
end
7476

7577
module Importing
76-
7778
# Fetch batches of records from the database
7879
#
7980
# @see https://github.com/mongoid/mongoid/issues/1334
@@ -88,19 +89,16 @@ def __find_in_batches(options={}, &block)
8889
scope = all
8990
scope = scope.send(named_scope) if named_scope
9091
scope = query.is_a?(Proc) ? scope.class_exec(&query) : scope.where(query) if query
91-
9292
scope.no_timeout.each_slice(batch_size) do |items|
9393
yield (preprocess ? self.__send__(preprocess, items) : items)
9494
end
9595
end
9696

9797
def __transform
98-
lambda {|a| { index: { _id: a.id.to_s, data: a.as_indexed_json } }}
98+
lambda { |a| { index: { _id: a.id.to_s, data: a.as_indexed_json } } }
9999
end
100100
end
101-
102101
end
103-
104102
end
105103
end
106104
end

elasticsearch-model/spec/spec_helper.rb

+4-2
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,10 @@
4343
require 'ansi'
4444
tracer = ::Logger.new(STDERR)
4545
tracer.formatter = lambda { |s, d, p, m| "#{m.gsub(/^.*$/) { |n| ' ' + n }.ansi(:faint)}\n" }
46-
Elasticsearch::Model.client = Elasticsearch::Client.new host: ELASTICSEARCH_URL,
47-
tracer: (ENV['QUIET'] ? nil : tracer)
46+
Elasticsearch::Model.client = Elasticsearch::Client.new(
47+
host: ELASTICSEARCH_URL,
48+
tracer: (ENV['QUIET'] ? nil : tracer)
49+
)
4850
puts "Elasticsearch Version: #{Elasticsearch::Model.client.info['version']}"
4951

5052
unless ActiveRecord::Base.connected?

elasticsearch-persistence/Rakefile

+8-7
Original file line numberDiff line numberDiff line change
@@ -15,26 +15,27 @@
1515
# specific language governing permissions and limitations
1616
# under the License.
1717

18-
require "bundler/gem_tasks"
18+
require 'bundler/gem_tasks'
1919

20-
desc "Run unit tests"
21-
task :default => 'test:unit'
22-
task :test => 'test:unit'
20+
desc 'Run unit tests'
21+
task default: 'test:unit'
22+
task test: 'test:unit'
2323

2424
# ----- Test tasks ------------------------------------------------------------
2525

2626
require 'rake/testtask'
2727
require 'rspec/core/rake_task'
2828

2929
namespace :test do
30-
3130
RSpec::Core::RakeTask.new(:spec)
3231

3332
Rake::TestTask.new(:all) do |test|
3433
test.verbose = false
3534
test.warning = false
36-
test.deps = [ :spec ]
35+
test.deps = [:spec]
3736
end
37+
38+
task unit: :spec
3839
end
3940

4041
namespace :bundle do
@@ -65,6 +66,6 @@ if defined?(RUBY_VERSION) && RUBY_VERSION > '1.9'
6566
cane.style_measure = 120
6667
end
6768
rescue LoadError
68-
warn "cane not available, quality task not provided."
69+
warn 'cane not available, quality task not provided.'
6970
end
7071
end

elasticsearch-persistence/elasticsearch-persistence.gemspec

+32-35
Original file line numberDiff line numberDiff line change
@@ -16,52 +16,49 @@
1616
# under the License.
1717

1818
# coding: utf-8
19-
lib = File.expand_path('../lib', __FILE__)
19+
20+
lib = File.expand_path('lib', __dir__)
2021
$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
2122
require 'elasticsearch/persistence/version'
2223

2324
Gem::Specification.new do |s|
24-
s.name = "elasticsearch-persistence"
25+
s.name = 'elasticsearch-persistence'
2526
s.version = Elasticsearch::Persistence::VERSION
26-
s.authors = ["Karel Minarik"]
27-
s.email = ["karel.minarik@elasticsearch.org"]
28-
s.description = "Persistence layer for Ruby models and Elasticsearch."
29-
s.summary = "Persistence layer for Ruby models and Elasticsearch."
30-
s.homepage = "https://github.com/elasticsearch/elasticsearch-rails/"
31-
s.license = "Apache 2"
27+
s.authors = ['Karel Minarik']
28+
s.email = ['support@elastic.co']
29+
s.description = 'Persistence layer for Ruby models and Elasticsearch.'
30+
s.summary = 'Persistence layer for Ruby models and Elasticsearch.'
31+
s.homepage = 'https://github.com/elasticsearch/elasticsearch-rails/'
32+
s.license = 'Apache 2'
3233

3334
s.files = `git ls-files -z`.split("\x0")
3435
s.executables = s.files.grep(%r{^bin/}) { |f| File.basename(f) }
3536
s.test_files = s.files.grep(%r{^(test|spec|features)/})
36-
s.require_paths = ["lib"]
37-
38-
s.extra_rdoc_files = [ "README.md", "LICENSE.txt" ]
39-
s.rdoc_options = [ "--charset=UTF-8" ]
40-
41-
s.required_ruby_version = ">= 1.9.3"
42-
43-
s.add_dependency "elasticsearch", '~> 7'
44-
s.add_dependency "elasticsearch-model", '7.2.1'
45-
s.add_dependency "activesupport", '> 4'
46-
s.add_dependency "activemodel", '> 4'
47-
s.add_dependency "hashie"
48-
49-
s.add_development_dependency "bundler"
50-
s.add_development_dependency "rake", "~> 12"
37+
s.require_paths = ['lib']
5138

52-
s.add_development_dependency "oj" unless defined?(JRUBY_VERSION)
39+
s.extra_rdoc_files = ['README.md', 'LICENSE.txt']
40+
s.rdoc_options = ['--charset=UTF-8']
5341

54-
s.add_development_dependency "rails", '> 4'
42+
s.required_ruby_version = '>= 1.9.3'
5543

56-
s.add_development_dependency "minitest"
57-
s.add_development_dependency "test-unit"
58-
s.add_development_dependency "shoulda-context"
59-
s.add_development_dependency "mocha"
60-
s.add_development_dependency "turn"
61-
s.add_development_dependency "yard"
62-
s.add_development_dependency "ruby-prof" unless defined?(JRUBY_VERSION)
63-
s.add_development_dependency "pry"
44+
s.add_dependency 'activemodel', '> 4'
45+
s.add_dependency 'activesupport', '> 4'
46+
s.add_dependency 'elasticsearch', '~> 7'
47+
s.add_dependency 'elasticsearch-model', '7.2.1'
48+
s.add_dependency 'hashie'
6449

65-
s.add_development_dependency "simplecov"
66-
s.add_development_dependency "cane"
50+
s.add_development_dependency 'bundler'
51+
s.add_development_dependency 'cane'
52+
s.add_development_dependency 'minitest'
53+
s.add_development_dependency 'mocha'
54+
s.add_development_dependency 'oj' unless defined?(JRUBY_VERSION)
55+
s.add_development_dependency 'pry'
56+
s.add_development_dependency 'rails', '> 4'
57+
s.add_development_dependency 'rake', '~> 12'
58+
s.add_development_dependency 'ruby-prof' unless defined?(JRUBY_VERSION)
59+
s.add_development_dependency 'shoulda-context'
60+
s.add_development_dependency 'simplecov'
61+
s.add_development_dependency 'test-unit'
62+
s.add_development_dependency 'turn'
63+
s.add_development_dependency 'yard'
6764
end

elasticsearch-rails/Rakefile

+2
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,8 @@ namespace :test do
3434
test.warning = false
3535
test.deps = [:spec] unless defined?(JRUBY_VERSION)
3636
end
37+
38+
task unit: :spec
3739
end
3840

3941
namespace :bundle do

elasticsearch-rails/elasticsearch-rails.gemspec

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ Gem::Specification.new do |s|
2424
s.name = 'elasticsearch-rails'
2525
s.version = Elasticsearch::Rails::VERSION
2626
s.authors = ['Karel Minarik']
27-
s.email = ['karel.minarik@elasticsearch.org']
27+
s.email = ['support@elastic.co']
2828
s.description = 'Ruby on Rails integrations for Elasticsearch.'
2929
s.summary = 'Ruby on Rails integrations for Elasticsearch.'
3030
s.homepage = 'https://github.com/elasticsearch/elasticsearch-rails/'

0 commit comments

Comments
 (0)