Skip to content

check for string length when using is_file() #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2018
Merged

check for string length when using is_file() #5

merged 1 commit into from
Feb 28, 2018

Conversation

@sventendo
Copy link

@sventendo sventendo commented Feb 28, 2018

If the string length excedes the PHP_MAXPATHLEN value, is_file() should not be called.

@alcaeus
Copy link

alcaeus commented Feb 28, 2018

Thanks @sventendo! Build failure is unrelated, I'll have to take a separate look at that.

@alcaeus alcaeus merged commit 32e4a00 into thesoftwarefanatics:dev Feb 28, 2018
@alcaeus alcaeus added this to the 1.8.1 milestone Feb 28, 2018
@sventendo sventendo deleted the dev branch June 29, 2018 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@alcaeus alcaeus alcaeus approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

1.8.1

Development

Successfully merging this pull request may close these issues.

2 participants

@sventendo @alcaeus