Skip to content

Conversation

@nickyr
Copy link
Contributor

@nickyr nickyr commented Oct 17, 2016

Add Vindicia gateway to the list of gateways.

This is my first Omnipay driver, so any reviews of the code would be greatly appreciated: https://github.com/vimeo/omnipay-vindicia

Add Vindicia gateway to the list of gateways
@delatbabel
Copy link
Contributor

Hi Nicky,

Thanks for the contribution.

In the PR you have named this gateway "Vimeo" (at the start of the line that you changed) but I think that the correct gateway name is "Vindicia" -- "Vimeo" being your github login.

I will wait until you can fix this before merging.

I will put some code comments in the actual gateway.

Accidentally used my organization name
@nickyr
Copy link
Contributor Author

nickyr commented Oct 18, 2016

Whoops, good catch @delatbabel. Fixed!

Thanks!

@delatbabel delatbabel merged commit 62451c6 into thephpleague:master Oct 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants