Skip to content

Refactoring and testing. #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 2, 2013
Merged

Refactoring and testing. #5

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
e8e4359
Get position to fix writeMicroseconds.
ianjosephwilson May 30, 2013
baeb5f2
Always use build_cmd_str.
ianjosephwilson May 30, 2013
01627a4
Remove trailing whitespace and use consistent spacing.
ianjosephwilson May 30, 2013
7b4fce4
Remove unused attribute.
ianjosephwilson May 30, 2013
71b5e8f
Refactor Arduino and add sr argument to constructor to enable testing.
ianjosephwilson May 31, 2013
c618331
Add pure-python tests.
ianjosephwilson May 31, 2013
f89f7db
Fix port detection bugs and add more ports for linux.
ianjosephwilson May 31, 2013
2a98dcf
Only close serial port if not already closed.
ianjosephwilson May 31, 2013
6ba2991
Add another test to explicitly connect to a serial port.
ianjosephwilson May 31, 2013
f975f46
Use logging instead of print statements.
ianjosephwilson May 31, 2013
5bafbe7
Setup logging during testing.
ianjosephwilson May 31, 2013
ad388df
Force the user to enter a port during interactive testing.
ianjosephwilson May 31, 2013
17c2da9
Update documentation for shiftIn, shiftOut and additional tests.
ianjosephwilson May 31, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Force the user to enter a port during interactive testing.
  • Loading branch information
@ianjosephwilson
ianjosephwilson committed May 31, 2013
commit ad388df7b404e7f3d4c608302b089490472b3311
10 changes: 7 additions & 3 deletions tests/test_main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,13 @@ def test_find(self):

def test_open(self):
""" Tests connecting to an explicit port. """
port = raw_input(
'Plug in Arduino board w/LED at pin 13, reset.\n'\
'Enter the port where the Arduino is connected, then press enter:')
port = None
while not port:
port = raw_input(
'Plug in Arduino board w/LED at pin 13, reset.\n'\
'Enter the port where the Arduino is connected, then press enter:')
if not port:
print 'You must enter a port.'
from Arduino import Arduino
board = None
try:
Expand Down