Skip to content

Implement automatic releases #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mpeyper opened this issue Dec 4, 2020 · 2 comments
Closed

Implement automatic releases #501

mpeyper opened this issue Dec 4, 2020 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@mpeyper
Copy link
Member

mpeyper commented Dec 4, 2020

Describe the feature you'd like:

I'm barely finding time to respond to issues and review PRs these days, so often releases are only occuring a few days after they hit master. I'd love to have released go out automatically on successfully master builds.

Suggested implementation:

Semantic Release is the obvious choice here. Many @testing-library packages are already using it so we should have a pretty good template to follow.

Might be worth combining with or waiting for #499.

I haven't used semantic release before so any assistance is welcome.

Describe alternatives you've considered:

N/A

Teachability, Documentation, Adoption, Migration Strategy:

N/A

@mpeyper mpeyper added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Dec 4, 2020
@marcosvega91 marcosvega91 mentioned this issue Dec 4, 2020
4 tasks
@mpeyper mpeyper closed this as completed Dec 7, 2020
@marcosvega91
Copy link
Member

marcosvega91 commented Dec 7, 2020

I have seen that you have released a version manually. semantic-release will release a new version when the PR merged is of kind feat or fix. I could suggest you to use Squash and Merge in most cases so you can update the merge commit following the conventions. I hope it could help 😄

@mpeyper
Copy link
Member Author

mpeyper commented Dec 7, 2020

@marcosvega91, yeah, I tried to squash and merge a PR but I didn't realise there was a seperate field for the main commit message to the description and so I messed it up and semantic-release obviously just ignored it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants