From 344c362299953e898a6f431d921da6af58210e27 Mon Sep 17 00:00:00 2001
From: Tim Deschryver <28659384+timdeschryver@users.noreply.github.com>
Date: Wed, 26 Jul 2023 15:21:44 +0200
Subject: [PATCH] feat: add configureTestBed callback method

---
 projects/testing-library/src/lib/models.ts    | 50 ++++++++++-------
 .../src/lib/testing-library.ts                |  5 ++
 .../issue-396-standalone-stub-child.spec.ts   | 54 +++++++++++++++++++
 projects/testing-library/tests/render.spec.ts | 11 ++++
 4 files changed, 102 insertions(+), 18 deletions(-)
 create mode 100644 projects/testing-library/tests/issues/issue-396-standalone-stub-child.spec.ts

diff --git a/projects/testing-library/src/lib/models.ts b/projects/testing-library/src/lib/models.ts
index c1c68c2..2e198a6 100644
--- a/projects/testing-library/src/lib/models.ts
+++ b/projects/testing-library/src/lib/models.ts
@@ -1,5 +1,5 @@
 import { Type, DebugElement } from '@angular/core';
-import { ComponentFixture } from '@angular/core/testing';
+import { ComponentFixture, TestBed } from '@angular/core/testing';
 import { Routes } from '@angular/router';
 import { BoundFunction, Queries, queries, Config as dtlConfig, PrettyDOMOptions } from '@testing-library/dom';
 
@@ -74,7 +74,7 @@ export interface RenderComponentOptions<ComponentType, Q extends Queries = typeo
    * true
    *
    * @example
-   * const component = await render(AppComponent, {
+   * await render(AppComponent, {
    *  autoDetectChanges: false
    * })
    */
@@ -87,7 +87,7 @@ export interface RenderComponentOptions<ComponentType, Q extends Queries = typeo
    * true
    *
    * @example
-   * const component = await render(AppComponent, {
+   * await render(AppComponent, {
    *  detectChangesOnRender: false
    * })
    */
@@ -103,7 +103,7 @@ export interface RenderComponentOptions<ComponentType, Q extends Queries = typeo
    * []
    *
    * @example
-   * const component = await render(AppComponent, {
+   * await render(AppComponent, {
    *  declarations: [ CustomerDetailComponent, ButtonComponent ]
    * })
    */
@@ -118,7 +118,7 @@ export interface RenderComponentOptions<ComponentType, Q extends Queries = typeo
    * []
    *
    * @example
-   * const component = await render(AppComponent, {
+   * await render(AppComponent, {
    *  providers: [
    *    CustomersService,
    *    {
@@ -140,7 +140,7 @@ export interface RenderComponentOptions<ComponentType, Q extends Queries = typeo
    * `[NoopAnimationsModule]`
    *
    * @example
-   * const component = await render(AppComponent, {
+   * await render(AppComponent, {
    *  imports: [
    *    AppSharedModule,
    *    MaterialModule,
@@ -159,7 +159,7 @@ export interface RenderComponentOptions<ComponentType, Q extends Queries = typeo
    * []
    *
    * @example
-   * const component = await render(AppComponent, {
+   * await render(AppComponent, {
    *  schemas: [
    *    NO_ERRORS_SCHEMA,
    *  ]
@@ -174,7 +174,7 @@ export interface RenderComponentOptions<ComponentType, Q extends Queries = typeo
    * {}
    *
    * @example
-   * const component = await render(AppComponent, {
+   * await render(AppComponent, {
    *  componentProperties: {
    *    counterValue: 10,
    *    send: (value) => { ... }
@@ -190,7 +190,7 @@ export interface RenderComponentOptions<ComponentType, Q extends Queries = typeo
    * {}
    *
    * @example
-   * const component = await render(AppComponent, {
+   * await render(AppComponent, {
    *  componentInputs: {
    *    counterValue: 10
    *  }
@@ -206,7 +206,7 @@ export interface RenderComponentOptions<ComponentType, Q extends Queries = typeo
    *
    * @example
    * const sendValue = (value) => { ... }
-   * const component = await render(AppComponent, {
+   * await render(AppComponent, {
    *  componentOutputs: {
    *    send: {
    *      emit: sendValue
@@ -225,7 +225,7 @@ export interface RenderComponentOptions<ComponentType, Q extends Queries = typeo
    * []
    *
    * @example
-   * const component = await render(AppComponent, {
+   * await render(AppComponent, {
    *  componentProviders: [
    *    AppComponentService
    *  ]
@@ -259,7 +259,7 @@ export interface RenderComponentOptions<ComponentType, Q extends Queries = typeo
    * undefined
    *
    * @example
-   * const component = await render(AppComponent, {
+   * await render(AppComponent, {
    *   componentImports: [
    *     MockChildComponent
    *   ]
@@ -277,7 +277,7 @@ export interface RenderComponentOptions<ComponentType, Q extends Queries = typeo
    * import * as customQueries from 'custom-queries'
    * import { queries } from '@testing-library/angular'
    *
-   * const component = await render(AppComponent, {
+   * await render(AppComponent, {
    *  queries: { ...queries, ...customQueries }
    * })
    */
@@ -291,7 +291,7 @@ export interface RenderComponentOptions<ComponentType, Q extends Queries = typeo
    * false
    *
    * @example
-   * const component = await render(AppComponent, {
+   * await render(AppComponent, {
    *  imports: [AppModule], // a module that includes AppComponent
    *  excludeComponentDeclaration: true
    * })
@@ -304,7 +304,7 @@ export interface RenderComponentOptions<ComponentType, Q extends Queries = typeo
    * For more info see https://angular.io/api/router/Routes.
    *
    * @example
-   * const component = await render(AppComponent, {
+   * await render(AppComponent, {
    *  declarations: [ChildComponent],
    *  routes: [
    *    {
@@ -326,7 +326,7 @@ export interface RenderComponentOptions<ComponentType, Q extends Queries = typeo
    * Specifies which route should be initially navigated to
    *
    * @example
-   * const component = await render(AppComponent, {
+   * await render(AppComponent, {
    *  initialRoute: 'myroute',
    *  routes: [
    *    { path: '', component: HomeComponent },
@@ -344,11 +344,25 @@ export interface RenderComponentOptions<ComponentType, Q extends Queries = typeo
    * `false`
    *
    * @example
-   * const component = await render(AppComponent, {
+   * await render(AppComponent, {
    *  removeAngularAttributes: true
    * })
    */
   removeAngularAttributes?: boolean;
+
+  /**
+   * @description
+   * Callback to configure the testbed before the compilation.
+   *
+   * @default
+   * () => {}
+   *
+   * @example
+   * await render(AppComponent, {
+   *  configureTestBed: (testBed) => { }
+   * })
+   */
+  configureTestBed?: (testbed: TestBed) => void;
 }
 
 export interface ComponentOverride<T> {
@@ -368,7 +382,7 @@ export interface RenderTemplateOptions<WrapperType, Properties extends object =
    * `WrapperComponent`, an empty component that strips the `ng-version` attribute
    *
    * @example
-   * const component = await render(`<div spoiler message='SPOILER'></div>`, {
+   * await render(`<div spoiler message='SPOILER'></div>`, {
    *  declarations: [SpoilerDirective]
    *  wrapper: CustomWrapperComponent
    * })
diff --git a/projects/testing-library/src/lib/testing-library.ts b/projects/testing-library/src/lib/testing-library.ts
index 66cb819..974402f 100644
--- a/projects/testing-library/src/lib/testing-library.ts
+++ b/projects/testing-library/src/lib/testing-library.ts
@@ -65,6 +65,9 @@ export async function render<SutType, WrapperType = SutType>(
     removeAngularAttributes = false,
     defaultImports = [],
     initialRoute = '',
+    configureTestBed = () => {
+      /* noop*/
+    },
   } = { ...globalConfig, ...renderOptions };
 
   dtlConfigure({
@@ -94,6 +97,8 @@ export async function render<SutType, WrapperType = SutType>(
   overrideComponentImports(sut, componentImports);
   overrideChildComponentProviders(childComponentOverrides);
 
+  configureTestBed(TestBed);
+
   await TestBed.compileComponents();
 
   componentProviders
diff --git a/projects/testing-library/tests/issues/issue-396-standalone-stub-child.spec.ts b/projects/testing-library/tests/issues/issue-396-standalone-stub-child.spec.ts
new file mode 100644
index 0000000..306297a
--- /dev/null
+++ b/projects/testing-library/tests/issues/issue-396-standalone-stub-child.spec.ts
@@ -0,0 +1,54 @@
+import { Component } from '@angular/core';
+import { render, screen } from '../../src/public_api';
+
+test('child', async () => {
+  await render(FixtureComponent);
+  expect(screen.getByText('Hello from child')).toBeInTheDocument();
+});
+
+test('stub', async () => {
+  await render(FixtureComponent, {
+    componentImports: [StubComponent],
+  });
+
+  expect(screen.getByText('Hello from stub')).toBeInTheDocument();
+});
+
+test('configure', async () => {
+  await render(FixtureComponent, {
+    configureTestBed: (testBed) => {
+      testBed.overrideComponent(FixtureComponent, {
+        add: {
+          imports: [StubComponent],
+        },
+        remove: {
+          imports: [ChildComponent],
+        },
+      });
+    },
+  });
+
+  expect(screen.getByText('Hello from stub')).toBeInTheDocument();
+});
+
+@Component({
+  selector: 'atl-child',
+  template: `Hello from child`,
+  standalone: true,
+})
+class ChildComponent {}
+
+@Component({
+  selector: 'atl-child',
+  template: `Hello from stub`,
+  standalone: true,
+})
+class StubComponent {}
+
+@Component({
+  selector: 'atl-fixture',
+  template: `<atl-child />`,
+  standalone: true,
+  imports: [ChildComponent],
+})
+class FixtureComponent {}
diff --git a/projects/testing-library/tests/render.spec.ts b/projects/testing-library/tests/render.spec.ts
index 2290b90..4b546e0 100644
--- a/projects/testing-library/tests/render.spec.ts
+++ b/projects/testing-library/tests/render.spec.ts
@@ -366,3 +366,14 @@ describe('initialRoute', () => {
     expect(screen.getByText('button')).toBeInTheDocument();
   });
 });
+
+describe('configureTestBed', () => {
+  it('invokes configureTestBed', async () => {
+    const configureTestBedFn = jest.fn();
+    await render(FixtureComponent, {
+      configureTestBed: configureTestBedFn,
+    });
+
+    expect(configureTestBedFn).toHaveBeenCalledTimes(1);
+  });
+});