From 44527e7c905c23ff3e1b35d1bc46b1c33a798557 Mon Sep 17 00:00:00 2001
From: Tim Deschryver <28659384+timdeschryver@users.noreply.github.com>
Date: Sat, 10 Dec 2022 18:17:33 +0100
Subject: [PATCH] feat: remove detectChanges in favor of detectChangesOnRender

BREAKING CHANGE:
The config property detectChanges is renamed to detectChangesOnRender.

BEFORE:

const component = await render(AppComponent, {
  detectChanges: false
});

AFTER:

const component = await render(AppComponent, {
  detectChangesOnRender: false
});
---
 projects/testing-library/src/lib/models.ts       | 16 ----------------
 .../testing-library/src/lib/testing-library.ts   |  6 +-----
 2 files changed, 1 insertion(+), 21 deletions(-)

diff --git a/projects/testing-library/src/lib/models.ts b/projects/testing-library/src/lib/models.ts
index d225df8..51fe5f7 100644
--- a/projects/testing-library/src/lib/models.ts
+++ b/projects/testing-library/src/lib/models.ts
@@ -89,22 +89,6 @@ export interface RenderComponentOptions<ComponentType, Q extends Queries = typeo
    * })
    */
   autoDetectChanges?: boolean;
-  /**
-   * @description
-   * Will call detectChanges when the component is compiled
-   *
-   * @default
-   * true
-   *
-   * @example
-   * const component = await render(AppComponent, {
-   *  detectChanges: false
-   * })
-   *
-   * @deprecated
-   * Use `detectChangesOnRender` instead
-   */
-  detectChanges?: boolean;
   /**
    * @description
    * Invokes `detectChanges` after the component is rendered
diff --git a/projects/testing-library/src/lib/testing-library.ts b/projects/testing-library/src/lib/testing-library.ts
index 6a3e70c..1b1428d 100644
--- a/projects/testing-library/src/lib/testing-library.ts
+++ b/projects/testing-library/src/lib/testing-library.ts
@@ -46,8 +46,7 @@ export async function render<SutType, WrapperType = SutType>(
 ): Promise<RenderResult<SutType>> {
   const { dom: domConfig, ...globalConfig } = getConfig();
   const {
-    detectChanges: detectChangesDeprecated = true,
-    detectChangesOnRender: detectChangesOnRenderInput,
+    detectChangesOnRender = true,
     autoDetectChanges = true,
     declarations = [],
     imports = [],
@@ -67,9 +66,6 @@ export async function render<SutType, WrapperType = SutType>(
     defaultImports = [],
   } = { ...globalConfig, ...renderOptions };
 
-  const detectChangesOnRender =
-    detectChangesOnRenderInput === undefined ? detectChangesDeprecated : detectChangesOnRenderInput;
-
   dtlConfigure(domConfig);
 
   TestBed.configureTestingModule({