From c3cdc57e19ca7eab98f07fd9b77d583881ceb968 Mon Sep 17 00:00:00 2001 From: "allcontributors[bot]" <46447321+allcontributors[bot]@users.noreply.github.com> Date: Sat, 15 May 2021 19:33:09 +0200 Subject: [PATCH 1/3] docs: add jwillebrands as a contributor (#216) --- .all-contributorsrc | 9 +++++++++ README.md | 1 + 2 files changed, 10 insertions(+) diff --git a/.all-contributorsrc b/.all-contributorsrc index 78360b45..d198fbb0 100644 --- a/.all-contributorsrc +++ b/.all-contributorsrc @@ -216,6 +216,15 @@ "contributions": [ "infra" ] + }, + { + "login": "jwillebrands", + "name": "Jan-Willem Willebrands", + "avatar_url": "https://avatars.githubusercontent.com/u/8925?v=4", + "profile": "https://github.com/jwillebrands", + "contributions": [ + "code" + ] } ], "contributorsPerLine": 7, diff --git a/README.md b/README.md index e7788a2c..f2307eed 100644 --- a/README.md +++ b/README.md @@ -213,6 +213,7 @@ Thanks goes to these people ([emoji key][emojis]):
Amit Miran

🚇 +
Jan-Willem Willebrands

💻 From 5bf154f818898b4142dcf99353230824cb8d08ad Mon Sep 17 00:00:00 2001 From: Tim Deschryver <28659384+timdeschryver@users.noreply.github.com> Date: Sat, 15 May 2021 19:52:42 +0200 Subject: [PATCH 2/3] ci: fix GA triggers (#217) --- .github/workflows/ci.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index d731bd75..853f8977 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -2,9 +2,10 @@ name: ci on: push: - pull_request: branches: - main + pull_request: + types: [opened, synchronize, reopened] jobs: build_test_release: From 79019d598cbbfeac55d43c5a646457e445e50e89 Mon Sep 17 00:00:00 2001 From: Tim Deschryver <28659384+timdeschryver@users.noreply.github.com> Date: Tue, 18 May 2021 18:26:08 +0200 Subject: [PATCH 3/3] fix: add safety check around process before cleaning up (#218) This fixes the problems with Karma. --- .../testing-library/src/lib/testing-library.ts | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/projects/testing-library/src/lib/testing-library.ts b/projects/testing-library/src/lib/testing-library.ts index 3c3b86f7..98d0a2da 100644 --- a/projects/testing-library/src/lib/testing-library.ts +++ b/projects/testing-library/src/lib/testing-library.ts @@ -352,10 +352,16 @@ function cleanupAtFixture(fixture) { mountedFixtures.delete(fixture); } -if (typeof afterEach === 'function' && !process.env.ATL_SKIP_AUTO_CLEANUP) { - afterEach(async () => { - cleanup(); - }); +// if we're running in a test runner that supports afterEach +// then we'll automatically run cleanup afterEach test +// this ensures that tests run in isolation from each other +// if you don't like this, set the ATL_SKIP_AUTO_CLEANUP env variable to 'true' +if (typeof process === 'undefined' || !process.env?.ATL_SKIP_AUTO_CLEANUP) { + if (typeof afterEach === 'function') { + afterEach(() => { + cleanup(); + }); + } } // TODO: rename to `atl-wrapper-component`