Skip to content

Commit db64d2f

Browse files
committed
Fixing 300 baud communication for serial.
Because UBBR is only 12 bits, we were overflowing it at 300 baud because of the use of the U2X bit. Now we turn off U2X if it would yield a UBBR value that would overflow. Note that this breaks 300 baud communication with the computer on the Uno and Mega 2560 because the 8U2 USB-serial firmware has this same bug (and previously they cancelled each other out). Since, however, it seems more likely that people will need to use 300 baud to communicate with other (legacy) hardware than with the computer, I'm making this change. Issue for 8U2 firmware bug: http://code.google.com/p/arduino/issues/detail?id=542 http://code.google.com/p/arduino/issues/detail?id=522
1 parent fcb66dd commit db64d2f

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

hardware/arduino/cores/arduino/HardwareSerial.cpp

+8
Original file line numberDiff line numberDiff line change
@@ -204,6 +204,8 @@ void HardwareSerial::begin(unsigned long baud)
204204
use_u2x = false;
205205
}
206206
#endif
207+
208+
try_again:
207209

208210
if (use_u2x) {
209211
*_ucsra = 1 << _u2x;
@@ -212,6 +214,12 @@ void HardwareSerial::begin(unsigned long baud)
212214
*_ucsra = 0;
213215
baud_setting = (F_CPU / 8 / baud - 1) / 2;
214216
}
217+
218+
if ((baud_setting > 4095) && use_u2x)
219+
{
220+
use_u2x = false;
221+
goto try_again;
222+
}
215223

216224
// assign the baud_setting, a.k.a. ubbr (USART Baud Rate Register)
217225
*_ubrrh = baud_setting >> 8;

0 commit comments

Comments
 (0)