Merge pull request #452 from kt3k/fix-exit-code

fix: return exit code 1 when dead links found

Author: tcort

markdown-link-check

@@ -451,7 +451,7 @@ async function runMarkdownLinkCheck(filenameForOutput, markdown, opts) {
     ));
 
     if (err) throw null;
-    else if (results.some((result) => result.status === 'dead')) return;
+    else if (results.some((result) => result.status === 'dead')) throw null;
     else return;
 }
 

test/markdown-link-check.test.js

@@ -5,6 +5,7 @@ const path = require('path');
 const expect = require('expect.js');
 const http = require('http');
 const express = require('express');
+const child_process = require('child_process');
 const markdownLinkCheck = require('../');
 const dirname = process.platform === 'win32' ? __dirname.replace(/\\/g, '/') : __dirname;
 
@@ -442,4 +443,21 @@ describe('markdown-link-check', function () {
             done();
         });
     });
+
+    describe("CLI", function () {
+        const cliPath = path.join(__dirname, '..', 'markdown-link-check');
+
+        it("exits with 0 if all links are ok", function () {
+            const { status, output } = child_process.spawnSync(process.execPath, [cliPath, path.join(__dirname, 'alive-links-only.md')]);
+            expect(status).to.be(0);
+            expect(output.toString()).to.contain('links checked.');
+        });
+
+        it("exits with 1 if any link is broken", function () {
+            this.timeout(60000)
+            const { status, output } = child_process.spawnSync(process.execPath, [cliPath, [path.join(__dirname, 'section-links.md')]]);
+            expect(status).to.be(1);
+            expect(output.toString()).to.contain('dead links found!');
+        });
+    });
 });