Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: symfony/http-kernel
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v4.4.33
Choose a base ref
...
head repository: symfony/http-kernel
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4.4.34
Choose a head ref
  • 6 commits
  • 4 files changed
  • 4 contributors

Commits on Oct 29, 2021

  1. Bump Symfony version to 4.4.34

    fabpot committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    8268f8c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5b25580 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2021

  1. bug #43501 [HttpKernel] fix ErrorException in CacheWarmerAggregate (A…

    …hummeling)
    
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [HttpKernel] fix ErrorException in CacheWarmerAggregate
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Tickets      |
    | License       | MIT
    | Doc PR        |
    
    I ran into an `ErrorException` reloading after some changes. I suppose this triggered a cache warmup call. This didn't go as expected, because `$previousLogs = unserialize(file_get_contents($this->deprecationLogsFilepath));` set `$previousLogs` to `false` instead of the expected array. I think it makes sense to only call `array_merge` if `$previousLogs` was successfully instantiated as an array.
    
    My IDE also pointed out that `$collectedLogs` was possible undefined, so moving its declaration outside of the if block resolved that.
    
    Stacktrace:
    ```
    ErrorException:
    Warning: array_merge(): Expected parameter 1 to be an array, bool given
    
      at /srv/vendor/symfony/http-kernel/CacheWarmer/CacheWarmerAggregate.php:106
      at Symfony\Component\HttpKernel\CacheWarmer\CacheWarmerAggregate->warmUp('/srv/var/cache/local')
         (/srv/vendor/symfony/http-kernel/Kernel.php:584)
      at Symfony\Component\HttpKernel\Kernel->initializeContainer()
         (/srv/vendor/symfony/http-kernel/Kernel.php:786)
      at Symfony\Component\HttpKernel\Kernel->preBoot()
         (/srv/vendor/symfony/http-kernel/Kernel.php:187)
      at Symfony\Component\HttpKernel\Kernel->handle(object(Request))
         (/srv/public/index.php:44)
    ```
    
    Commits
    -------
    
    2eaa19f46f fix ErrorExcception in CacheWarmerAggregate
    fabpot committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    2ac1ef6 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2021

  1. Fix typos

    noniagriconomie authored Nov 3, 2021
    Configuration menu
    Copy the full SHA
    73636d9 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2021

  1. Configuration menu
    Copy the full SHA
    39035d5 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2021

  1. Update VERSION for 4.4.34

    fabpot committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    4780598 View commit details
    Browse the repository at this point in the history
Loading