Skip to content

Commit dcc10ba

Browse files
committed
SwiftPrivateThreadExtras: address improvement suggestions
Use `ThreadHandle(bitPattern:)` rather than `unsafeBitCast` for the conversion of the `uintptr_t` to the `HANDLE`. Convert a variable from `var` to `let` binding.
1 parent 7d6af90 commit dcc10ba

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

stdlib/private/SwiftPrivateThreadExtras/SwiftPrivateThreadExtras.swift

+2-2
Original file line numberDiff line numberDiff line change
@@ -89,14 +89,14 @@ public func _stdlib_thread_create_block<Argument, Result>(
8989
let contextAsVoidPointer = Unmanaged.passRetained(context).toOpaque()
9090

9191
#if os(Windows)
92-
var threadID =
92+
let threadID =
9393
_beginthreadex(nil, 0, { invokeBlockContext($0)!
9494
.assumingMemoryBound(to: UInt32.self).pointee },
9595
contextAsVoidPointer, 0, nil)
9696
if threadID == 0 {
9797
return (errno, nil)
9898
} else {
99-
return (0, unsafeBitCast(threadID, to: ThreadHandle.self))
99+
return (0, ThreadHandle(bitPattern: threadID))
100100
}
101101
#else
102102
var threadID = _make_pthread_t()

0 commit comments

Comments
 (0)