Skip to content

Renovate heap system to avoid polluting object #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 18, 2020
Merged

Renovate heap system to avoid polluting object #19

merged 2 commits into from
Jul 18, 2020
+40 −18

Conversation

kateinoigakukun
Copy link
Member

@kateinoigakukun kateinoigakukun commented Jul 18, 2020 •
edited
Loading

Resolve #18

Before

Running 'Serialization/Write JavaScript number directly' ...
done 120.80175709724426 ms
Running 'Serialization/Write JavaScript string directly' ...
done 122.2523729801178 ms
Running 'Serialization/Swift Int to JavaScript' ...
done 3196.50106716156 ms
Running 'Serialization/Swift String to JavaScript' ...
done 4943.781615972519 ms
Running 'Object heap/Increment and decrement RC' ...
done 3109.1712770462036 ms

After

Running 'Serialization/Write JavaScript number directly' ...
done 119.7573311328888 ms
Running 'Serialization/Write JavaScript string directly' ...
done 124.71527099609375 ms
Running 'Serialization/Swift Int to JavaScript' ...
done 3120.5893318653107 ms
Running 'Serialization/Swift String to JavaScript' ...
done 4833.4492201805115 ms
Running 'Object heap/Increment and decrement RC' ...
done 2962.947032928467 ms

@kateinoigakukun kateinoigakukun mentioned this pull request Jul 18, 2020
Closed
@kateinoigakukun kateinoigakukun merged commit cc65b0e into master Jul 18, 2020
@kateinoigakukun kateinoigakukun deleted the fix-heap-system branch July 18, 2020 14:06
@MaxDesiatov
Copy link
Contributor

Would you be able to tag a new release with it? Thanks!

@MaxDesiatov
Copy link
Contributor

MaxDesiatov commented Jul 18, 2020 •
edited
Loading

Or I can tag it if you don't mind 🙂

@kateinoigakukun
Copy link
Member Author

Sorry, I'll tag a new version

@MaxDesiatov MaxDesiatov mentioned this pull request Jul 19, 2020
Merged
MaxDesiatov added a commit to swiftwasm/carton that referenced this pull request Jul 19, 2020
@MaxDesiatov
Update static.zip, automate its release process (#60)
749a17d 
`dev.js` entrypoint has been updated to include the recent JavaScriptKit runtime fix: swiftwasm/JavaScriptKit#19

I've also added a new subcommand to `carton-release`, which is now able to automaticallly create a new `static.zip` and record updated hashes in the source code. It still doesn't upload the archive automatically to previous release assets, but I wonder if that should be done manually anyway, at least until we have some kind of tests that verify the whole process end-to-end.

Additionally, since the new runtime is not compatible with the old Swift parts of JavaScriptKit, `carton dev` now checks the revision of JavaScriptKit that projects have specified in their `Package.swift`. It doesn't block the build process, but I hope it gives enough warning about the incompatibility.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accessing localStorage fails
2 participants
@kateinoigakukun @MaxDesiatov