Skip to content

Commit f5149ad

Browse files
committed
Change threshold calculation to account for vastly different benchmark times
1 parent b8027a9 commit f5149ad

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

perf-tester/src/utils.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { exec } from '@actions/exec';
66
export const getInput = key => ({
77
'build-script': 'make bootstrap benchmark_setup',
88
benchmark: 'make -s run_benchmark',
9-
'minimum-change-threshold': 50,
9+
'minimum-change-threshold': 5,
1010
'use-check': 'no',
1111
'repo-token': process.env.GITHUB_TOKEN
1212
})[key]
@@ -178,7 +178,7 @@ export function diffTable(tests, { showTotal, collapseUnchanged, omitUnchanged,
178178
totalDelta += delta;
179179

180180
const difference = ((delta / time) * 100) | 0;
181-
const isUnchanged = Math.abs(delta) < minimumChangeThreshold;
181+
const isUnchanged = Math.abs(difference) < minimumChangeThreshold;
182182

183183
if (isUnchanged && omitUnchanged) continue;
184184

0 commit comments

Comments
 (0)