Add a switch fallthrough to reduce duplicated code

j-f1 · j-f1 · commit 34c6d86d2a07 · 2020-08-02T09:15:54.000-04:00
diff --git a/Runtime/src/index.ts b/Runtime/src/index.ts
@@ -180,7 +180,8 @@ export class SwiftRuntime {
                       dataView.getUint32(payload2_ptr, true)
                     );
                 }
-                case JavaScriptValueKind.Object: {
+                case JavaScriptValueKind.Object:
+                case JavaScriptValueKind.Function: {
                     return this.heap.referenceHeap(dataView.getUint32(payload1_ptr, true))
                 }
                 case JavaScriptValueKind.Null: {
@@ -189,9 +190,6 @@ export class SwiftRuntime {
                 case JavaScriptValueKind.Undefined: {
                     return undefined
                 }
-                case JavaScriptValueKind.Function: {
-                    return this.heap.referenceHeap(dataView.getUint32(payload1_ptr, true))
-                }
                 default:
                     throw new Error(`Type kind "${kind}" is not supported`)
             }

Original file line number	Diff line number	Diff line change
`@@ -180,7 +180,8 @@ export class SwiftRuntime {`
`180`	`180`	`dataView.getUint32(payload2_ptr, true)`
`181`	`181`	`);`
`182`	`182`	`}`
`183`		`- case JavaScriptValueKind.Object: {`
	`183`	`+ case JavaScriptValueKind.Object:`
	`184`	`+ case JavaScriptValueKind.Function: {`
`184`	`185`	`return this.heap.referenceHeap(dataView.getUint32(payload1_ptr, true))`
`185`	`186`	`}`
`186`	`187`	`case JavaScriptValueKind.Null: {`
`@@ -189,9 +190,6 @@ export class SwiftRuntime {`
`189`	`190`	`case JavaScriptValueKind.Undefined: {`
`190`	`191`	`return undefined`
`191`	`192`	`}`
`192`		`- case JavaScriptValueKind.Function: {`
`193`		`- return this.heap.referenceHeap(dataView.getUint32(payload1_ptr, true))`
`194`		`- }`
`195`	`193`	`default:`
`196`	`194`	throw new Error(`Type kind "${kind}" is not supported`)
`197`	`195`	`}`