Pick highest installed MSVC version (#1658)

GitHub keeps changing the builder image out from under us. In this case
it looks like they moved it back to the old version we had before.

To try and ease the pain simply pick the highest installed MSVC version.

Author: plemarquand

scripts/package.ts

@@ -26,6 +26,12 @@ main(async () => {
     const rootDirectory = getRootDirectory();
     const version = await getExtensionVersion();
     const versionString = `${version.major}.${version.minor}.${version.patch}`;
+
+    if (process.platform === "win32") {
+        console.log("Packaging the extension is not supported on Windows.");
+        return process.exit(0);
+    }
+
     // Update version in CHANGELOG
     await updateChangelog(versionString);
     // Use VSCE to package the extension

scripts/test_windows.ps1

@@ -16,10 +16,20 @@ function Update-SwiftBuildAndPackageArguments {
     param (
         [string]$jsonFilePath = "./assets/test/.vscode/settings.json",
         [string]$codeWorkspaceFilePath = "./assets/test.code-workspace",
-        [string]$windowsSdkVersion = "10.0.22000.0",
-        [string]$vcToolsVersion = "14.44.35207"
+        [string]$windowsSdkVersion = "10.0.22000.0"
     )
 
+    $vcToolsPath = "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC"
+    $vcToolsVersions = Get-ChildItem -Directory -Path $vcToolsPath | ForEach-Object { $_.Name }
+
+    if ($vcToolsVersions.Count -eq 0) {
+        Write-Host "No versions found in $vcToolsPath"
+        exit 1
+    }
+
+    $vcToolsVersion = $vcToolsVersions | Sort-Object -Descending | Select-Object -First 1
+    Write-Host "Highest Visual C++ Tools version: $vcToolsVersion"
+
     $windowsSdkRoot = "C:\Program Files (x86)\Windows Kits\10\"
 
     try {
@@ -39,7 +49,6 @@ function Update-SwiftBuildAndPackageArguments {
     if ($jsonContent.PSObject.Properties['swift.buildArguments']) {
         $jsonContent.PSObject.Properties.Remove('swift.buildArguments')
     }
-    
 
     $jsonContent | Add-Member -MemberType NoteProperty -Name "swift.buildArguments" -Value @(
         "-Xbuild-tools-swiftc", "-windows-sdk-root", "-Xbuild-tools-swiftc", $windowsSdkRoot,
@@ -63,7 +72,6 @@ function Update-SwiftBuildAndPackageArguments {
         "-Xswiftc", "-visualc-tools-version", "-Xswiftc", $vcToolsVersion
     )
 
-
     $codeWorkspaceContent.PSObject.Properties.Remove('settings')
     $codeWorkspaceContent | Add-Member -MemberType NoteProperty -Name "settings" -Value $jsonContent
 
@@ -88,6 +96,12 @@ if ($LASTEXITCODE -ne 0) {
 Write-Host "Swift version:"
 Write-Host "$swiftVersionOutput"
 
+Write-Host "Installed MSVC Versions:"
+dir "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC"
+
+Write-Host "Installed Windows SDK Versions:"
+dir "C:\Program Files (x86)\Windows Kits\10\Include\"
+
 $versionLine = $swiftVersionOutput[0]
 if ($versionLine -match "Swift version (\d+)\.(\d+)") {
     Write-Host "Matched Swift version: $($matches[0]), $($matches[1]), $($matches[2])"