[SSADestroyHoisting] Removed incorrect mutation.

nate-chandler · nate-chandler · commit ffea048bab13 · 2022-02-18T10:10:17.000-08:00
The classifyInstruciton function shouldn't modify state.
diff --git a/lib/SILOptimizer/Transforms/SSADestroyHoisting.cpp b/lib/SILOptimizer/Transforms/SSADestroyHoisting.cpp
@@ -268,7 +268,6 @@ DeinitBarriers::DestroyReachability::classifyInstruction(SILInstruction *inst) {
     return Classification::DeadUser;
   }
   if (inst == storageDefInst) {
-    result.barriers.push_back(inst);
     return Classification::Barrier;
   }
   if (knownUses.storageUsers.contains(inst)) {

Original file line number	Diff line number	Diff line change
`@@ -268,7 +268,6 @@ DeinitBarriers::DestroyReachability::classifyInstruction(SILInstruction *inst) {`
`268`	`268`	`return Classification::DeadUser;`
`269`	`269`	`}`
`270`	`270`	`if (inst == storageDefInst) {`
`271`		`- result.barriers.push_back(inst);`
`272`	`271`	`return Classification::Barrier;`
`273`	`272`	`}`
`274`	`273`	`if (knownUses.storageUsers.contains(inst)) {`