[region-isolation] Ensure that some NDEBUG code is properly guarded.

Author: gottesmm

Diff for: include/swift/SILOptimizer/Analysis/RegionAnalysis.h

@@ -34,6 +34,14 @@ namespace regionanalysisimpl {
 extern bool AbortOnUnknownPatternMatchError;
 #endif
 
+static inline bool shouldAbortOnUnknownPatternMatchError() {
+#ifndef NDEBUG
+  return AbortOnUnknownPatternMatchError;
+#else
+  return false;
+#endif
+}
+
 using TransferringOperandSetFactory = Partition::TransferringOperandSetFactory;
 using Element = PartitionPrimitives::Element;
 using Region = PartitionPrimitives::Region;

Diff for: lib/SILOptimizer/Analysis/RegionAnalysis.cpp

@@ -1206,7 +1206,7 @@ struct PartitionOpBuilder {
   }
 
   void addUnknownPatternError(SILValue value) {
-    if (AbortOnUnknownPatternMatchError) {
+    if (shouldAbortOnUnknownPatternMatchError()) {
       llvm::report_fatal_error(
           "RegionIsolation: Aborting on unknown pattern match error");
     }

Diff for: lib/SILOptimizer/Mandatory/TransferNonSendable.cpp

@@ -678,7 +678,7 @@ class UseAfterTransferDiagnosticEmitter {
   }
 
   void emitUnknownPatternError() {
-    if (AbortOnUnknownPatternMatchError) {
+    if (shouldAbortOnUnknownPatternMatchError()) {
       llvm::report_fatal_error(
           "RegionIsolation: Aborting on unknown pattern match error");
     }
@@ -1095,7 +1095,7 @@ void TransferNonSendableImpl::emitUseAfterTransferDiagnostics() {
     // tells the user to file a bug. This importantly ensures that we can
     // guarantee that we always find the require if we successfully compile.
     if (!didEmitRequireNote) {
-      if (AbortOnUnknownPatternMatchError) {
+      if (shouldAbortOnUnknownPatternMatchError()) {
         llvm::report_fatal_error(
             "RegionIsolation: Aborting on unknown pattern match error");
       }
@@ -1158,7 +1158,7 @@ class TransferNonTransferrableDiagnosticEmitter {
   }
 
   void emitUnknownPatternError() {
-    if (AbortOnUnknownPatternMatchError) {
+    if (shouldAbortOnUnknownPatternMatchError()) {
       llvm::report_fatal_error(
           "RegionIsolation: Aborting on unknown pattern match error");
     }
@@ -1648,7 +1648,7 @@ struct DiagnosticEvaluator final
   }
 
   void handleUnknownCodePattern(const PartitionOp &op) const {
-    if (AbortOnUnknownPatternMatchError) {
+    if (shouldAbortOnUnknownPatternMatchError()) {
       llvm::report_fatal_error(
           "RegionIsolation: Aborting on unknown pattern match error");
     }