omitNeedlessWords: delete accidentally dead code

StringRef::drop_back returns a new string instead of mutating the
existing one, so this check would never actually make a
difference. Drat.

Author: jrose-apple

Diff for: lib/Basic/StringExtras.cpp

@@ -680,13 +680,6 @@ static Words::iterator matchTypeNameFromBackWithSpecialCases(
       auto newShortenedNameWord
         = omitNeedlessWords(shortenedNameWord, typeName.CollectionElement,
                             NameRole::Partial, allPropertyNames);
-      if (shortenedNameWord == newShortenedNameWord &&
-          shortenedNameWord.back() == 'e') {
-        (void)shortenedNameWord.drop_back();
-        newShortenedNameWord =
-          omitNeedlessWords(shortenedNameWord, typeName.CollectionElement,
-                            NameRole::Partial, allPropertyNames);
-      }
 
       if (shortenedNameWord != newShortenedNameWord) {
         unsigned targetSize = newShortenedNameWord.size();