Skip to content

Commit e0def4e

Browse files
authored
Unset LLVM_ENABLE_RUNTIMES in CMake caches (#61435)
This would be needed for two reasons: * avoid that testing for PRs that use `LLVM_ENABLE_RUNTIMES` to build compiler-rt may cause errors in unrelated PRs; * avoid any fallout in CI should the above PRs be merged and subsequently reverted for unforeseen regressions. Addresses rdar://100762636
1 parent d72ebe8 commit e0def4e

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

utils/build-script-impl

+9
Original file line numberDiff line numberDiff line change
@@ -1831,6 +1831,15 @@ for host in "${ALL_HOSTS[@]}"; do
18311831

18321832
cmake_options+=(
18331833
-DLLVM_ENABLE_PROJECTS="$(join ";" ${llvm_enable_projects[@]})"
1834+
# In the near future we are aiming to build compiler-rt with
1835+
# LLVM_ENABLE_RUNTIMES
1836+
# Until that happens, we need to unset this variable from
1837+
# LLVM CMakeCache.txt for two reasons
1838+
# * prevent PRs testing this variable to affect other runs landing
1839+
# unrelated features
1840+
# * avoid fallouts should we land such change and then have to revert
1841+
# it to account for unforeseen regressions
1842+
-ULLVM_ENABLE_RUNTIMES
18341843
)
18351844

18361845
# NOTE: This is not a dead option! It is relied upon for certain

0 commit comments

Comments
 (0)