Skip to content

Commit ccdce9f

Browse files
authored
[AutoDiff] Delete wrong FIXMEs (TF-284) from tests (#78663)
In AutoDiff/Sema/differentiable_attr_type_checking.swift, we have a couple of following FIXMEs: ``` // FIXME(TF-284): Fix unexpected diagnostic. ``` However, the diagnostic is expected for the case of public protocol requirements: see description #30629. This PR removed the diagnostic for less-than-public-visible requirements, and the FIXME was initially related to them. It looks like that the FIXMEs present now are a result of copy-paste and have no meaning, and the diagnostic is expected and should be present and does not need to be removed. Fixes #78609
1 parent 6576929 commit ccdce9f

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

test/AutoDiff/Sema/differentiable_attr_type_checking.swift

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -290,15 +290,13 @@ public struct PublicDiffAttrConformance: ProtocolRequirements {
290290
var x: Float
291291
var y: Float
292292

293-
// FIXME(TF-284): Fix unexpected diagnostic.
294293
// expected-note @+2 {{candidate is missing explicit '@differentiable(reverse)' attribute to satisfy requirement}} {{10-10=@differentiable(reverse) }}
295294
// expected-note @+1 {{candidate has non-matching type '(x: Float, y: Float)'}}
296295
public init(x: Float, y: Float) {
297296
self.x = x
298297
self.y = y
299298
}
300299

301-
// FIXME(TF-284): Fix unexpected diagnostic.
302300
// expected-note @+2 {{candidate is missing explicit '@differentiable(reverse)' attribute to satisfy requirement}} {{10-10=@differentiable(reverse) }}
303301
// expected-note @+1 {{candidate has non-matching type '(x: Float, y: Int)'}}
304302
public init(x: Float, y: Int) {

0 commit comments

Comments
 (0)