Skip to content

Commit a65f1a1

Browse files
AnthonyLatsisAnthonyLatsis
committed
Gardening: Migrate test suite to GH issues: Interop
1 parent 678db44 commit a65f1a1

14 files changed

+29
-20
lines changed

Diff for: ‎test/Interop/C/modules/print-qualified-clang-types/print-qualified-clang-types.swift

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
// In addition to checking for the presence of the expected string in the
2525
// `.swiftinterface` file, we also verify that it compiles without error.
2626
//
27-
// This is a regression test for https://bugs.swift.org/browse/SR-13032.
27+
// This is a regression test for https://github.com/apple/swift/issues/55477.
2828

2929
// RUN: %empty-directory(%t)
3030
// RUN: mkdir %t/helper_module %t/main_module

Diff for: ‎test/Interop/Cxx/class/Inputs/nested-records.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ struct HasForwardDeclaredTemplateChild {
6363
};
6464

6565

66-
// TODO: Nested class templates (SR-13853).
66+
// TODO: Nested class templates (https://github.com/apple/swift/issues/56251).
6767

6868
namespace NestedDeclIsAFirstForwardDeclaration {
6969

Diff for: ‎test/Interop/Cxx/class/inline-function-codegen/static-var-init-calls-function-execution.swift

+2-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@
22
//
33
// REQUIRES: executable_test
44

5-
// TODO: See why -validate-tbd-against-ir=none is needed here (SR-14069)
5+
// TODO: See why -validate-tbd-against-ir=none is needed here
6+
// (https://github.com/apple/swift/issues/56458).
67

78
import StaticVarInitCallsFunction
89
import StdlibUnittest

Diff for: ‎test/Interop/Cxx/class/inline-function-codegen/static-var-init-calls-function-irgen.swift

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
// RUN: %target-swift-emit-ir %s -I %S/Inputs -enable-experimental-cxx-interop -validate-tbd-against-ir=none | %FileCheck %s
22

3-
// TODO: See why -validate-tbd-against-ir=none is needed here (SR-14069)
3+
// TODO: See why -validate-tbd-against-ir=none is needed here
4+
// (https://github.com/apple/swift/issues/56458).
45

56
import StaticVarInitCallsFunction
67

Diff for: ‎test/Interop/Cxx/namespace/Inputs/module.modulemap

+2-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@ module Classes {
55

66
module ClassesSecondHeader {
77
// TODO: we shouldn't have to include both of these, and the decls defined in
8-
// these headers should be added to the correct module: SR-14214.
8+
// these headers should be added to the correct module
9+
// (https://github.com/apple/swift/issues/56592).
910
header "classes.h"
1011
header "classes-second-header.h"
1112
requires cplusplus

Diff for: ‎test/Interop/Cxx/operators/member-inline.swift

+3-3
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import StdlibUnittest
99

1010
var OperatorsTestSuite = TestSuite("Operators")
1111

12-
#if !os(Windows) // SR-13129
12+
#if !os(Windows) // https://github.com/apple/swift/issues/55575
1313
OperatorsTestSuite.test("LoadableIntWrapper.minus (inline)") {
1414
var lhs = LoadableIntWrapper(value: 42)
1515
let rhs = LoadableIntWrapper(value: 23)
@@ -69,7 +69,7 @@ OperatorsTestSuite.test("LoadableIntWrapper.successor() (inline)") {
6969
expectEqual(42, wrapper.value)
7070
}
7171

72-
#if !os(Windows) // SR-13129
72+
#if !os(Windows) // https://github.com/apple/swift/issues/55575
7373
OperatorsTestSuite.test("LoadableBoolWrapper.exclaim (inline)") {
7474
var wrapper = LoadableBoolWrapper(value: true)
7575

@@ -242,7 +242,7 @@ OperatorsTestSuite.test("DifferentTypesArrayByVal.subscript (inline)") {
242242
expectEqual(1.5.rounded(.up), resultDouble.rounded(.up))
243243
}
244244

245-
#if !os(Windows) // SR-13129
245+
#if !os(Windows) // https://github.com/apple/swift/issues/55575
246246
OperatorsTestSuite.test("NonTrivialArrayByVal.subscript (inline)") {
247247
var arr = NonTrivialArrayByVal()
248248
let NonTrivialByVal = arr[0];

Diff for: ‎test/Interop/Cxx/operators/member-out-of-line.swift

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import StdlibUnittest
1111

1212
var OperatorsTestSuite = TestSuite("Operators")
1313

14-
#if !os(Windows) // SR-13129
14+
#if !os(Windows) // https://github.com/apple/swift/issues/55575
1515
OperatorsTestSuite.test("LoadableIntWrapper.plus (out-of-line)") {
1616
let lhs = LoadableIntWrapper(value: 42)
1717
let rhs = LoadableIntWrapper(value: 23)

Diff for: ‎test/Interop/Cxx/templates/Inputs/function-templates.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,8 @@ void takesDeclTypePointer(decltype(usedInDeclType<T>()) *) {}
6565

6666
// TODO: Add test for DeducedTemplateSpecializationType once we support class templates.
6767

68-
// TODO(SR-13809): We don't yet support dependent types but we still shouldn't
69-
// crash when importing one.
68+
// TODO: We don't yet support dependent types but we still shouldn't
69+
// crash when importing one (https://github.com/apple/swift/issues/56206).
7070
template <class T> struct Dep { using TT = T; };
7171

7272
template <class T> void useDependentType(typename Dep<T>::TT) {}

Diff for: ‎test/Interop/Cxx/templates/class-template-eager-instatiation-problems.swift

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ TemplatesTestSuite.test("sfinae-example") {
2323
// This will fail since we are currently not instantiating function templates.
2424
// In C++ the first sfinaeGetInt should fail to instantiate, therefore get
2525
// ignored, and only the second sfinaeGetInt is used.
26-
// TODO(SR-12541): Fix this
26+
// TODO: Fix this (https://github.com/apple/swift/issues/54985):
2727
// let magicNumber = MagicNumber()
2828
// var brokenMagicWrapper = BrokenMagicWrapper()
2929
// expectEqual(42, brokenMagicWrapper.sfinaeGetInt(magicNumber, 0))

Diff for: ‎test/Interop/Cxx/templates/class-template-non-type-parameter.swift

+4-2
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,16 @@ TemplatesTestSuite.test("typedeffed-non-type-parameter") {
1212
expectEqual(pair.t, (1, 2))
1313
}
1414

15-
// TODO(SR-13261): This test doesn't work because Swift doesn't support defaulted generic parameters.
15+
// TODO: This test doesn't work because Swift doesn't support defaulted generic
16+
// parameters (https://github.com/apple/swift/issues/55701).
1617
// TemplatesTestSuite.test("defaulted-non-type-parameter") {
1718
// var intWrapper = IntWrapper(value: 5)
1819
// var pair = MagicArray<IntWrapper>(t: (intWrapper))
1920
// expectEqual(pair.t, (intWrapper))
2021
// }
2122

22-
// TODO(SR-13261): This test doesn't work because Swift only expects types as generic arguments.
23+
// TODO: This test doesn't work because Swift only expects types as generic
24+
// arguments (https://github.com/apple/swift/issues/55701).
2325
// TemplatesTestSuite.test("non-type-parameter") {
2426
// var pair = MagicArray<IntWrapper, 5>(
2527
// data: (

Diff for: ‎test/Interop/Cxx/templates/class-template-template-parameter.swift

+2-2
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ TemplatesTestSuite.test("typedeffed-template-template-parameter") {
1414
expectEqual(templatedWrappedMagicInt.getValuePlusTwiceTheArg(10), 62)
1515
}
1616

17-
// TODO(SR-13261): test below doesn't work because Swift needs concrete generic
18-
// arguments for MagicWrapper.
17+
// TODO: Test below doesn't work because Swift needs concrete generic
18+
// arguments for 'MagicWrapper' (https://github.com/apple/swift/issues/55701).
1919
// TemplatesTestSuite.test("template-template-parameter") {
2020
// let myInt = IntWrapper(value: 42)
2121
// var magicInt = MagicWrapper<IntWrapper>(t: myInt)

Diff for: ‎test/Interop/Cxx/templates/class-template-variadic.swift

+4-2
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@
22
//
33
// REQUIRES: executable_test
44
//
5-
// We can't yet call member functions correctly on Windows (SR-13129).
5+
// We can't yet call member functions correctly on Windows
6+
// (https://github.com/apple/swift/issues/55575).
67
// XFAIL: OS=windows-msvc
78
// REQUIRES: fixing-after-30630
89

@@ -25,7 +26,8 @@ TemplatesTestSuite.test("typedeffed-variadic-class-template") {
2526
expectEqual(pairB.getValue(), 20)
2627
}
2728

28-
// TODO(SR-13261): This test doesn't work because Swift sees this as passing in too many generic arguments.
29+
// TODO: This test doesn't work because Swift sees this as passing in too many
30+
// generic arguments (https://github.com/apple/swift/issues/55701).
2931
// TemplatesTestSuite.test("variadic-class-template") {
3032
// let a = IntWrapper(value: 10)
3133
// let b = IntWrapper(value: 20)

Diff for: ‎test/Interop/Cxx/templates/dependent-types.swift

+2-1
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,8 @@ DependentTypesTestSuite.test("Takes const ref and returns dependent type.") {
5858
expectEqual(m.getValue(), 42)
5959
}
6060

61-
// We still have some problems calling methods on Windows: SR-13129 and rdar://88391102
61+
// We still have some problems calling methods on Windows
62+
// (https://github.com/apple/swift/issues/55575 and rdar://88391102).
6263
#if !os(Windows)
6364
DependentTypesTestSuite.test("Function template methods") {
6465
let m = M<Int>(value: 42)

Diff for: ‎test/Interop/Cxx/templates/member-templates-silgen.swift

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
// RUN: %target-swift-emit-sil %s -I %S/Inputs -enable-experimental-cxx-interop | %FileCheck %s
22

3-
// We can't yet call member functions correctly on Windows (SR-13129).
3+
// We can't yet call member functions correctly on Windows
4+
// (https://github.com/apple/swift/issues/55575).
45
// XFAIL: OS=windows-msvc
56

67
import MemberTemplates

0 commit comments

Comments
 (0)