IRGen: Rename internal 'POD' references to 'TriviallyDestroyable'.

Noncopyable types aren't really "POD", but the bit is still useful to track
whether a noncopyable type has a no-op destroy operation, so rename the
existing bit to be more specific within IRGen's implementation.

Don't rename it in the runtime or Builtin names yet, since doing so will
require a naming transition for compatibility.

Author: jckarter

lib/IRGen/FixedTypeInfo.h

@@ -42,7 +42,7 @@ class FixedTypeInfo : public TypeInfo {
 protected:
   FixedTypeInfo(llvm::Type *type, Size size,
                 const SpareBitVector &spareBits,
-                Alignment align, IsPOD_t pod, IsBitwiseTakable_t bt,
+                Alignment align, IsTriviallyDestroyable_t pod, IsBitwiseTakable_t bt,
                 IsFixedSize_t alwaysFixedSize,
                 SpecialTypeInfoKind stik = SpecialTypeInfoKind::Fixed)
       : TypeInfo(type, align, pod, bt, alwaysFixedSize, IsABIAccessible, stik),
@@ -55,7 +55,7 @@ class FixedTypeInfo : public TypeInfo {
 
   FixedTypeInfo(llvm::Type *type, Size size,
                 SpareBitVector &&spareBits,
-                Alignment align, IsPOD_t pod, IsBitwiseTakable_t bt,
+                Alignment align, IsTriviallyDestroyable_t pod, IsBitwiseTakable_t bt,
                 IsFixedSize_t alwaysFixedSize,
                 SpecialTypeInfoKind stik = SpecialTypeInfoKind::Fixed)
       : TypeInfo(type, align, pod, bt, alwaysFixedSize, IsABIAccessible, stik),
@@ -90,7 +90,7 @@ class FixedTypeInfo : public TypeInfo {
   llvm::Value *getSize(IRGenFunction &IGF, SILType T) const override;
   llvm::Value *getAlignmentMask(IRGenFunction &IGF, SILType T) const override;
   llvm::Value *getStride(IRGenFunction &IGF, SILType T) const override;
-  llvm::Value *getIsPOD(IRGenFunction &IGF, SILType T) const override;
+  llvm::Value *getIsTriviallyDestroyable(IRGenFunction &IGF, SILType T) const override;
   llvm::Value *getIsBitwiseTakable(IRGenFunction &IGF, SILType T) const override;
   llvm::Value *isDynamicallyPackedInline(IRGenFunction &IGF,
                                          SILType T) const override;

lib/IRGen/GenBuiltin.cpp

@@ -173,7 +173,7 @@ void irgen::emitBuiltinCall(IRGenFunction &IGF, const BuiltinInfo &Builtin,
     (void)args.claimAll();
     auto valueTy = getLoweredTypeAndTypeInfo(IGF.IGM,
                                              substitutions.getReplacementTypes()[0]);
-    out.add(valueTy.second.getIsPOD(IGF, valueTy.first));
+    out.add(valueTy.second.getIsTriviallyDestroyable(IGF, valueTy.first));
     return;
   }
 

lib/IRGen/GenConcurrency.cpp

@@ -43,7 +43,7 @@ class ExecutorTypeInfo :
   ExecutorTypeInfo(llvm::StructType *storageType,
                    Size size, Alignment align, SpareBitVector &&spareBits)
       : TrivialScalarPairTypeInfo(storageType, size, std::move(spareBits),
-                                  align, IsPOD, IsFixedSize) {}
+                                  align, IsTriviallyDestroyable, IsFixedSize) {}
 
   static Size getFirstElementSize(IRGenModule &IGM) {
     return IGM.getPointerSize();
@@ -60,7 +60,7 @@ class ExecutorTypeInfo :
       return IGM.typeLayoutCache.getOrCreateTypeInfoBasedEntry(*this, T);
     }
     return IGM.typeLayoutCache.getOrCreateScalarEntry(*this, T,
-                                                      ScalarKind::POD);
+                                            ScalarKind::TriviallyDestroyable);
   }
 
   static Size getSecondElementOffset(IRGenModule &IGM) {

lib/IRGen/GenDiffFunc.cpp

@@ -94,9 +94,9 @@ class DifferentiableFuncTypeInfo final
   DifferentiableFuncTypeInfo(ArrayRef<DifferentiableFuncFieldInfo> fields,
                              unsigned explosionSize, llvm::Type *ty, Size size,
                              SpareBitVector &&spareBits, Alignment align,
-                             IsPOD_t isPOD, IsFixedSize_t alwaysFixedSize)
+                             IsTriviallyDestroyable_t isTriviallyDestroyable, IsFixedSize_t alwaysFixedSize)
       : super(fields, explosionSize, ty, size, std::move(spareBits), align,
-              isPOD, alwaysFixedSize) {}
+              isTriviallyDestroyable, alwaysFixedSize) {}
 
   Address projectFieldAddress(IRGenFunction &IGF, Address addr, SILType T,
                               const DifferentiableFuncFieldInfo &field) const {
@@ -179,7 +179,7 @@ class DifferentiableFuncTypeBuilder
                  StructLayout &&layout, unsigned explosionSize) {
     return DifferentiableFuncTypeInfo::create(
         fields, explosionSize, layout.getType(), layout.getSize(),
-        std::move(layout.getSpareBits()), layout.getAlignment(), layout.isPOD(),
+        std::move(layout.getSpareBits()), layout.getAlignment(), layout.isTriviallyDestroyable(),
         layout.isAlwaysFixedSize());
   }
 
@@ -267,10 +267,10 @@ class LinearFuncTypeInfo final
 public:
   LinearFuncTypeInfo(ArrayRef<LinearFuncFieldInfo> fields,
                      unsigned explosionSize, llvm::Type *ty, Size size,
-                     SpareBitVector &&spareBits, Alignment align, IsPOD_t isPOD,
+                     SpareBitVector &&spareBits, Alignment align, IsTriviallyDestroyable_t isTriviallyDestroyable,
                      IsFixedSize_t alwaysFixedSize)
       : super(fields, explosionSize, ty, size, std::move(spareBits), align,
-              isPOD, alwaysFixedSize) {}
+              isTriviallyDestroyable, alwaysFixedSize) {}
 
   Address projectFieldAddress(IRGenFunction &IGF, Address addr, SILType T,
                               const LinearFuncFieldInfo &field) const {
@@ -347,7 +347,7 @@ class LinearFuncTypeBuilder
                                      unsigned explosionSize) {
     return LinearFuncTypeInfo::create(
         fields, explosionSize, layout.getType(), layout.getSize(),
-        std::move(layout.getSpareBits()), layout.getAlignment(), layout.isPOD(),
+        std::move(layout.getSpareBits()), layout.getAlignment(), layout.isTriviallyDestroyable(),
         layout.isAlwaysFixedSize());
   }