Skip to content

Commit 88c5fc1

Browse files
committed
[Benchmark] Disable Cxx{VectorSum,SetToCollection}.
The two benchmarks don't currently build in some configurations. Also disabled building ReadAccessor whose running had previously been disabled because it doesn't build anymore. rdar://128520766
1 parent 2175abd commit 88c5fc1

File tree

2 files changed

+14
-7
lines changed

2 files changed

+14
-7
lines changed

benchmark/CMakeLists.txt

+6-3
Original file line numberDiff line numberDiff line change
@@ -209,10 +209,13 @@ set(SWIFT_BENCH_MODULES
209209
single-source/WordCount
210210
single-source/XorLoop
211211
cxx-source/CreateObjects
212-
cxx-source/CxxSetToCollection
212+
# Disabled for rdar://128520766
213+
# cxx-source/CxxSetToCollection
213214
cxx-source/CxxStringConversion
214-
cxx-source/CxxVectorSum
215-
cxx-source/ReadAccessor
215+
# Disabled for rdar://128520766
216+
# cxx-source/CxxVectorSum
217+
# TODO: rdar://92120528
218+
# cxx-source/ReadAccessor
216219
)
217220

218221
set(SWIFT_MULTISOURCE_SWIFT_BENCHES

benchmark/utils/main.swift

+8-4
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,11 @@ import CodableTest
5555
import Combos
5656
import CountAlgo
5757
import CreateObjects
58-
import CxxSetToCollection
58+
// rdar://128520766
59+
// import CxxSetToCollection
5960
import CxxStringConversion
60-
import CxxVectorSum
61+
// rdar://128520766
62+
// import CxxVectorSum
6163
import DataBenchmarks
6264
import DeadArray
6365
import DevirtualizeProtocolComposition
@@ -251,9 +253,11 @@ register(Combos.benchmarks)
251253
register(CountAlgo.benchmarks)
252254
register(ClassArrayGetter.benchmarks)
253255
register(CreateObjects.benchmarks)
254-
register(CxxSetToCollection.benchmarks)
256+
// rdar://128520766
257+
// register(CxxSetToCollection.benchmarks)
255258
register(CxxStringConversion.benchmarks)
256-
register(CxxVectorSum.benchmarks)
259+
// rdar://128520766
260+
// register(CxxVectorSum.benchmarks)
257261
register(DataBenchmarks.benchmarks)
258262
register(DeadArray.benchmarks)
259263
register(DevirtualizeProtocolComposition.benchmarks)

0 commit comments

Comments
 (0)