More places we expect the signature to be used

Author: aschwaighofer

lib/IRGen/Callee.h

@@ -366,8 +366,11 @@ namespace irgen {
 
     static FunctionPointer createSigned(Kind kind, llvm::Value *value,
                                         PointerAuthInfo authInfo,
-                                        const Signature &signature) {
-      return FunctionPointer(kind, value, authInfo, signature);
+                                        const Signature &signature,
+                                        bool useSignature = false) {
+      auto res = FunctionPointer(kind, value, authInfo, signature);
+      res.useSignature = useSignature;
+      return res;
     }
     static FunctionPointer createSignedClosure(Kind kind, llvm::Value *value,
                                         PointerAuthInfo authInfo,
@@ -379,8 +382,11 @@ namespace irgen {
 
 
     static FunctionPointer createUnsigned(Kind kind, llvm::Value *value,
-                                          const Signature &signature) {
-      return FunctionPointer(kind, value, signature);
+                                          const Signature &signature,
+                                          bool useSignature = false) {
+      auto res = FunctionPointer(kind, value, signature);
+      res.useSignature = useSignature;
+      return res;
     }
 
     static FunctionPointer forDirect(IRGenModule &IGM, llvm::Constant *value,

lib/IRGen/GenClass.cpp

@@ -2798,7 +2798,7 @@ FunctionPointer irgen::emitVirtualMethodValue(IRGenFunction &IGF,
     auto authInfo =
       PointerAuthInfo::emit(IGF, schema, slot.getAddress(), method);
     return FunctionPointer::createSigned(methodType, fnPtr, authInfo,
-                                         signature);
+                                         signature, true);
   }
   case ClassMetadataLayout::MethodInfo::Kind::DirectImpl: {
     auto fnPtr = llvm::ConstantExpr::getBitCast(methodInfo.getDirectImpl(),
@@ -2811,7 +2811,7 @@ FunctionPointer irgen::emitVirtualMethodValue(IRGenFunction &IGF,
           IGF.IGM.getAddrOfSILFunction(silFn, NotForDefinition));
     }
     return FunctionPointer::forDirect(methodType, fnPtr, secondaryValue,
-                                      signature);
+                                      signature, true);
   }
   }
   llvm_unreachable("covered switch");

lib/IRGen/IRGenSIL.cpp

@@ -2605,7 +2605,7 @@ void IRGenSILFunction::visitDifferentiabilityWitnessFunctionInst(
       Builder.CreateBitCast(diffWitness, signature.getType()->getPointerTo());
 
   setLoweredFunctionPointer(
-      i, FunctionPointer::createUnsigned(fnType, diffWitness, signature));
+      i, FunctionPointer::createUnsigned(fnType, diffWitness, signature, true));
 }
 
 FunctionPointer::Kind irgen::classifyFunctionPointerKind(SILFunction *fn) {
@@ -6860,7 +6860,7 @@ void IRGenSILFunction::visitWitnessMethodInst(swift::WitnessMethodInst *i) {
     }
 
     auto sig = IGM.getSignature(fnType);
-    auto fn = FunctionPointer::forDirect(fnType, fnPtr, secondaryValue, sig);
+    auto fn = FunctionPointer::forDirect(fnType, fnPtr, secondaryValue, sig, true);
 
     setLoweredFunctionPointer(i, fn);
     return;
@@ -7093,7 +7093,7 @@ void IRGenSILFunction::visitSuperMethodInst(swift::SuperMethodInst *i) {
     auto authInfo =
       PointerAuthInfo::emit(*this, schema, /*storageAddress=*/nullptr, method);
 
-    auto fn = FunctionPointer::createSigned(methodType, fnPtr, authInfo, sig);
+    auto fn = FunctionPointer::createSigned(methodType, fnPtr, authInfo, sig, true);
 
     setLoweredFunctionPointer(i, fn);
     return;
@@ -7156,7 +7156,7 @@ void IRGenSILFunction::visitClassMethodInst(swift::ClassMethodInst *i) {
     }
 
     auto sig = IGM.getSignature(methodType);
-    auto fn = FunctionPointer::createUnsigned(methodType, fnPtr, sig);
+    auto fn = FunctionPointer::createUnsigned(methodType, fnPtr, sig, true);
 
     setLoweredFunctionPointer(i, fn);
     return;