Skip to content

Commit 786a0ba

Browse files
committed
[Doc] Drop support for test and merge, and users should use auto-merge feature on GitHub
1 parent 7df19b8 commit 786a0ba

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

docs/ContinuousIntegration.md

+2-6
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,6 @@ Platform | Comment | Check Status
5151
------------ | ------- | ------------
5252
All supported platforms | @swift-ci Please smoke test | Swift Test Linux Platform (smoke test)<br>Swift Test macOS Platform (smoke test)
5353
All supported platforms | @swift-ci Please clean smoke test | Swift Test Linux Platform (smoke test)<br>Swift Test macOS Platform (smoke test)
54-
All supported platforms | @swift-ci Please smoke test and merge | Swift Test Linux Platform (smoke test)<br>Swift Test macOS Platform (smoke test)
55-
All supported platforms | @swift-ci Please clean smoke test and merge | Swift Test Linux Platform (smoke test)<br>Swift Test macOS Platform (smoke test)
5654
macOS platform | @swift-ci Please smoke test macOS platform | Swift Test macOS Platform (smoke test)
5755
macOS platform | @swift-ci Please clean smoke test macOS platform | Swift Test macOS Platform (smoke test)
5856
Linux platform | @swift-ci Please smoke test Linux platform | Swift Test Linux Platform (smoke test)
@@ -86,8 +84,6 @@ Platform | Comment | Check Status
8684
------------ | ------- | ------------
8785
All supported platforms | @swift-ci Please test | Swift Test Linux Platform (smoke test)<br>Swift Test macOS Platform (smoke test)<br>Swift Test Linux Platform<br>Swift Test macOS Platform<br>
8886
All supported platforms | @swift-ci Please clean test | Swift Test Linux Platform (smoke test)<br>Swift Test macOS Platform (smoke test)<br>Swift Test Linux Platform<br>Swift Test macOS Platform<br>
89-
All supported platforms | @swift-ci Please test and merge | Swift Test Linux Platform (smoke test)<br>Swift Test macOS Platform (smoke test)<br> Swift Test Linux Platform <br>Swift Test macOS Platform
90-
All supported platforms | @swift-ci Please clean test and merge | Swift Test Linux Platform (smoke test)<br>Swift Test macOS Platform (smoke test)<br> Swift Test Linux Platform <br>Swift Test macOS Platform
9187
macOS platform | @swift-ci Please test macOS platform | Swift Test macOS Platform (smoke test)<br>Swift Test macOS Platform
9288
macOS platform | @swift-ci Please clean test macOS platform | Swift Test macOS Platform (smoke test)<br>Swift Test macOS Platform
9389
macOS platform | @swift-ci Please benchmark | Swift Benchmark on macOS Platform (many runs - rigorous)
@@ -273,7 +269,7 @@ apple/swift-lldb#48
273269

274270
1. Create a separate PR for each repository that needs to be changed. Each should reference the main Swift PR and create a reference to all of the others from the main PR.
275271

276-
2. Gate all commits on @swift-ci smoke test and merge. As stated above, it is important that *all* checkins perform PR testing since if breakage enters the tree PR testing becomes less effective. If you have done local testing (using build-toolchain) and have made appropriate changes to the other repositories then perform a smoke test and merge should be sufficient for correctness. This is not meant to check for correctness in your commits, but rather to be sure that no one landed changes in other repositories or in swift that cause your PR to no longer be correct. If you were unable to make workarounds to the other repositories, this smoke test will break *after* Swift has built. Check the log to make sure that it is the expected failure for that platform/repository that coincides with the failure your PR is supposed to fix.
272+
2. Gate all commits on @swift-ci smoke test. As stated above, it is important that *all* checkins perform PR testing since if breakage enters the tree PR testing becomes less effective. If you have done local testing (using build-toolchain) and have made appropriate changes to the other repositories then perform a smoke test should be sufficient for correctness. This is not meant to check for correctness in your commits, but rather to be sure that no one landed changes in other repositories or in swift that cause your PR to no longer be correct. If you were unable to make workarounds to the other repositories, this smoke test will break *after* Swift has built. Check the log to make sure that it is the expected failure for that platform/repository that coincides with the failure your PR is supposed to fix.
277273

278274
3. Merge all of the pull requests simultaneously.
279275

@@ -295,7 +291,7 @@ FIXME: FILL ME IN!
295291

296292
1. A full build break can prevent other developers from testing their work.
297293
2. A test break can make it difficult for developers to know whether or not their specific commit has broken a test, requiring them to perform an initial clean build, wasting time.
298-
3. @swift-ci pull request testing becomes less effective since one can not perform a test and merge and one must reason about the source of a given failure.
294+
3. @swift-ci pull request testing becomes less effective since one can not perform a test and one must reason about the source of a given failure.
299295

300296
<a name="footnote-2">[2]</a> This is due to unrelated issues relating to running lldb tests on macOS.
301297

0 commit comments

Comments
 (0)