[embedded] Use @_extern(c) instead of @_silgen_name for putchar in tests

kateinoigakukun · kateinoigakukun · commit 65723193a929 · 2024-04-11T10:37:25.000Z
Using inconsistent attributes between stdlib and tests causes
compilation errors. There are still several misuses of @_silgen_name in
tests, but leaving them as is for now to incrementally fix them.
diff --git a/test/embedded/array-to-pointer.swift b/test/embedded/array-to-pointer.swift
@@ -9,7 +9,7 @@
 // REQUIRES: optimized_stdlib
 // REQUIRES: OS=macosx || OS=linux-gnu
 
-@_silgen_name("putchar")
+@_extern(c, "putchar")
 @discardableResult
 func putchar(_: CInt) -> CInt
 
diff --git a/test/embedded/arrays.swift b/test/embedded/arrays.swift
@@ -9,7 +9,7 @@
 // REQUIRES: optimized_stdlib
 // REQUIRES: OS=macosx || OS=linux-gnu
 
-@_silgen_name("putchar")
+@_extern(c, "putchar")
 @discardableResult
 func putchar(_: CInt) -> CInt
 
diff --git a/test/embedded/collection.swift b/test/embedded/collection.swift
@@ -9,7 +9,7 @@
 // REQUIRES: optimized_stdlib
 // REQUIRES: OS=macosx || OS=linux-gnu
 
-@_silgen_name("putchar")
+@_extern(c, "putchar")
 @discardableResult
 func putchar(_: CInt) -> CInt
 
diff --git a/test/embedded/custom-print.swift b/test/embedded/custom-print.swift
@@ -7,7 +7,7 @@
 // REQUIRES: executable_test
 // REQUIRES: OS=macosx || OS=linux-gnu
 
-@_silgen_name("putchar")
+@_extern(c, "putchar")
 @discardableResult
 func putchar(_: CInt) -> CInt
 
diff --git a/test/embedded/dependencies-no-allocations.swift b/test/embedded/dependencies-no-allocations.swift
@@ -26,7 +26,7 @@
 // REQUIRES: OS=macosx || OS=linux-gnu
 // UNSUPPORTED: OS=linux-gnu && CPU=aarch64
 
-@_silgen_name("putchar")
+@_extern(c, "putchar")
 @discardableResult
 func putchar(_: CInt) -> CInt
 
diff --git a/test/embedded/dependencies-random.swift b/test/embedded/dependencies-random.swift
@@ -32,7 +32,7 @@
 
 // REQUIRES: rdar121923818
 
-@_silgen_name("putchar")
+@_extern(c, "putchar")
 @discardableResult
 func putchar(_: CInt) -> CInt
 
diff --git a/test/embedded/dependencies.swift b/test/embedded/dependencies.swift
@@ -28,7 +28,7 @@
 // REQUIRES: OS=macosx || OS=linux-gnu
 // UNSUPPORTED: OS=linux-gnu && CPU=aarch64
 
-@_silgen_name("putchar")
+@_extern(c, "putchar")
 @discardableResult
 func putchar(_: CInt) -> CInt
 
diff --git a/test/embedded/deserialize-vtables.swift b/test/embedded/deserialize-vtables.swift
@@ -21,7 +21,7 @@ extension StaticString {
     }
 }
 
-@_silgen_name("putchar")
+@_extern(c, "putchar")
 @discardableResult
 func putchar(_: CInt) -> CInt
 
diff --git a/test/embedded/lto.swift b/test/embedded/lto.swift
@@ -12,7 +12,7 @@
 // loaded too late").
 // REQUIRES: no_asan
 
-@_silgen_name("putchar")
+@_extern(c, "putchar")
 @discardableResult
 func putchar(_: CInt) -> CInt
 
diff --git a/test/embedded/modules-globals-exec.swift b/test/embedded/modules-globals-exec.swift
@@ -24,7 +24,7 @@ public func foo() {
 
 import MyModule
 
-@_silgen_name("putchar")
+@_extern(c, "putchar")
 @discardableResult
 func putchar(_: CInt) -> CInt
 
diff --git a/test/embedded/modules-print-exec.swift b/test/embedded/modules-print-exec.swift
@@ -13,7 +13,7 @@
 
 // BEGIN MyModule.swift
 
-@_silgen_name("putchar")
+@_extern(c, "putchar")
 @discardableResult
 func putchar(_: CInt) -> CInt
 
diff --git a/test/embedded/runtime.swift b/test/embedded/runtime.swift
@@ -7,7 +7,7 @@
 // REQUIRES: optimized_stdlib
 // REQUIRES: OS=macosx || OS=linux-gnu
 
-@_silgen_name("putchar")
+@_extern(c, "putchar")
 @discardableResult
 func putchar(_: CInt) -> CInt
 
diff --git a/test/embedded/volatile-exec.swift b/test/embedded/volatile-exec.swift
@@ -7,7 +7,7 @@
 
 import _Volatile
 
-@_silgen_name("putchar")
+@_extern(c, "putchar")
 @discardableResult
 func putchar(_: CInt) -> CInt
 
diff --git a/validation-test/stdlib/MicroStdlib/Inputs/Swift.swift b/validation-test/stdlib/MicroStdlib/Inputs/Swift.swift
@@ -84,7 +84,7 @@ public struct UnsafeMutablePointer<T> {
 public typealias CInt = Int32
 public typealias CChar = Int8
 
-@_silgen_name("putchar")
+@_extern(c, "putchar")
 public func putchar(_: CChar)
 
 public func printHello() {

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ extension StaticString {`
`21`	`21`	`}`
`22`	`22`	`}`
`23`	`23`
`24`		`-@_silgen_name("putchar")`
	`24`	`+@_extern(c, "putchar")`
`25`	`25`	`@discardableResult`
`26`	`26`	`func putchar(_: CInt) -> CInt`
`27`	`27`