Skip to content

Commit 450391f

Browse files
committed
[Serialization] Use the new group mechanism and update tests accordingly.
1 parent 239c803 commit 450391f

File tree

3 files changed

+24
-23
lines changed

3 files changed

+24
-23
lines changed

lib/Serialization/Serialization.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -3614,7 +3614,7 @@ class DeclGroupNameContext {
36143614

36153615
public:
36163616
DeclGroupNameContext(bool Enable) :
3617-
pNameCollector(new GroupNameCollectorFromFileName(Enable)) {}
3617+
pNameCollector(new GroupNameCollectorFromJson(Enable)) {}
36183618
uint32_t getGroupSequence(const ValueDecl *VD) {
36193619
return Map.insert(std::make_pair(pNameCollector->getGroupName(VD),
36203620
Map.size())).first->second;

test/SourceKit/InterfaceGen/gen_stdlib.swift

+18-17
Original file line numberDiff line numberDiff line change
@@ -34,28 +34,29 @@ var x: Int
3434
// CHECK1-NEXT: s:Si
3535
// CHECK1-NEXT: Int.Type
3636
// CHECK1-NEXT: Swift{{$}}
37-
// CHECK1-NEXT: <Group>FixedPoint</Group>
37+
// CHECK1-NEXT: <Group>Misc</Group>
3838
// CHECK1-NEXT: /<interface-gen>{{$}}
3939
// CHECK1-NEXT: SYSTEM
4040
// CHECK1-NEXT: <Declaration>struct Int : <Type usr="s:Ps17SignedIntegerType">SignedIntegerType</Type>{{.*}}{{.*}}<Type usr="s:Ps10Comparable">Comparable</Type>{{.*}}<Type usr="s:Ps9Equatable">Equatable</Type>{{.*}}</Declaration>
4141

4242
// RUN: %sourcekitd-test -req=module-groups -module Swift | FileCheck -check-prefix=GROUP1 %s
4343
// GROUP1: <GROUPS>
44-
// GROUP1: Algorithm
45-
// GROUP1: Assert
46-
// GROUP1: Character
47-
// GROUP1: Collection
48-
// GROUP1: FlatMap
49-
// GROUP1: OutputStream
50-
// GROUP1: String
51-
// GROUP1: Zip
44+
// GROUP1-DAG: Algorithm
45+
// GROUP1-DAG: Assert
46+
// GROUP1-DAG: String
47+
// GROUP1-DAG: Collection
48+
// GROUP1-DAG: Bool
49+
// GROUP1-DAG: Math
50+
// GROUP1-DAG: Misc
5251
// GROUP1: <\GROUPS>
5352

54-
// RUN: %sourcekitd-test -req=interface-gen -module Swift -group-name Zip > %t.zip.response
55-
// RUN: FileCheck -check-prefix=CHECK-ZIP -input-file %t.zip.response %s
56-
// CHECK-ZIP: public func zip<Sequence1 : SequenceType, Sequence2 : SequenceType>(sequence1: Sequence1, _ sequence2: Sequence2) -> Zip2Sequence<Sequence1, Sequence2>
57-
// CHECK-ZIP: public struct Zip2Generator<Generator1 : GeneratorType, Generator2 : GeneratorType> : GeneratorType {
58-
// CHECK-ZIP: public struct Zip2Sequence<Sequence1 : SequenceType, Sequence2 : SequenceType> : SequenceType {
59-
// Zip group cannot include Int
60-
// CHECK-ZIP-NOT: struct Int : SignedIntegerType, Comparable, Equatable {
61-
// CHECK-ZIP-NOT: extension String.UTF16View.Index {
53+
// RUN: %sourcekitd-test -req=interface-gen -module Swift -group-name Bool > %t.Bool.response
54+
// RUN: FileCheck -check-prefix=CHECK-BOOL -input-file %t.Bool.response %s
55+
// CHECK-BOOL-DAG: extension Bool : BooleanType {
56+
// CHECK-BOOL-DAG: extension Bool : BooleanLiteralConvertible {
57+
58+
// These are not in the bool group:
59+
// CHECK-BOOL-NOT: public struct Zip2Generator<Generator1 : GeneratorType, Generator2 : GeneratorType> : GeneratorType {
60+
// CHECK-BOOL-NOT: public struct Zip2Sequence<Sequence1 : SequenceType, Sequence2 : SequenceType> : SequenceType {
61+
// CHECK-BOOL-NOT: struct Int : SignedIntegerType, Comparable, Equatable {
62+
// CHECK-BOOL-NOT: extension String.UTF16View.Index {

test/SourceKit/SourceDocInfo/cursor_stdlib.swift

+5-5
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,10 @@ func foo2(var a : [S1]) {
2727

2828
// RUN: %sourcekitd-test -req=cursor -pos=5:13 %s -- %s %mcp_opt %clang-importer-sdk | FileCheck -check-prefix=CHECK-GENERATOR %s
2929
// CHECK-GENERATOR-NOT: _AnyGeneratorBase
30-
// CHECK-GENERATOR: <Group>ExistentialCollection</Group>
30+
// CHECK-GENERATOR: <Group>Collection</Group>
3131

3232
// RUN: %sourcekitd-test -req=cursor -pos=8:10 %s -- %s %mcp_opt %clang-importer-sdk | FileCheck -check-prefix=CHECK-REPLACEMENT1 %s
33-
// CHECK-REPLACEMENT1: <Group>CollectionAlgorithms</Group>
33+
// CHECK-REPLACEMENT1: <Group>Collection</Group>
3434
// CHECK-REPLACEMENT1: <Declaration>@warn_unused_result(mutable_variant=&quot;sortInPlace&quot;) func sort() -&gt; [<Type usr="s:Si">Int</Type>]</Declaration>
3535
// CHECK-REPLACEMENT1: RELATED BEGIN
3636
// CHECK-REPLACEMENT1: sort(@noescape _: @noescape (Int, Int) -&gt; Bool) -&gt; [Int]</RelatedName>
@@ -39,16 +39,16 @@ func foo2(var a : [S1]) {
3939
// CHECK-REPLACEMENT1: RELATED END
4040

4141
// RUN: %sourcekitd-test -req=cursor -pos=9:8 %s -- %s %mcp_opt %clang-importer-sdk | FileCheck -check-prefix=CHECK-REPLACEMENT2 %s
42-
// CHECK-REPLACEMENT2: <Group>Arrays</Group>
42+
// CHECK-REPLACEMENT2: <Group>Array</Group>
4343
// CHECK-REPLACEMENT2: <Declaration>mutating func append(newElement: <Type usr="s:Si">Int</Type>)</Declaration>
4444

4545
// RUN: %sourcekitd-test -req=cursor -pos=15:10 %s -- %s %mcp_opt %clang-importer-sdk | FileCheck -check-prefix=CHECK-REPLACEMENT3 %s
46-
// CHECK-REPLACEMENT3: <Group>CollectionAlgorithms</Group>
46+
// CHECK-REPLACEMENT3: <Group>Collection</Group>
4747
// CHECK-REPLACEMENT3: func sort(@noescape isOrderedBefore: @noescape (<Type usr="s:V13cursor_stdlib2S1">S1</Type>
4848
// CHECK-REPLACEMENT3: sort() -&gt; [S1]</RelatedName>
4949
// CHECK-REPLACEMENT3: sort() -&gt; [S1]</RelatedName>
5050
// CHECK-REPLACEMENT3: sort(@noescape _: @noescape (S1, S1) -&gt; Bool) -&gt; [S1]</RelatedName>
5151

5252
// RUN: %sourcekitd-test -req=cursor -pos=18:8 %s -- %s %mcp_opt %clang-importer-sdk | FileCheck -check-prefix=CHECK-REPLACEMENT4 %s
53-
// CHECK-REPLACEMENT4: <Group>Arrays</Group>
53+
// CHECK-REPLACEMENT4: <Group>Array</Group>
5454
// CHECK-REPLACEMENT4: <Declaration>mutating func append(newElement: <Type usr="s:V13cursor_stdlib2S1">S1</Type>)</Declaration>

0 commit comments

Comments
 (0)