Skip to content

Commit 3f820c3

Browse files
author
David Ungar
committed
Some review tweaks.
1 parent 173bc09 commit 3f820c3

8 files changed

+36
-70
lines changed

Diff for: include/swift/AST/ASTScope.h

+16-17
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
//===--- ASTScopeImpl.h - Swift AST Object-Oriented Scope -----------*- C++
2-
//-*-===//
1+
//===--- ASTScopeImpl.h - Swift AST Object-Oriented Scope --------*- C++-*-===//
32
//
43
// This source file is part of the Swift.org open source project
54
//
@@ -10,21 +9,21 @@
109
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
1110
//
1211
//===----------------------------------------------------------------------===//
13-
//
14-
// This file defines the ASTScopeImpl class ontology, which
15-
// describes the scopes that exist within a Swift AST.
16-
//
17-
// Each scope has four basic functions: printing for debugging, creation of
18-
// itself and its children, obtaining its SourceRange (for lookup), and looking
19-
// up names accessible from that scope.
20-
//
21-
// Invarients:
22-
// a child's source range is a subset (proper or improper) of its parent's,
23-
// children are ordered by source range, and do not overlap,
24-
// all the names visible within a parent are visible within the child, unless
25-
// the nesting is illegal. For instance, a protocol nested inside of a class
26-
// does not get to see the symbols in the class or its ancestors.
27-
//
12+
///
13+
/// This file defines the ASTScopeImpl class ontology, which
14+
/// describes the scopes that exist within a Swift AST.
15+
///
16+
/// Each scope has four basic functions: printing for debugging, creation of
17+
/// itself and its children, obtaining its SourceRange (for lookup), and looking
18+
/// up names accessible from that scope.
19+
///
20+
/// Invarients:
21+
/// a child's source range is a subset (proper or improper) of its parent's,
22+
/// children are ordered by source range, and do not overlap,
23+
/// all the names visible within a parent are visible within the child, unless
24+
/// the nesting is illegal. For instance, a protocol nested inside of a class
25+
/// does not get to see the symbols in the class or its ancestors.
26+
///
2827
//===----------------------------------------------------------------------===//
2928
#ifndef SWIFT_AST_AST_OO_SCOPE_H
3029
#define SWIFT_AST_AST_OO_SCOPE_H

Diff for: include/swift/AST/ASTScopeNodes.def

-32
This file was deleted.

Diff for: lib/AST/ASTScope.cpp

+4-5
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
//===--- ASTScopeImpl.cpp - Swift Object-Oriented AST Scope
2-
//-------------------===//
1+
//===--- ASTScopeImpl.cpp - Swift Object-Oriented AST Scope ---------------===//
32
//
43
// This source file is part of the Swift.org open source project
54
//
@@ -10,9 +9,9 @@
109
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
1110
//
1211
//===----------------------------------------------------------------------===//
13-
//
14-
// This file implements the common functions of the ASTScopeImpl ontology.
15-
//
12+
///
13+
/// This file implements the common functions of the ASTScopeImpl ontology.
14+
///
1615
//===----------------------------------------------------------------------===//
1716
#include "swift/AST/ASTScope.h"
1817

Diff for: lib/AST/ASTScopeCreation.cpp

+3-3
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@
99
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
1010
//
1111
//===----------------------------------------------------------------------===//
12-
//
13-
// This file implements the creation methods of the ASTScopeImpl ontology.
14-
//
12+
///
13+
/// This file implements the creation methods of the ASTScopeImpl ontology.
14+
///
1515
//===----------------------------------------------------------------------===//
1616
#include "swift/AST/ASTScope.h"
1717

Diff for: lib/AST/ASTScopeLookup.cpp

+3-3
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@
99
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
1010
//
1111
//===----------------------------------------------------------------------===//
12-
//
13-
// This file implements the lookup functionality of the ASTScopeImpl ontology.
14-
//
12+
///
13+
/// This file implements the lookup functionality of the ASTScopeImpl ontology.
14+
///
1515
//===----------------------------------------------------------------------===//
1616
#include "swift/AST/ASTScope.h"
1717

Diff for: lib/AST/ASTScopePrinting.cpp

+3-3
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@
99
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
1010
//
1111
//===----------------------------------------------------------------------===//
12-
//
13-
// This file implements the printing functions of the ASTScopeImpl ontology.
14-
//
12+
///
13+
/// This file implements the printing functions of the ASTScopeImpl ontology.
14+
///
1515
//===----------------------------------------------------------------------===//
1616
#include "swift/AST/ASTScope.h"
1717

Diff for: lib/AST/ASTScopeSourceRange.cpp

+3-3
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@
99
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
1010
//
1111
//===----------------------------------------------------------------------===//
12-
//
13-
// This file implements the source range queries for the ASTScopeImpl ontology.
14-
//
12+
///
13+
/// This file implements the source range queries for the ASTScopeImpl ontology.
14+
///
1515
//===----------------------------------------------------------------------===//
1616
#include "swift/AST/ASTScope.h"
1717

Diff for: lib/AST/UnqualifiedLookup.cpp

+4-4
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,10 @@
99
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
1010
//
1111
//===----------------------------------------------------------------------===//
12-
//
13-
// This file implements the construction of an UnqualifiedLookup, which entails
14-
// performing the lookup.
15-
//
12+
///
13+
/// This file implements the construction of an UnqualifiedLookup, which entails
14+
/// performing the lookup.
15+
///
1616
//===----------------------------------------------------------------------===//
1717

1818
#include "swift/AST/ASTContext.h"

0 commit comments

Comments
 (0)