[stdlib] YAIAPR (#18956)

* Scrap Comparable conformance for _SwiftNSOperatingSystemVersion

* Lazy performance needs specialization

* Uninline dump/stdout

* Bool consistency

* fixup CollectionOld

* Uninline printing functions

Author: airspeedswift

stdlib/public/core/Availability.swift

@@ -29,14 +29,11 @@ public func _stdlib_isOSVersionAtLeast(
   // that this function was called by a compiler optimization pass. If it is
   // replaced that pass needs to be updated.
   let runningVersion = _swift_stdlib_operatingSystemVersion()
-  let queryVersion = _SwiftNSOperatingSystemVersion(
-    majorVersion: Int(major),
-    minorVersion: Int(minor),
-    patchVersion: Int(patch)
-  )
-
-  let result = runningVersion >= queryVersion
 
+  let result =
+    (runningVersion.majorVersion,runningVersion.minorVersion,runningVersion.patchVersion)
+    >= (Int(major),Int(minor),Int(patch))
+
   return result._value
 #else
   // FIXME: As yet, there is no obvious versioning standard for platforms other
@@ -45,49 +42,3 @@ public func _stdlib_isOSVersionAtLeast(
   return false._value
 #endif
 }
-
-extension _SwiftNSOperatingSystemVersion : Comparable {
-
-  @inlinable // FIXME(sil-serialize-all)
-  public static func == (
-    lhs: _SwiftNSOperatingSystemVersion,
-    rhs: _SwiftNSOperatingSystemVersion
-  ) -> Bool {
-    return lhs.majorVersion == rhs.majorVersion &&
-           lhs.minorVersion == rhs.minorVersion &&
-           lhs.patchVersion == rhs.patchVersion
-  }
-
-  /// Lexicographic comparison of version components.
-  @inlinable // FIXME(sil-serialize-all)
-  public static func < (
-    lhs: _SwiftNSOperatingSystemVersion,
-    rhs: _SwiftNSOperatingSystemVersion
-  ) -> Bool {
-    guard lhs.majorVersion == rhs.majorVersion else {
-      return lhs.majorVersion < rhs.majorVersion
-    }
-
-    guard lhs.minorVersion == rhs.minorVersion else {
-      return lhs.minorVersion < rhs.minorVersion
-    }
-
-    return lhs.patchVersion < rhs.patchVersion
-  }
-
-  @inlinable // FIXME(sil-serialize-all)
-  public static func >= (
-    lhs: _SwiftNSOperatingSystemVersion,
-    rhs: _SwiftNSOperatingSystemVersion
-  ) -> Bool {
-    guard lhs.majorVersion == rhs.majorVersion else {
-      return lhs.majorVersion >= rhs.majorVersion
-    }
-
-    guard lhs.minorVersion == rhs.minorVersion else {
-      return lhs.minorVersion >= rhs.minorVersion
-    }
-
-    return lhs.patchVersion >= rhs.patchVersion
-  }
-}

stdlib/public/core/Bool.swift

@@ -81,7 +81,7 @@ public struct Bool {
   /// Creates an instance equal to the given Boolean value.
   ///
   /// - Parameter value: The Boolean value to copy.
-  @inlinable // FIXME(sil-serialize-all)
+  @inlinable
   public init(_ value: Bool) {
     self = value
   }
@@ -176,7 +176,7 @@ extension Bool {
 
 extension Bool : CustomStringConvertible {
   /// A textual representation of the Boolean value.
-  @inlinable // FIXME(sil-serialize-all)
+  @inlinable
   public var description: String {
     return self ? "true" : "false"
   }
@@ -213,7 +213,7 @@ extension Bool : LosslessStringConvertible {
   /// `"false"`, the result is `nil`. This initializer is case sensitive.
   ///
   /// - Parameter description: A string representation of the Boolean value.
-  @inlinable // FIXME(sil-serialize-all)
+  @inlinable
   public init?(_ description: String) {
     if description == "true" {
       self = true

stdlib/public/core/Join.swift

@@ -12,7 +12,7 @@
 
 /// A sequence that presents the elements of a base sequence of sequences
 /// concatenated using a given separator.
-@_fixed_layout // FIXME(sil-serialize-all)
+@_fixed_layout // lazy-performance
 public struct JoinedSequence<Base : Sequence> where Base.Element : Sequence {
 
   public typealias Element = Base.Element.Element
@@ -37,33 +37,33 @@ public struct JoinedSequence<Base : Sequence> where Base.Element : Sequence {
 extension JoinedSequence {
   /// An iterator that presents the elements of the sequences traversed
   /// by a base iterator, concatenated using a given separator.
-  @_fixed_layout // FIXME(sil-serialize-all)
+  @_fixed_layout // lazy-performance
   public struct Iterator {
-    @usableFromInline // FIXME(sil-serialize-all)
+    @usableFromInline // lazy-performance
     internal var _base: Base.Iterator
-    @usableFromInline // FIXME(sil-serialize-all)
+    @usableFromInline // lazy-performance
     internal var _inner: Base.Element.Iterator?
-    @usableFromInline // FIXME(sil-serialize-all)
+    @usableFromInline // lazy-performance
     internal var _separatorData: ContiguousArray<Element>
-    @usableFromInline // FIXME(sil-serialize-all)
+    @usableFromInline // lazy-performance
     internal var _separator: ContiguousArray<Element>.Iterator?
 
-    @_frozen // FIXME(sil-serialize-all)
-    @usableFromInline // FIXME(sil-serialize-all)
+    @_frozen // lazy-performance
+    @usableFromInline // lazy-performance
     internal enum JoinIteratorState {
       case start
       case generatingElements
       case generatingSeparator
       case end
     }
-    @usableFromInline // FIXME(sil-serialize-all)
+    @usableFromInline // lazy-performance
     internal var _state: JoinIteratorState = .start
 
     /// Creates a sequence that presents the elements of `base` sequences
     /// concatenated using `separator`.
     ///
     /// - Complexity: O(`separator.count`).
-    @inlinable // FIXME(sil-serialize-all)
+    @inlinable // lazy-performance
     public init<Separator: Sequence>(base: Base.Iterator, separator: Separator)
       where Separator.Element == Element {
       self._base = base
@@ -79,7 +79,7 @@ extension JoinedSequence.Iterator: IteratorProtocol {
   /// exists.
   ///
   /// Once `nil` has been returned, all subsequent calls return `nil`.
-  @inlinable // FIXME(sil-serialize-all)
+  @inlinable // lazy-performance
   public mutating func next() -> Element? {
     while true {
       switch _state {
@@ -125,12 +125,12 @@ extension JoinedSequence: Sequence {
   /// Return an iterator over the elements of this sequence.
   ///
   /// - Complexity: O(1).
-  @inlinable // FIXME(sil-serialize-all)
+  @inlinable // lazy-performance
   public func makeIterator() -> Iterator {
     return Iterator(base: _base.makeIterator(), separator: _separator)
   }
 
-  @inlinable // FIXME(sil-serialize-all)
+  @inlinable // lazy-performance
   public func _copyToContiguousArray() -> ContiguousArray<Element> {
     var result = ContiguousArray<Element>()
     let separatorSize: Int = numericCast(_separator.count)
@@ -183,7 +183,7 @@ extension Sequence where Element : Sequence {
   /// - Parameter separator: A sequence to insert between each of this
   ///   sequence's elements.
   /// - Returns: The joined sequence of elements.
-  @inlinable // FIXME(sil-serialize-all)
+  @inlinable // lazy-performance
   public func joined<Separator : Sequence>(
     separator: Separator
   ) -> JoinedSequence<Self>

stdlib/public/core/MigrationSupport.swift

@@ -466,6 +466,17 @@ extension String { // RangeReplaceableCollection
   }
 }
 
+@available(*, unavailable, renamed: "TextOutputStream")
+public typealias OutputStreamType = TextOutputStream
+
+extension TextOutputStreamable {
+  @available(*, unavailable, renamed: "write(to:)")
+  public func writeTo<Target : TextOutputStream>(_ target: inout Target) {
+    Builtin.unreachable()
+  }
+}
+
+
 extension String.UnicodeScalarView : _CustomPlaygroundQuickLookable {
   @available(*, deprecated/*, obsoleted: 5.0*/, message: "UnicodeScalarView.customPlaygroundQuickLook will be removed in Swift 5.0")
   public var customPlaygroundQuickLook: _PlaygroundQuickLook {

stdlib/public/core/OutputStream.swift

@@ -374,7 +374,6 @@ internal func _adHocPrint_unlocked<T, TargetStream : TextOutputStream>(
 }
 
 @usableFromInline
-@inline(never)
 @_semantics("optimize.sil.specialize.generic.never")
 internal func _print_unlocked<T, TargetStream : TextOutputStream>(
   _ value: T, _ target: inout TargetStream
@@ -415,7 +414,7 @@ internal func _print_unlocked<T, TargetStream : TextOutputStream>(
 ///
 /// This function is forbidden from being inlined because when building the
 /// standard library inlining makes us drop the special semantics.
-@inline(never) @_effects(readonly)
+@_effects(readonly)
 @usableFromInline
 internal func _toStringReadOnlyStreamable<
   T : TextOutputStreamable
@@ -533,23 +532,17 @@ internal func _dumpPrint_unlocked<T, TargetStream : TextOutputStream>(
 // OutputStreams
 //===----------------------------------------------------------------------===//
 
-@_fixed_layout // FIXME(sil-serialize-all)
-@usableFromInline // FIXME(sil-serialize-all)
 internal struct _Stdout : TextOutputStream {
-  @inlinable // FIXME(sil-serialize-all)
   internal init() {}
 
-  @inlinable // FIXME(sil-serialize-all)
   internal mutating func _lock() {
     _swift_stdlib_flockfile_stdout()
   }
 
-  @inlinable // FIXME(sil-serialize-all)
   internal mutating func _unlock() {
     _swift_stdlib_funlockfile_stdout()
   }
 
-  @inlinable // FIXME(sil-serialize-all)
   internal mutating func write(_ string: String) {
     if string.isEmpty { return }
 
@@ -614,42 +607,25 @@ extension Unicode.Scalar : TextOutputStreamable {
 /// A hook for playgrounds to print through.
 public var _playgroundPrintHook : ((String) -> Void)? = nil
 
-@_fixed_layout // FIXME(sil-serialize-all)
-@usableFromInline // FIXME(sil-serialize-all)
 internal struct _TeeStream<
   L : TextOutputStream,
   R : TextOutputStream
 > : TextOutputStream {
 
-  @inlinable // FIXME(sil-serialize-all)
   internal init(left: L, right: R) {
     self.left = left
     self.right = right
   }
 
-  @usableFromInline // FIXME(sil-serialize-all)
   internal var left: L
-  @usableFromInline // FIXME(sil-serialize-all)
   internal var right: R
 
   /// Append the given `string` to this stream.
-  @inlinable // FIXME(sil-serialize-all)
   internal mutating func write(_ string: String) {
     left.write(string); right.write(string)
   }
 
-  @inlinable // FIXME(sil-serialize-all)
   internal mutating func _lock() { left._lock(); right._lock() }
-  @inlinable // FIXME(sil-serialize-all)
   internal mutating func _unlock() { right._unlock(); left._unlock() }
 }
 
-@available(*, unavailable, renamed: "TextOutputStream")
-public typealias OutputStreamType = TextOutputStream
-
-extension TextOutputStreamable {
-  @available(*, unavailable, renamed: "write(to:)")
-  public func writeTo<Target : TextOutputStream>(_ target: inout Target) {
-    Builtin.unreachable()
-  }
-}

stdlib/public/core/Print.swift

@@ -49,22 +49,19 @@
 ///     space (`" "`).
 ///   - terminator: The string to print after all items have been printed. The
 ///     default is a newline (`"\n"`).
-@inline(never)
 public func print(
   _ items: Any...,
   separator: String = " ",
   terminator: String = "\n"
 ) {
   if let hook = _playgroundPrintHook {
     var output = _TeeStream(left: "", right: _Stdout())
-    _print(
-      items, separator: separator, terminator: terminator, to: &output)
+    _print(items, separator: separator, terminator: terminator, to: &output)
     hook(output.left)
   }
   else {
     var output = _Stdout()
-    _print(
-      items, separator: separator, terminator: terminator, to: &output)
+    _print(items, separator: separator, terminator: terminator, to: &output)
   }
 }
 
@@ -108,21 +105,19 @@ public func print(
 ///     space (`" "`).
 ///   - terminator: The string to print after all items have been printed. The
 ///     default is a newline (`"\n"`).
-@inline(never)
 public func debugPrint(
   _ items: Any...,
   separator: String = " ",
-  terminator: String = "\n") {
+  terminator: String = "\n"
+) {
   if let hook = _playgroundPrintHook {
     var output = _TeeStream(left: "", right: _Stdout())
-    _debugPrint(
-      items, separator: separator, terminator: terminator, to: &output)
+    _debugPrint(items, separator: separator, terminator: terminator, to: &output)
     hook(output.left)
   }
   else {
     var output = _Stdout()
-    _debugPrint(
-      items, separator: separator, terminator: terminator, to: &output)
+    _debugPrint(items, separator: separator, terminator: terminator, to: &output)
   }
 }
 
@@ -163,8 +158,6 @@ public func debugPrint(
 ///     default is a newline (`"\n"`).
 ///   - output: An output stream to receive the text representation of each
 ///     item.
-@inlinable // FIXME(sil-serialize-all)
-@inline(__always)
 public func print<Target : TextOutputStream>(
   _ items: Any...,
   separator: String = " ",
@@ -212,20 +205,15 @@ public func print<Target : TextOutputStream>(
 ///     default is a newline (`"\n"`).
 ///   - output: An output stream to receive the text representation of each
 ///     item.
-@inlinable // FIXME(sil-serialize-all)
-@inline(__always)
 public func debugPrint<Target : TextOutputStream>(
   _ items: Any...,
   separator: String = " ",
   terminator: String = "\n",
   to output: inout Target
 ) {
-  _debugPrint(
-    items, separator: separator, terminator: terminator, to: &output)
+  _debugPrint(items, separator: separator, terminator: terminator, to: &output)
 }
 
-@usableFromInline
-@inline(never)
 internal func _print<Target : TextOutputStream>(
   _ items: [Any],
   separator: String = " ",
@@ -243,8 +231,6 @@ internal func _print<Target : TextOutputStream>(
   output.write(terminator)
 }
 
-@usableFromInline
-@inline(never)
 internal func _debugPrint<Target : TextOutputStream>(
   _ items: [Any],
   separator: String = " ",