Merge pull request #32118 from AnthonyLatsis/post-increment-cleanup

[NFC] Pre- increment and decrement where possible

Author: AnthonyLatsis

include/swift/Remote/Failure.h

@@ -255,7 +255,7 @@ class Failure {
       result.append(text, next - text);
 
       // Skip the '%'.
-      next++;
+      ++next;
 
       // Do something based on the character after '%'.
       char c = *next++;

include/swift/Runtime/Concurrent.h

@@ -434,7 +434,7 @@ template <class ElemTy> struct ConcurrentReadableArray {
     }
 
     void deallocate() {
-      for (size_t i = 0; i < Count; i++) {
+      for (size_t i = 0; i < Count; ++i) {
         data()[i].~ElemTy();
       }
       free(this);

include/swift/SwiftRemoteMirror/SwiftRemoteMirrorLegacyInterop.h

@@ -486,7 +486,7 @@ swift_reflection_interop_loadFunctions(struct SwiftReflectionInteropContext *Con
   LOAD(dumpInfoForTypeRef);
 
   Library->IsLegacy = IsLegacy;
-  Context->LibraryCount++;
+  ++Context->LibraryCount;
 
   return 1;
 

lib/AST/ASTContext.cpp

@@ -3846,7 +3846,7 @@ void SubstitutionMap::Storage::Profile(
       id.AddPointer(replacementTypes[i].getPointer());
     else
       id.AddPointer(nullptr);
-    i++;
+    ++i;
   });
 
   // Conformances.

lib/AST/ASTDemangler.cpp

@@ -304,7 +304,7 @@ Type ASTBuilder::createBoundGenericType(GenericTypeDecl *decl,
   auto *aliasDecl = cast<TypeAliasDecl>(decl);
 
   auto genericSig = aliasDecl->getGenericSignature();
-  for (unsigned i = 0, e = args.size(); i < e; i++) {
+  for (unsigned i = 0, e = args.size(); i < e; ++i) {
     auto origTy = genericSig->getInnermostGenericParams()[i];
     auto substTy = args[i];
 

lib/AST/ASTPrinter.cpp

@@ -1436,7 +1436,7 @@ void PrintAST::printGenericSignature(
     // Move index to genericParams.
     unsigned lastParamIdx = paramIdx;
     do {
-      lastParamIdx++;
+      ++lastParamIdx;
     } while (lastParamIdx < numParam &&
              genericParams[lastParamIdx]->getDepth() == depth);
 

lib/AST/ASTVerifier.cpp

@@ -1692,7 +1692,7 @@ class Verifier : public ASTWalker {
           // Look through optional evaluations.
           if (auto *optionalEval = dyn_cast<OptionalEvaluationExpr>(subExpr)) {
             subExpr = optionalEval->getSubExpr();
-            optionalDepth++;
+            ++optionalDepth;
             continue;
           }
 
@@ -3165,7 +3165,7 @@ class Verifier : public ASTWalker {
         unsigned NumDestructors = 0;
         for (auto Member : CD->getMembers()) {
           if (isa<DestructorDecl>(Member)) {
-            NumDestructors++;
+            ++NumDestructors;
           }
         }
         if (NumDestructors > 1) {

lib/AST/Builtins.cpp

@@ -195,7 +195,7 @@ getBuiltinGenericFunction(Identifier Id,
   DeclContext *DC = &M->getMainFile(FileUnitKind::Builtin);
 
   SmallVector<ParamDecl*, 4> params;
-  for (unsigned i = 0, e = ArgParamTypes.size(); i < e; i++) {
+  for (unsigned i = 0, e = ArgParamTypes.size(); i < e; ++i) {
     auto paramIfaceType = ArgParamTypes[i].getPlainType();
     auto specifier =
       ParamDecl::getParameterSpecifierForValueOwnership(
@@ -2004,11 +2004,11 @@ ValueDecl *swift::getBuiltinValueDecl(ASTContext &Context, Identifier Id) {
 
     // Accept weak, volatile, and singlethread if present.
     if (NextPart != Parts.end() && *NextPart == "weak")
-      NextPart++;
+      ++NextPart;
     if (NextPart != Parts.end() && *NextPart == "volatile")
-      NextPart++;
+      ++NextPart;
     if (NextPart != Parts.end() && *NextPart == "singlethread")
-      NextPart++;
+      ++NextPart;
     // Nothing else is allowed in the name.
     if (NextPart != Parts.end())
       return nullptr;

lib/AST/ClangTypeConverter.cpp

@@ -359,7 +359,7 @@ clang::QualType ClangTypeConverter::visitTupleType(TupleType *type) {
     return ClangASTContext.VoidTy;
 
   Type eltTy = type->getElementType(0);
-  for (unsigned i = 1; i < tupleNumElements; i++) {
+  for (unsigned i = 1; i < tupleNumElements; ++i) {
     if (!eltTy->isEqual(type->getElementType(i)))
       // Only tuples where all element types are equal map to fixed-size
       // arrays.

lib/AST/Decl.cpp

@@ -5036,7 +5036,7 @@ ProtocolDecl::setLazyRequirementSignature(LazyMemberLoader *lazyLoader,
   ++NumLazyRequirementSignatures;
   // FIXME: (transitional) increment the redundant "always-on" counter.
   if (auto *Stats = getASTContext().Stats)
-    Stats->getFrontendCounters().NumLazyRequirementSignatures++;
+    ++Stats->getFrontendCounters().NumLazyRequirementSignatures;
 }
 
 ArrayRef<Requirement> ProtocolDecl::getCachedRequirementSignature() const {
@@ -5196,7 +5196,7 @@ AbstractStorageDecl::AccessorRecord::create(ASTContext &ctx,
       case AccessorKind::ID:                  \
         if (!has##ID) {                       \
           has##ID = true;                     \
-          numMissingOpaque--;                 \
+          --numMissingOpaque;                 \
         }                                     \
         continue;
 #include "swift/AST/AccessorKinds.def"