[Sema] RuntimeMetadata: Add support for async functions and actor methods

Add support for global async functions and actor-isolated methods
by determining isolation context of the method attribute is associated
with and injecting try/await when appropriate.

Author: xedin

lib/Sema/TypeCheckRuntimeMetadataAttr.cpp

@@ -14,9 +14,11 @@
 //
 //===----------------------------------------------------------------------===//
 
+#include "TypeCheckConcurrency.h"
 #include "TypeChecker.h"
 #include "swift/AST/ASTContext.h"
 #include "swift/AST/ASTMangler.h"
+#include "swift/AST/ActorIsolation.h"
 #include "swift/AST/Attr.h"
 #include "swift/AST/Decl.h"
 #include "swift/AST/Initializer.h"
@@ -170,9 +172,39 @@ static ClosureExpr *synthesizeMethodThunk(DeclContext *thunkDC,
       }
     }
 
-    auto *call = CallExpr::createImplicit(
+    Expr *call = CallExpr::createImplicit(
         ctx, memberRef, ArgumentList::createImplicit(ctx, arguments));
 
+    bool isAsync = false;
+    bool isThrows = method->hasThrows();
+
+    switch (getActorIsolation(method)) {
+    case ActorIsolation::Unspecified:
+    case ActorIsolation::Independent: {
+      isAsync = method->hasAsync();
+      break;
+    }
+
+    case ActorIsolation::ActorInstance: {
+      isAsync = true;
+      isThrows |= nominal->isDistributedActor();
+      break;
+    }
+
+    case ActorIsolation::GlobalActor:
+      isAsync = true;
+      LLVM_FALLTHROUGH;
+    case ActorIsolation::GlobalActorUnsafe: {
+      break;
+    }
+    }
+
+    if (isAsync)
+      call = AwaitExpr::createImplicit(ctx, /*awaitLoc=*/SourceLoc(), call);
+
+    if (isThrows)
+      call = TryExpr::createImplicit(ctx, /*tryLoc=*/SourceLoc(), call);
+
     body.push_back(new (ctx) ReturnStmt(/*ReturnLoc=*/SourceLoc(), call,
                                         /*implicit=*/true));
   }
@@ -282,6 +314,7 @@ Expr *SynthesizeRuntimeMetadataAttrGenerator::evaluate(
     return nullptr;
 
   TypeChecker::contextualizeInitializer(initContext, result);
+  checkInitializerActorIsolation(initContext, result);
   TypeChecker::checkInitializerEffects(initContext, result);
 
   return result;

test/IRGen/runtime_attributes_on_actors.swift

@@ -0,0 +1,53 @@
+// RUN: %empty-directory(%t)
+// RUN: %target-swift-frontend -emit-module-path=%t/RAD.swiftmodule -module-name=RAD -enable-experimental-feature RuntimeDiscoverableAttrs -disable-availability-checking %S/Inputs/runtime_attrs.swift
+// RUN: %target-swift-frontend -primary-file %s -emit-ir -I %t -swift-version 5 -enable-experimental-feature RuntimeDiscoverableAttrs -disable-availability-checking | %IRGenFileCheck %s
+
+// REQUIRES: asserts
+// REQUIRES: OS=macosx
+// REQUIRES: concurrency
+
+// CHECK: @"$s28runtime_attributes_on_actors9TestActorC15asyncExternallyyyKcvpfaAA17FlagForAsyncFuncsHF"
+// CHECK: @"$s28runtime_attributes_on_actors9TestActorC11doSomethingyyYaKcvpfaAA17FlagForAsyncFuncsHF"
+// CHECK: @"$s28runtime_attributes_on_actors9TestActorC11doSomethingyySiYacvpfaAA17FlagForAsyncFuncsHF"
+// CHECK: @"$s28runtime_attributes_on_actors9TestActorC11doSomething_1xySi_SaySiGztYacvpfaAA17FlagForAsyncFuncsHF"
+// CHECK: @"$s28runtime_attributes_on_actors13globalAsyncFnSaySSGyYacvpfaAA07FlagForF5FuncsHF"
+
+// CHECK: @"$s28runtime_attributes_on_actors17FlagForAsyncFuncsVHa" = internal constant
+// CHECK-SAME: i32 5
+// CHECK-SAME: %swift.accessible_function* @"$s28runtime_attributes_on_actors9TestActorC15asyncExternallyyyKcvpfaAA17FlagForAsyncFuncsHF"
+// CHECK-SAME: %swift.accessible_function* @"$s28runtime_attributes_on_actors9TestActorC11doSomethingyyYaKcvpfaAA17FlagForAsyncFuncsHF"
+// CHECK-SAME: %swift.accessible_function* @"$s28runtime_attributes_on_actors9TestActorC11doSomethingyySiYacvpfaAA17FlagForAsyncFuncsHF"
+// CHECK-SAME: %swift.accessible_function* @"$s28runtime_attributes_on_actors9TestActorC11doSomething_1xySi_SaySiGztYacvpfaAA17FlagForAsyncFuncsHF"
+// CHECK-SAME: %swift.accessible_function* @"$s28runtime_attributes_on_actors13globalAsyncFnSaySSGyYacvpfaAA07FlagForF5FuncsHF"
+
+@runtimeMetadata
+struct FlagForAsyncFuncs {
+  init<Act>(attachedTo: (Act) async throws -> Void) {}
+  init<Act>(attachedTo: (Act, Int, inout [Int]) async throws -> Void) {}
+  init<Act>(attachedTo: (Act, Int) async -> Void) {}
+  init(attachedTo: () async -> [String]) {}
+}
+
+actor TestActor {
+  // CHECK-LABEL: define hidden swiftcc void @"$s28runtime_attributes_on_actors9TestActorC15asyncExternallyyyKcvpfaAA17FlagForAsyncFuncs"(%T28runtime_attributes_on_actors17FlagForAsyncFuncsVSg* noalias nocapture sret(%T28runtime_attributes_on_actors17FlagForAsyncFuncsVSg) %0)
+  @FlagForAsyncFuncs func asyncExternally() throws {
+  }
+
+  // CHECK-LABEL: define hidden swiftcc void @"$s28runtime_attributes_on_actors9TestActorC11doSomethingyyYaKcvpfaAA17FlagForAsyncFuncs"(%T28runtime_attributes_on_actors17FlagForAsyncFuncsVSg* noalias nocapture sret(%T28runtime_attributes_on_actors17FlagForAsyncFuncsVSg) %0)
+  @FlagForAsyncFuncs func doSomething() async throws {
+  }
+
+  // CHECK-LABEL: define hidden swiftcc void @"$s28runtime_attributes_on_actors9TestActorC11doSomethingyySiYacvpfaAA17FlagForAsyncFuncs"(%T28runtime_attributes_on_actors17FlagForAsyncFuncsVSg* noalias nocapture sret(%T28runtime_attributes_on_actors17FlagForAsyncFuncsVSg) %0)
+  @FlagForAsyncFuncs nonisolated func doSomething(_: Int) async {
+  }
+
+  // CHECK-LABEL: define hidden swiftcc void @"$s28runtime_attributes_on_actors9TestActorC11doSomething_1xySi_SaySiGztYacvpfaAA17FlagForAsyncFuncs"(%T28runtime_attributes_on_actors17FlagForAsyncFuncsVSg* noalias nocapture sret(%T28runtime_attributes_on_actors17FlagForAsyncFuncsVSg) %0)
+  @FlagForAsyncFuncs func doSomething(_: Int, x: inout [Int]) async {
+  }
+}
+
+// CHECK-LABEL: define hidden swiftcc void @"$s28runtime_attributes_on_actors13globalAsyncFnSaySSGyYacvpfaAA07FlagForF5Funcs"(%T28runtime_attributes_on_actors17FlagForAsyncFuncsVSg* noalias nocapture sret(%T28runtime_attributes_on_actors17FlagForAsyncFuncsVSg) %0)
+@FlagForAsyncFuncs
+func globalAsyncFn() async -> [String] {
+  return []
+}

test/type/runtime_discoverable_attrs.swift

@@ -185,3 +185,30 @@ struct TestMutatingMethods {
     (q: "", a: 42)
   }
 }
+
+@runtimeMetadata
+struct FlagForAsyncFuncs {
+  init<Act>(attachedTo: (Act) async throws -> Void) {}
+  init<Act>(attachedTo: (Act, Int, inout [Int]) async throws -> Void) {}
+  init<Act>(attachedTo: (Act, Int) async -> Void) {}
+  init(attachedTo: () async -> [String]) {}
+}
+
+actor TestActor {
+  @FlagForAsyncFuncs func asyncExternally() throws {
+  }
+
+  @FlagForAsyncFuncs func doSomething() async throws {
+  }
+
+  @FlagForAsyncFuncs nonisolated func doSomething(_: Int) async {
+  }
+
+  @FlagForAsyncFuncs func doSomething(_: Int, x: inout [Int]) async {
+  }
+}
+
+@FlagForAsyncFuncs
+func globalAsyncFn() async -> [String] {
+  return []
+}