Disallow dynamic on native Swift declarations under library-evolution mode

The current ABI of dynamic is not what we want for certain declarations.

e.g

dynamic var x : Int {
  willset {
  }
}

Is exposed in the .swiftinterface file as

dynamic var x : Int {
  get {}
  set {}
}

However, the actual implementation is marking the willSet only dynamic.

var x : Int {
  dynamic willSet() {}
  get {}
  set {}
}

To be able to rely on `dynamic` in the future we disable dynamic (for
non-@objc) under library-evolution for now until we have made sure that
the ABI is proper.

rdar://51678074

Author: aschwaighofer

Diff for: include/swift/AST/DiagnosticsSema.def

@@ -3985,6 +3985,11 @@ ERROR(dynamic_with_transparent,none,
       "a declaration cannot be both '@_tranparent' and 'dynamic'",
       ())
 
+ERROR(dynamic_and_library_evolution_not_supported,none,
+      "a native Swift declaration cannot be marked 'dynamic' in library evolution mode",
+      ())
+
+
 //------------------------------------------------------------------------------
 // MARK: @_dynamicReplacement(for:)
 //------------------------------------------------------------------------------

Diff for: include/swift/Basic/LangOptions.h

@@ -305,6 +305,10 @@ namespace swift {
     /// set to true.
     bool ExperimentalDependenciesIncludeIntrafileOnes = false;
 
+    /// We disallow explicit dynamic on native swift declarations in
+    /// library-evolution-mode for now because the ABI is not fully baked.
+    bool DisallowDynamicOnNativeSwiftDeclarations = false;
+
     /// Sets the target we are building for and updates platform conditions
     /// to match.
     ///

Diff for: lib/Frontend/CompilerInvocation.cpp

@@ -261,6 +261,10 @@ static bool ParseLangArgs(LangOptions &Opts, ArgList &Args,
   Opts.EnableOpaqueResultTypes |=
       Args.hasArg(OPT_enable_opaque_result_types);
 
+  // We don't allow dynamic on native swift declarations.
+  Opts.DisallowDynamicOnNativeSwiftDeclarations |=
+      Args.hasArg(OPT_enable_library_evolution);
+
   // Always enable operator designated types for the standard library.
   Opts.EnableOperatorDesignatedTypes |= FrontendOpts.ParseStdlib;
 

Diff for: lib/Sema/TypeCheckAttr.cpp

@@ -333,9 +333,12 @@ void AttributeEarlyChecker::visitDynamicAttr(DynamicAttr *attr) {
   // Members cannot be both dynamic and @_transparent.
   if (D->getAttrs().hasAttribute<TransparentAttr>())
     diagnoseAndRemoveAttr(attr, diag::dynamic_with_transparent);
+  if (!D->getAttrs().hasAttribute<ObjCAttr>()&&
+      TC.getLangOpts().DisallowDynamicOnNativeSwiftDeclarations)
+    diagnoseAndRemoveAttr(attr,
+                          diag::dynamic_and_library_evolution_not_supported);
 }
 
-
 void AttributeEarlyChecker::visitIBActionAttr(IBActionAttr *attr) {
   // Only instance methods can be IBActions.
   const FuncDecl *FD = cast<FuncDecl>(D);

Diff for: test/attr/dynamicReplacement_library_evolution.swift

@@ -0,0 +1,17 @@
+// RUN: %empty-directory(%t)
+// RUN: %target-typecheck-verify-swift -swift-version 5 -enable-library-evolution  -I %t
+
+struct Container {
+  dynamic var property: Int { return 1 } // expected-error{{a native Swift declaration cannot be marked 'dynamic' in library evolution mode}}
+  dynamic func foo() {} // expected-error{{a native Swift declaration cannot be marked 'dynamic' in library evolution mode}}
+}
+
+class AClass {
+  dynamic var property: Int { return 1 } // expected-error{{a native Swift declaration cannot be marked 'dynamic' in library evolution mode}}
+  dynamic func foo() {} // expected-error{{a native Swift declaration cannot be marked 'dynamic' in library evolution mode}}
+
+  @objc dynamic func allowed() {}
+
+
+  @objc dynamic var allowedProperty : Int { return 1}
+}

Diff for: test/attr/dynamicReplacement_library_evolution_implicit_dynamic.swift

@@ -0,0 +1,17 @@
+// RUN: %empty-directory(%t)
+// RUN: %target-typecheck-verify-swift -swift-version 5 -enable-library-evolution -enable-implicit-dynamic -I %t
+
+struct Container {
+  var property: Int { return 1 }
+  func foo() {}
+}
+
+class AClass {
+  var property: Int { return 1 }
+  func foo() {}
+
+  @objc dynamic func allowed() {}
+
+
+  @objc dynamic var allowedProperty : Int { return 1}
+}