Skip to content

Commit 02e669b

Browse files
committed
Reflection: Re-enable some tests on no-ASAN builds
These tests fail because we incorrectly build some parts of the reflection library with the swift-clang, and link it against code built with the host-clang. ASAN doesn't support this. Until we fix this, make sure we skip the tests only in ASAN builds, instead of disabling them altogether.
1 parent 703a63f commit 02e669b

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

test/Reflection/capture_descriptors.sil

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// REQUIRES: rdar://29605167
1+
// REQUIRES: no_asan
22
// RUN: rm -rf %t && mkdir -p %t
33
// RUN: %target-build-swift %s -emit-module -emit-library -module-name capture_descriptors -o %t/capture_descriptors.%target-dylib-extension
44
// RUN: %target-swift-reflection-dump -binary-filename %t/capture_descriptors.%target-dylib-extension | %FileCheck %s

test/Reflection/typeref_decoding.swift

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// REQUIRES: rdar://29605167
1+
// REQUIRES: no_asan
22
// RUN: rm -rf %t && mkdir -p %t
33
// RUN: %target-build-swift %S/Inputs/ConcreteTypes.swift %S/Inputs/GenericTypes.swift %S/Inputs/Protocols.swift %S/Inputs/Extensions.swift %S/Inputs/Closures.swift -parse-as-library -emit-module -emit-library -module-name TypesToReflect -o %t/libTypesToReflect.%target-dylib-extension
44
// RUN: %target-swift-reflection-dump -binary-filename %t/libTypesToReflect.%target-dylib-extension | %FileCheck %s

test/Reflection/typeref_lowering.swift

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// REQUIRES: rdar://29605167
1+
// REQUIRES: no_asan
22
// RUN: rm -rf %t && mkdir -p %t
33
// RUN: %target-build-swift %S/Inputs/TypeLowering.swift -parse-as-library -emit-module -emit-library -module-name TypeLowering -o %t/libTypesToReflect.%target-dylib-extension
44
// RUN: %target-swift-reflection-dump -binary-filename %t/libTypesToReflect.%target-dylib-extension -binary-filename %platform-module-dir/libswiftCore.%target-dylib-extension -dump-type-lowering < %s | %FileCheck %s --check-prefix=CHECK-%target-ptrsize

0 commit comments

Comments
 (0)