-
Notifications
You must be signed in to change notification settings - Fork 10.4k
/
Copy pathReferenceBindingTransform.cpp
362 lines (296 loc) · 12.2 KB
/
ReferenceBindingTransform.cpp
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
//===--- ReferenceBindingTransform.cpp ------------------------------------===//
//
// This source file is part of the Swift.org open source project
//
// Copyright (c) 2014 - 2022 Apple Inc. and the Swift project authors
// Licensed under Apache License v2.0 with Runtime Library Exception
//
// See https://swift.org/LICENSE.txt for license information
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
//
//===----------------------------------------------------------------------===//
#define DEBUG_TYPE "sil-reference-binding-transform"
#include "swift/AST/DiagnosticsSIL.h"
#include "swift/Basic/Assertions.h"
#include "swift/Basic/Defer.h"
#include "swift/SIL/BasicBlockDatastructures.h"
#include "swift/SIL/FieldSensitivePrunedLiveness.h"
#include "swift/SIL/PrunedLiveness.h"
#include "swift/SIL/SILBuilder.h"
#include "swift/SILOptimizer/PassManager/Transforms.h"
using namespace swift;
static llvm::cl::opt<bool> SilentlyEmitDiagnostics(
"sil-reference-binding-diagnostics-silently-emit-diagnostics",
llvm::cl::desc(
"For testing purposes, emit the diagnostic silently so we can "
"filecheck the result of emitting an error from the move checkers"),
llvm::cl::init(false));
//===----------------------------------------------------------------------===//
// MARK: Diagnosis Helpers
//===----------------------------------------------------------------------===//
template <typename... T, typename... U>
static void diagnose(SILInstruction *inst, Diag<T...> diag, U &&...args) {
// If we asked to actually emit diagnostics, skip it. This lets us when
// testing to write FileCheck tests for tests without an error along side
// other tests where we want to use -verify.
if (SilentlyEmitDiagnostics)
return;
// See if the consuming use is an owned moveonly_to_copyable whose only
// user is a return. In that case, use the return loc instead. We do this
// b/c it is illegal to put a return value location on a non-return value
// instruction... so we have to hack around this slightly.
auto loc = inst->getLoc();
if (auto *mtc = dyn_cast<MoveOnlyWrapperToCopyableValueInst>(inst)) {
if (auto *ri = mtc->getSingleUserOfType<ReturnInst>()) {
loc = ri->getLoc();
}
}
auto &context = inst->getModule().getASTContext();
context.Diags.diagnose(loc.getSourceLoc(), diag, std::forward<U>(args)...);
}
//===----------------------------------------------------------------------===//
// MARK: Utilities
//===----------------------------------------------------------------------===//
namespace {
struct RAIILLVMDebug {
StringRef str;
RAIILLVMDebug(StringRef str) : str(str) {
LLVM_DEBUG(llvm::dbgs() << "===>>> Starting " << str << '\n');
}
RAIILLVMDebug(StringRef str, SILInstruction *u) : str(str) {
LLVM_DEBUG(llvm::dbgs() << "===>>> Starting " << str << ":" << *u);
}
~RAIILLVMDebug() {
LLVM_DEBUG(llvm::dbgs() << "===<<< Completed " << str << '\n');
}
};
} // namespace
//===----------------------------------------------------------------------===//
// MARK: Gather Address Uses
//===----------------------------------------------------------------------===//
namespace {
struct ValidateAllUsesWithinLiveness : public AccessUseVisitor {
SSAPrunedLiveness &liveness;
SILInstruction *markInst;
SILInstruction *initInst;
bool emittedDiagnostic = false;
ValidateAllUsesWithinLiveness(SSAPrunedLiveness &gatherUsesLiveness,
SILInstruction *markInst,
SILInstruction *initInst)
: AccessUseVisitor(AccessUseType::Overlapping,
NestedAccessType::IgnoreAccessBegin),
liveness(gatherUsesLiveness), markInst(markInst), initInst(initInst) {}
bool visitUse(Operand *op, AccessUseType useTy) override {
auto *user = op->getUser();
// Skip our initInst which is going to be within the lifetime.
if (user == initInst)
return true;
// Skip end_access. We care about the end_access uses.
if (isa<EndAccessInst>(user))
return true;
if (liveness.isWithinBoundary(user, /*deadEndBlocks=*/nullptr)) {
LLVM_DEBUG(llvm::dbgs() << "User in boundary: " << *user);
diagnose(op->getUser(),
diag::sil_referencebinding_src_used_within_inout_scope);
diagnose(markInst, diag::sil_referencebinding_inout_binding_here);
emittedDiagnostic = true;
}
return true;
}
};
} // end anonymous namespace
//===----------------------------------------------------------------------===//
// MARK: Transform
//===----------------------------------------------------------------------===//
namespace {
struct DiagnosticEmitter {
unsigned numDiagnostics = 0;
void diagnoseUnknownPattern(MarkUnresolvedReferenceBindingInst *mark) {
diagnose(mark, diag::sil_referencebinding_unknown_pattern);
++numDiagnostics;
}
};
} // namespace
namespace {
class ReferenceBindingProcessor {
MarkUnresolvedReferenceBindingInst *mark;
DiagnosticEmitter &diagnosticEmitter;
public:
ReferenceBindingProcessor(MarkUnresolvedReferenceBindingInst *mark,
DiagnosticEmitter &diagnosticEmitter)
: mark(mark), diagnosticEmitter(diagnosticEmitter) {}
bool process() &&;
private:
CopyAddrInst *findInit();
};
} // namespace
CopyAddrInst *ReferenceBindingProcessor::findInit() {
RAIILLVMDebug llvmDebug("Find initialization");
// We rely on the following semantics to find our initialization:
//
// 1. SILGen always initializes values completely.
// 2. Boxes always have operations guarded /except/ for their
// initialization.
// 3. We force inout to always be initialized once.
//
// Thus to find our initialization, we need to find a project_box use of our
// target that directly initializes the value.
CopyAddrInst *initInst = nullptr;
InstructionWorklist worklist(mark->getFunction());
for (auto *user : mark->getUsers()) {
worklist.push(user);
}
while (auto *user = worklist.pop()) {
LLVM_DEBUG(llvm::dbgs() << "Visiting use: " << *user);
auto *bbi = dyn_cast<BeginBorrowInst>(user);
if (bbi && bbi->isFromVarDecl()) {
for (auto *user : bbi->getUsers()) {
worklist.push(user);
}
continue;
}
auto *pbi = dyn_cast<ProjectBoxInst>(user);
if (!pbi)
continue;
LLVM_DEBUG(llvm::dbgs() << " Found project_box! Visiting pbi uses!\n");
for (auto *pbiUse : pbi->getUses()) {
LLVM_DEBUG(llvm::dbgs() << " Pbi Use: " << *pbiUse->getUser());
auto *cai = dyn_cast<CopyAddrInst>(pbiUse->getUser());
if (!cai || cai->getDest() != pbi) {
LLVM_DEBUG(llvm::dbgs() << " Either not a copy_addr or dest is "
"not the project_box! Skipping!\n");
continue;
}
if (initInst || !cai->isInitializationOfDest() || cai->isTakeOfSrc()) {
LLVM_DEBUG(
llvm::dbgs()
<< " Either already found an init inst or is an assign of a "
"dest or a take of src... emitting unknown pattern!\n");
diagnosticEmitter.diagnoseUnknownPattern(mark);
return nullptr;
}
assert(!initInst && "Init twice?!");
assert(!cai->isTakeOfSrc());
initInst = cai;
LLVM_DEBUG(llvm::dbgs()
<< " Found our init! Checking for other inits!\n");
}
}
LLVM_DEBUG(llvm::dbgs() << "Final Init: " << *initInst);
return initInst;
}
bool ReferenceBindingProcessor::process() && {
// Find a single initialization of our inout parameter. See helper function
// for the information about the invariants we rely upon.
auto *initInst = findInit();
if (!initInst)
return false;
// Ok, we have our initialization. Now gather our destroys of our value and
// initialize an SSAPrunedLiveness, using our initInst as our def.
auto *fn = mark->getFunction();
SmallVector<SILBasicBlock *, 8> discoveredBlocks;
SSAPrunedLiveness liveness(fn, &discoveredBlocks);
StackList<DestroyValueInst *> destroyValueInst(fn);
{
RAIILLVMDebug llvmDebug("Initializing liveness!");
liveness.initializeDef(mark);
for (auto *consume : mark->getConsumingUses()) {
// Make sure that the destroy_value is not within the boundary.
auto *dai = dyn_cast<DestroyValueInst>(consume->getUser());
if (!dai) {
LLVM_DEBUG(llvm::dbgs() << " Found non destroy value consuming use! "
"Emitting unknown pattern: "
<< *dai);
diagnosticEmitter.diagnoseUnknownPattern(mark);
return false;
}
LLVM_DEBUG(llvm::dbgs() << " Found destroy_value use: " << *dai);
liveness.updateForUse(dai, true /*is lifetime ending*/);
destroyValueInst.push_back(dai);
}
}
// Now make sure that our source address doesn't have any uses within the
// lifetime of our box. Or emit an error. Since sema always ensures that we
// have an lvalue, we should always find an access scope.
BeginAccessInst *bai = nullptr;
StackList<SILInstruction *> endAccesses(fn);
{
auto accessPathWithBase =
AccessPathWithBase::computeInScope(initInst->getSrc());
assert(accessPathWithBase.base);
// Then search up for a single begin_access from src to find our
// begin_access we need to fix. We know that it will always be directly on
// the type since we only allow for inout today to be on decl_ref expr. This
// will change in the future. Once we find that begin_access, we need to
// convert it to a modify and expand it.
bai = cast<BeginAccessInst>(accessPathWithBase.base);
assert(bai->getAccessKind() == SILAccessKind::Read);
for (auto *eai : bai->getEndAccesses())
endAccesses.push_back(eai);
{
ValidateAllUsesWithinLiveness initGatherer(liveness, mark, initInst);
if (!visitAccessPathBaseUses(initGatherer, accessPathWithBase, fn)) {
diagnosticEmitter.diagnoseUnknownPattern(mark);
return false;
}
}
}
initInst->setIsTakeOfSrc(IsTake);
bai->setAccessKind(SILAccessKind::Modify);
while (!endAccesses.empty())
endAccesses.pop_back_val()->eraseFromParent();
while (!destroyValueInst.empty()) {
auto *consume = destroyValueInst.pop_back_val();
SILBuilderWithScope builder(consume);
auto *pbi = builder.createProjectBox(consume->getLoc(), mark, 0);
builder.createCopyAddr(consume->getLoc(), pbi, initInst->getSrc(), IsTake,
IsInitialization);
builder.createEndAccess(consume->getLoc(), bai, false /*aborted*/);
builder.createDeallocBox(consume->getLoc(), mark);
consume->eraseFromParent();
}
return true;
}
static bool runTransform(SILFunction *fn) {
bool madeChange = false;
// First go through and find all of our mark_unresolved_reference_binding.
StackList<MarkUnresolvedReferenceBindingInst *> targets(fn);
for (auto &block : *fn) {
for (auto &ii : block) {
if (auto *murbi = dyn_cast<MarkUnresolvedReferenceBindingInst>(&ii))
targets.push_back(murbi);
}
}
DiagnosticEmitter emitter;
while (!targets.empty()) {
auto *mark = targets.pop_back_val();
LLVM_DEBUG(llvm::dbgs() << "===> Visiting mark: " << *mark);
ReferenceBindingProcessor processor{mark, emitter};
madeChange |= std::move(processor).process();
mark->replaceAllUsesWith(mark->getOperand());
mark->eraseFromParent();
madeChange = true;
}
return madeChange;
}
//===----------------------------------------------------------------------===//
// MARK: Top Level Entrypoint
//===----------------------------------------------------------------------===//
namespace {
struct ReferenceBindingTransformPass : SILFunctionTransform {
void run() override {
auto *fn = getFunction();
// Only run this if the reference binding feature is enabled.
if (!fn->getASTContext().LangOpts.hasFeature(Feature::ReferenceBindings))
return;
LLVM_DEBUG(llvm::dbgs()
<< "!!! === RefBindingTransform: " << fn->getName() << '\n');
if (runTransform(fn)) {
invalidateAnalysis(SILAnalysis::Instructions);
}
}
};
} // namespace
SILTransform *swift::createReferenceBindingTransform() {
return new ReferenceBindingTransformPass();
}