-
Notifications
You must be signed in to change notification settings - Fork 10.4k
/
Copy pathResilienceDiagnostics.cpp
311 lines (257 loc) · 12.1 KB
/
ResilienceDiagnostics.cpp
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
//===--- ResilienceDiagnostics.cpp - Resilience Inlineability Diagnostics -===//
//
// This source file is part of the Swift.org open source project
//
// Copyright (c) 2014 - 2017 Apple Inc. and the Swift project authors
// Licensed under Apache License v2.0 with Runtime Library Exception
//
// See https://swift.org/LICENSE.txt for license information
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
//
//===----------------------------------------------------------------------===//
//
// This file implements diagnostics for fragile functions, like those with
// @inlinable, @_alwaysEmitIntoClient, or @backDeployed.
//
//===----------------------------------------------------------------------===//
#include "TypeChecker.h"
#include "TypeCheckAvailability.h"
#include "TypeCheckAccess.h"
#include "swift/AST/Attr.h"
#include "swift/AST/Decl.h"
#include "swift/AST/DeclContext.h"
#include "swift/AST/Initializer.h"
#include "swift/AST/ProtocolConformance.h"
#include "swift/AST/SourceFile.h"
#include "swift/AST/TypeDeclFinder.h"
using namespace swift;
static bool addMissingImport(SourceLoc loc, const Decl *D,
const ExportContext &where) {
ASTContext &ctx = where.getDeclContext()->getASTContext();
ModuleDecl *M = D->getModuleContext();
auto *SF = where.getDeclContext()->getParentSourceFile();
// Only add imports of API level modules if this is an API level module.
if (M->getLibraryLevel() != LibraryLevel::API &&
SF->getParentModule()->getLibraryLevel() == LibraryLevel::API)
return false;
// Hack to fix swiftinterfaces in case of missing imports. We can get rid of
// this logic when we don't leak the use of non-locally imported things in
// API.
auto missingImport = ImportedModule(ImportPath::Access(),
const_cast<ModuleDecl *>(M));
SF->addMissingImportedModule(missingImport);
ctx.Diags.diagnose(loc, diag::missing_import_inserted, M->getName());
return true;
}
bool TypeChecker::diagnoseInlinableDeclRefAccess(SourceLoc loc,
const ValueDecl *D,
const ExportContext &where) {
auto fragileKind = where.getFragileFunctionKind();
if (fragileKind.kind == FragileFunctionKind::None)
return false;
// Local declarations are OK.
if (D->getDeclContext()->isLocalContext())
return false;
// General check on access-level of the decl.
auto declAccessScope =
D->getFormalAccessScope(/*useDC=*/nullptr,
/*allowUsableFromInline=*/true);
// If the decl is imported, check if the import lowers it's access level.
auto importAccessLevel = AccessLevel::Public;
ImportAccessLevel problematicImport = llvm::None;
auto *DC = where.getDeclContext();
auto targetModule = D->getDeclContext()->getParentModule();
auto file = where.getDeclContext()->getParentSourceFile();
if (targetModule != DC->getParentModule() && file) {
problematicImport = file->getImportAccessLevel(targetModule);
if (problematicImport.has_value())
importAccessLevel = problematicImport->accessLevel;
}
// Public declarations are OK, even if they're SPI or came from an
// implementation-only import. We'll diagnose exportability violations
// from diagnoseDeclRefExportability().
if (declAccessScope.isPublic() &&
importAccessLevel == AccessLevel::Public)
return false;
auto &Context = DC->getASTContext();
// Dynamic declarations were mistakenly not checked in Swift 4.2.
// Do enforce the restriction even in pre-Swift-5 modes if the module we're
// building is resilient, though.
if (D->shouldUseObjCDispatch() && !Context.isSwiftVersionAtLeast(5) &&
!DC->getParentModule()->isResilient()) {
return false;
}
DowngradeToWarning downgradeToWarning = DowngradeToWarning::No;
// Swift 4.2 did not perform any checks for type aliases.
if (isa<TypeAliasDecl>(D)) {
if (!Context.isSwiftVersionAtLeast(4, 2))
return false;
if (!Context.isSwiftVersionAtLeast(5))
downgradeToWarning = DowngradeToWarning::Yes;
}
// Swift 4.2 did not check accessor accessibility.
if (auto accessor = dyn_cast<AccessorDecl>(D)) {
if (!Context.isSwiftVersionAtLeast(5))
downgradeToWarning = DowngradeToWarning::Yes;
}
// Swift 5.0 did not check the underlying types of local typealiases.
if (isa<TypeAliasDecl>(DC) && !Context.isSwiftVersionAtLeast(6))
downgradeToWarning = DowngradeToWarning::Yes;
auto diagID = diag::resilience_decl_unavailable;
if (downgradeToWarning == DowngradeToWarning::Yes)
diagID = diag::resilience_decl_unavailable_warn;
auto diagAccessLevel = std::min(declAccessScope.accessLevelForDiagnostics(),
importAccessLevel);
Context.Diags.diagnose(loc, diagID, D, diagAccessLevel,
fragileKind.getSelector());
Context.Diags.diagnose(D, diag::resilience_decl_declared_here, D);
if (problematicImport.has_value() &&
diagAccessLevel == importAccessLevel) {
Context.Diags.diagnose(problematicImport->accessLevelLoc,
diag::decl_import_via_here, D,
problematicImport->accessLevel,
problematicImport->module.importedModule->getName());
}
return (downgradeToWarning == DowngradeToWarning::No);
}
static bool diagnoseTypeAliasDeclRefExportability(SourceLoc loc,
const TypeAliasDecl *TAD,
const ExportContext &where) {
assert(where.mustOnlyReferenceExportedDecls());
auto *D = TAD->getUnderlyingType()->getAnyNominal();
if (!D)
return false;
auto ignoredDowngradeToWarning = DowngradeToWarning::No;
auto originKind =
getDisallowedOriginKind(D, where, ignoredDowngradeToWarning);
if (originKind == DisallowedOriginKind::None)
return false;
auto exportingModule = where.getDeclContext()->getParentModule();
ASTContext &ctx = exportingModule->getASTContext();
// As an exception, if the import of the module that defines the desugared
// decl is just missing (as opposed to imported explicitly with reduced
// visibility) then we should only diagnose if we're building a resilient
// module.
if (originKind == DisallowedOriginKind::MissingImport &&
!exportingModule->isResilient())
return false;
auto definingModule = D->getModuleContext();
auto fragileKind = where.getFragileFunctionKind();
if (fragileKind.kind == FragileFunctionKind::None) {
auto reason = where.getExportabilityReason();
ctx.Diags
.diagnose(loc, diag::typealias_desugars_to_type_from_hidden_module,
TAD->getName(), definingModule->getNameStr(), D->getNameStr(),
static_cast<unsigned>(*reason), definingModule->getName(),
static_cast<unsigned>(originKind))
.warnUntilSwiftVersionIf(originKind != DisallowedOriginKind::SPIOnly,
6);
} else {
ctx.Diags
.diagnose(loc,
diag::inlinable_typealias_desugars_to_type_from_hidden_module,
TAD->getName(), definingModule->getNameStr(), D->getNameStr(),
fragileKind.getSelector(), definingModule->getName(),
static_cast<unsigned>(originKind))
.warnUntilSwiftVersionIf(originKind != DisallowedOriginKind::SPIOnly,
6);
}
D->diagnose(diag::kind_declared_here, DescriptiveDeclKind::Type);
if (originKind == DisallowedOriginKind::MissingImport &&
!ctx.LangOpts.isSwiftVersionAtLeast(6))
addMissingImport(loc, D, where);
return true;
}
static bool diagnoseValueDeclRefExportability(SourceLoc loc, const ValueDecl *D,
const ExportContext &where) {
assert(where.mustOnlyReferenceExportedDecls());
auto definingModule = D->getModuleContext();
auto downgradeToWarning = DowngradeToWarning::No;
auto originKind = getDisallowedOriginKind(
D, where, downgradeToWarning);
if (originKind == DisallowedOriginKind::None)
return false;
auto diagName = D->getName();
if (auto accessor = dyn_cast<AccessorDecl>(D)) {
// Only diagnose accessors if their disallowed origin kind differs from
// that of their storage.
if (getDisallowedOriginKind(accessor->getStorage(), where) == originKind)
return false;
// For accessors, diagnose with the name of the storage instead of the
// implicit '_'.
diagName = accessor->getStorage()->getName();
}
ASTContext &ctx = where.getDeclContext()->getASTContext();
auto fragileKind = where.getFragileFunctionKind();
auto reason = where.getExportabilityReason();
if (fragileKind.kind == FragileFunctionKind::None) {
DiagnosticBehavior limit = downgradeToWarning == DowngradeToWarning::Yes
? DiagnosticBehavior::Warning
: DiagnosticBehavior::Unspecified;
ctx.Diags.diagnose(loc, diag::decl_from_hidden_module, D,
static_cast<unsigned>(*reason),
definingModule->getName(),
static_cast<unsigned>(originKind))
.limitBehavior(limit);
D->diagnose(diag::kind_declared_here, DescriptiveDeclKind::Type);
} else {
// Only implicitly imported decls should be reported as a warning,
// and only for language versions below Swift 6.
assert(downgradeToWarning == DowngradeToWarning::No ||
originKind == DisallowedOriginKind::MissingImport &&
"Only implicitly imported decls should be reported as a warning.");
ctx.Diags.diagnose(loc, diag::inlinable_decl_ref_from_hidden_module, D,
fragileKind.getSelector(), definingModule->getName(),
static_cast<unsigned>(originKind))
.warnUntilSwiftVersionIf(downgradeToWarning == DowngradeToWarning::Yes,
6);
if (originKind == DisallowedOriginKind::MissingImport &&
downgradeToWarning == DowngradeToWarning::Yes)
addMissingImport(loc, D, where);
}
return true;
}
bool TypeChecker::diagnoseDeclRefExportability(SourceLoc loc,
const ValueDecl *D,
const ExportContext &where) {
if (!where.mustOnlyReferenceExportedDecls())
return false;
if (diagnoseValueDeclRefExportability(loc, D, where))
return true;
if (auto *TAD = dyn_cast<TypeAliasDecl>(D))
if (diagnoseTypeAliasDeclRefExportability(loc, TAD, where))
return true;
return false;
}
bool
TypeChecker::diagnoseConformanceExportability(SourceLoc loc,
const RootProtocolConformance *rootConf,
const ExtensionDecl *ext,
const ExportContext &where,
bool useConformanceAvailabilityErrorsOption) {
if (!where.mustOnlyReferenceExportedDecls())
return false;
auto originKind = getDisallowedOriginKind(ext, where);
if (originKind == DisallowedOriginKind::None)
return false;
ModuleDecl *M = ext->getParentModule();
ASTContext &ctx = M->getASTContext();
auto reason = where.getExportabilityReason();
if (!reason.has_value())
reason = ExportabilityReason::General;
ctx.Diags.diagnose(loc, diag::conformance_from_implementation_only_module,
rootConf->getType(),
rootConf->getProtocol()->getName(),
static_cast<unsigned>(*reason),
M->getName(),
static_cast<unsigned>(originKind))
.warnUntilSwiftVersionIf((useConformanceAvailabilityErrorsOption &&
!ctx.LangOpts.EnableConformanceAvailabilityErrors &&
originKind != DisallowedOriginKind::SPIOnly) ||
originKind == DisallowedOriginKind::MissingImport,
6);
if (originKind == DisallowedOriginKind::MissingImport &&
!ctx.LangOpts.isSwiftVersionAtLeast(6))
addMissingImport(loc, ext, where);
return true;
}