-
Notifications
You must be signed in to change notification settings - Fork 10.4k
/
Copy pathPartialApplyCombiner.cpp
329 lines (281 loc) · 12.4 KB
/
PartialApplyCombiner.cpp
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
//===--- PartialApplyCombiner.cpp -----------------------------------------===//
//
// This source file is part of the Swift.org open source project
//
// Copyright (c) 2014 - 2019 Apple Inc. and the Swift project authors
// Licensed under Apache License v2.0 with Runtime Library Exception
//
// See https://swift.org/LICENSE.txt for license information
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
//
//===----------------------------------------------------------------------===//
#include "swift/Basic/Assertions.h"
#include "swift/SIL/SILValue.h"
#include "swift/SIL/ScopedAddressUtils.h"
#include "swift/SILOptimizer/Utils/InstOptUtils.h"
#include "swift/SILOptimizer/Utils/OwnershipOptUtils.h"
#include "swift/SILOptimizer/Utils/ValueLifetime.h"
using namespace swift;
namespace {
// Helper class performing the apply{partial_apply(x,y)}(z) -> apply(z,x,y)
// peephole.
class PartialApplyCombiner {
// partial_apply which is being processed.
PartialApplyInst *pai;
// Temporaries created as copies of alloc_stack arguments of
// the partial_apply.
SmallVector<SILValue, 8> tmpCopies;
// Mapping from the original argument of partial_apply to
// the temporary containing its copy.
llvm::DenseMap<SILValue, SILValue> argToTmpCopy;
SILBuilderContext &builderCtxt;
InstModCallbacks &callbacks;
bool copyArgsToTemporaries(ArrayRef<FullApplySite> applies);
void processSingleApply(FullApplySite ai);
public:
PartialApplyCombiner(PartialApplyInst *pai, SILBuilderContext &builderCtxt,
InstModCallbacks &callbacks)
: pai(pai), builderCtxt(builderCtxt), callbacks(callbacks) {}
bool combine();
};
} // end anonymous namespace
/// Copy the original arguments of the partial_apply into newly created
/// temporaries and use these temporaries instead of the original arguments
/// afterwards.
///
/// This is done to "extend" the life-time of original partial_apply arguments,
/// as they may be destroyed/deallocated before the last use by one of the
/// apply instructions.
bool PartialApplyCombiner::copyArgsToTemporaries(
ArrayRef<FullApplySite> applies) {
SmallVector<Operand *, 8> argsToHandle;
// Find args that need extension for a non-stack partial_apply
// A partial_apply [stack]'s argument are not owned by the partial_apply and
// therefore their lifetime must outlive any uses.
if (!pai->isOnStack()) {
getConsumedPartialApplyArgs(pai, argsToHandle,
/*includeTrivialAddrArgs*/ true);
}
// Compute the set of endpoints, which will be used to insert destroys of
// temporaries.
SmallVector<Operand *, 16> paiUses;
// Of course we must include all apply instructions which we want to optimize.
for (FullApplySite ai : applies) {
paiUses.push_back(ai.getCalleeOperand());
}
SmallVector<StoreBorrowInst *, 8> storeBorrowsToHandle;
for (auto arg : pai->getArguments()) {
if (auto *sbi = dyn_cast<StoreBorrowInst>(arg)) {
storeBorrowsToHandle.push_back(sbi);
}
}
if (argsToHandle.empty() && storeBorrowsToHandle.empty()) {
return true;
}
// Also include all destroys in the liverange for the arguments.
// This is needed for later processing in tryDeleteDeadClosure: in case the
// pai gets dead after this optimization, tryDeleteDeadClosure relies on
// that we already copied the pai arguments to extend their lifetimes until
// the pai is finally destroyed.
collectDestroys(pai, paiUses);
ValueLifetimeAnalysis vla(pai,
llvm::ArrayRef(paiUses.begin(), paiUses.end()));
ValueLifetimeAnalysis::Frontier partialApplyFrontier;
// Computing the frontier may fail if the frontier is located on a critical
// edge which we may not split.
if (!vla.computeFrontier(partialApplyFrontier,
ValueLifetimeAnalysis::DontModifyCFG)) {
return false;
}
// We must not introduce copies for move only types.
// TODO: in OSSA, instead of bailing, it's possible to keep the arguments
// alive without the need of copies.
for (Operand *argOp : argsToHandle) {
if (argOp->get()->getType().isMoveOnly())
return false;
}
for (Operand *argOp : argsToHandle) {
SILValue arg = argOp->get();
SILValue tmp = arg;
SILBuilderWithScope builder(pai, builderCtxt);
if (arg->getType().isObject()) {
tmp = builder.emitCopyValueOperation(pai->getLoc(), arg);
} else {
// Copy address-arguments into a stack-allocated temporary.
tmp = builder.createAllocStack(pai->getLoc(), arg->getType());
builder.createCopyAddr(pai->getLoc(), arg, tmp, IsTake_t::IsNotTake,
IsInitialization_t::IsInitialization);
}
argToTmpCopy.insert(std::make_pair(arg, tmp));
// Destroy the argument value (either as SSA value or in the stack-
// allocated temporary) at the end of the partial_apply's lifetime.
endLifetimeAtFrontier(tmp, partialApplyFrontier, builderCtxt, callbacks);
}
DeadEndBlocks deBlocks(pai->getFunction());
for (auto *storeBorrow : storeBorrowsToHandle) {
if (extendStoreBorrow(storeBorrow, paiUses, &deBlocks, callbacks)) {
continue;
}
SILBuilderWithScope builder(pai, builderCtxt);
// Copy address-arguments into a stack-allocated temporary.
auto *asi = builder.createAllocStack(pai->getLoc(), storeBorrow->getType());
builder.createCopyAddr(pai->getLoc(), storeBorrow, asi, IsTake_t::IsNotTake,
IsInitialization_t::IsInitialization);
argToTmpCopy.insert(std::make_pair(storeBorrow, asi));
// Destroy the argument value (either as SSA value or in the stack-
// allocated temporary) at the end of the partial_apply's lifetime.
endLifetimeAtFrontier(asi, partialApplyFrontier, builderCtxt, callbacks);
}
return true;
}
/// Process an apply instruction which uses a partial_apply
/// as its callee.
/// Returns true on success.
void PartialApplyCombiner::processSingleApply(FullApplySite paiAI) {
// The arguments of the final apply instruction.
SmallVector<SILValue, 8> argList;
// First, add the arguments of ther original ApplyInst args.
for (auto Op : paiAI.getArguments())
argList.push_back(Op);
SILBuilderWithScope builder(paiAI.getInstruction(), builderCtxt);
// The thunk that implements the partial apply calls the closure function
// that expects all arguments to be consumed by the function. However, the
// captured arguments are not arguments of *this* apply, so they are not
// pre-incremented. When we combine the partial_apply and this apply into
// a new apply we need to retain all of the closure non-address type
// arguments.
auto destroyloc = RegularLocation::getAutoGeneratedLocation();
auto paramInfo = pai->getSubstCalleeType()->getParameters();
auto partialApplyArgs = pai->getArguments();
for (unsigned i : indices(partialApplyArgs)) {
SILValue arg = partialApplyArgs[i];
if (argToTmpCopy.count(arg))
arg = argToTmpCopy.lookup(arg);
if (paramInfo[paramInfo.size() - partialApplyArgs.size() + i]
.isConsumedInCaller()) {
// Copy the argument as the callee may consume it.
if (arg->getType().isAddress()) {
auto *ASI = builder.createAllocStack(pai->getLoc(), arg->getType());
builder.createCopyAddr(pai->getLoc(), arg, ASI, IsTake_t::IsNotTake,
IsInitialization_t::IsInitialization);
paiAI.insertAfterApplication([&](SILBuilder &builder) {
builder.createDeallocStack(destroyloc, ASI);
});
arg = ASI;
} else {
arg = builder.emitCopyValueOperation(pai->getLoc(), arg);
}
}
// Add the argument of the partial_apply.
argList.push_back(arg);
}
SILValue callee = pai->getCallee();
SubstitutionMap subs = pai->getSubstitutionMap();
if (auto *tai = dyn_cast<TryApplyInst>(paiAI)) {
builder.createTryApply(paiAI.getLoc(), callee, subs, argList,
tai->getNormalBB(), tai->getErrorBB(),
tai->getApplyOptions());
} else if (auto *bai = dyn_cast<BeginApplyInst>(paiAI)) {
auto *newBAI = builder.createBeginApply(paiAI.getLoc(), callee, subs,
argList, bai->getApplyOptions());
callbacks.replaceAllInstUsesPairwiseWith(bai, newBAI);
} else {
auto *apply = cast<ApplyInst>(paiAI);
auto *newAI = builder.createApply(paiAI.getLoc(), callee, subs, argList,
apply->getApplyOptions());
callbacks.replaceValueUsesWith(apply, newAI);
}
// We also need to destroy the partial_apply instruction itself because it is
// consumed by the apply_instruction.
if (!pai->hasCalleeGuaranteedContext()) {
paiAI.insertAfterApplication([&](SILBuilder &builder) {
builder.emitDestroyValueOperation(destroyloc, pai);
});
}
callbacks.deleteInst(paiAI.getInstruction());
}
/// Perform the apply{partial_apply(x,y)}(z) -> apply(z,x,y) peephole
/// by iterating over all uses of the partial_apply and searching
/// for the pattern to transform.
bool PartialApplyCombiner::combine() {
// We need to model @unowned_inner_pointer better before we can do the
// peephole here.
if (llvm::any_of(pai->getSubstCalleeType()->getResults(),
[](SILResultInfo resultInfo) {
return resultInfo.getConvention() ==
ResultConvention::UnownedInnerPointer;
})) {
return false;
}
// Iterate over all uses of the partial_apply
// and look for applies that use it as a callee.
// Worklist of operands.
SmallVector<Operand *, 8> worklist(pai->getUses());
SmallVector<FullApplySite, 4> foundApplySites;
while (!worklist.empty()) {
auto *use = worklist.pop_back_val();
auto *user = use->getUser();
// Recurse through ownership instructions.
if (isa<CopyValueInst>(user) || isa<BeginBorrowInst>(user) ||
isa<MoveValueInst>(user)) {
for (auto *ownershipUse : cast<SingleValueInstruction>(user)->getUses())
worklist.push_back(ownershipUse);
continue;
}
// Recurse through conversions.
if (auto *cfi = dyn_cast<ConvertEscapeToNoEscapeInst>(user)) {
// TODO: Handle argument conversion. All the code in this file needs to be
// cleaned up and generalized. The argument conversion handling in
// optimizeApplyOfConvertFunctionInst should apply to any combine
// involving an apply, not just a specific pattern.
//
// For now, just handle conversion to @noescape, which is irrelevant for
// direct application of the closure.
auto convertCalleeTy = cfi->getType().castTo<SILFunctionType>();
auto escapingCalleeTy = convertCalleeTy->getWithExtInfo(
convertCalleeTy->getExtInfo().withNoEscape(false));
assert(use->get()->getType().castTo<SILFunctionType>() ==
escapingCalleeTy);
(void)escapingCalleeTy;
llvm::copy(cfi->getUses(), std::back_inserter(worklist));
continue;
}
// Look through mark_dependence users of partial_apply [stack].
if (auto *mdi = dyn_cast<MarkDependenceInst>(user)) {
if (mdi->getValue() == use->get() &&
mdi->getValue()->getType().is<SILFunctionType>() &&
mdi->getValue()->getType().castTo<SILFunctionType>()->isNoEscape()) {
llvm::copy(mdi->getUses(), std::back_inserter(worklist));
}
continue;
}
// If this use of a partial_apply is not
// an apply which uses it as a callee, bail.
auto ai = FullApplySite::isa(user);
if (!ai)
continue;
if (ai.getCallee() != use->get())
continue;
// We cannot handle generic apply yet. Bail.
if (ai.hasSubstitutions())
continue;
foundApplySites.push_back(ai);
}
if (foundApplySites.empty())
return false;
if (!copyArgsToTemporaries(foundApplySites))
return false;
for (FullApplySite ai : foundApplySites) {
processSingleApply(ai);
}
return true;
}
//===----------------------------------------------------------------------===//
// Top Level Entrypoint
//===----------------------------------------------------------------------===//
bool swift::tryOptimizeApplyOfPartialApply(PartialApplyInst *pai,
SILBuilderContext &builderCtxt,
InstModCallbacks callbacks) {
PartialApplyCombiner combiner(pai, builderCtxt, callbacks);
return combiner.combine();
}