swift sdk: print warnings on stderr instead of stdout (#7532)

Tools and scripts may rely on command output to remain parseable, so printing these warnings on `stdout` can break such workflows. We should output these warnings on `stderr` instead.

As these warnings are emitted before any logging is available, we're using `fputs` for output on `stderr`

Author: MaxDesiatov

Sources/swift-experimental-sdk/Entrypoint.swift

@@ -11,11 +11,12 @@
 //===----------------------------------------------------------------------===//
 
 import SwiftSDKCommand
+import Foundation
 
 @main
 struct Entrypoint {
     static func main() async {
-        print("warning: `swift experimental-sdk` command is deprecated and will be removed in a future version of SwiftPM. Use `swift sdk` instead.")
+        fputs("warning: `swift experimental-sdk` command is deprecated and will be removed in a future version of SwiftPM. Use `swift sdk` instead.", stderr)
         await SwiftSDKCommand.main()
     }
 }

Sources/swift-package-manager/SwiftPM.swift

@@ -13,7 +13,7 @@
 import Basics
 
 import Commands
-
+import Foundation
 import SwiftSDKCommand
 import PackageCollectionsCommand
 import PackageRegistryCommand
@@ -42,7 +42,7 @@ struct SwiftPM {
         case "swift-build":
             await SwiftBuildCommand.main()
         case "swift-experimental-sdk":
-            print("warning: `swift experimental-sdk` command is deprecated and will be removed in a future version of SwiftPM. Use `swift sdk` instead.")
+            fputs("warning: `swift experimental-sdk` command is deprecated and will be removed in a future version of SwiftPM. Use `swift sdk` instead.", stderr)
             fallthrough
         case "swift-sdk":
             await SwiftSDKCommand.main()

Tests/CommandsTests/SDKCommandTests.swift

@@ -48,7 +48,8 @@ final class SDKCommandTests: CommandsTestCase {
                     )
 
                     if command == .experimentalSDK {
-                        XCTAssertMatch(stdout, .contains(deprecationWarning))
+                        XCTAssertMatch(stderr, .contains(deprecationWarning))
+                        XCTAssertNoMatch(stdout, .contains(deprecationWarning))
                     }
 
                     // We only expect tool's output on the stdout stream.
@@ -57,18 +58,16 @@ final class SDKCommandTests: CommandsTestCase {
                         .contains("\(bundle)` successfully installed as test-sdk.artifactbundle.")
                     )
 
-                    XCTAssertEqual(stderr.count, 0)
-
                     (stdout, stderr) = try command.execute(
                         ["list", "--swift-sdks-path", fixturePath.pathString])
 
                     if command == .experimentalSDK {
-                        XCTAssertMatch(stdout, .contains(deprecationWarning))
+                        XCTAssertMatch(stderr, .contains(deprecationWarning))
+                        XCTAssertNoMatch(stdout, .contains(deprecationWarning))
                     }
 
                     // We only expect tool's output on the stdout stream.
                     XCTAssertMatch(stdout, .contains("test-artifact"))
-                    XCTAssertEqual(stderr.count, 0)
 
                     XCTAssertThrowsError(try command.execute(
                         [
@@ -91,30 +90,30 @@ final class SDKCommandTests: CommandsTestCase {
                     }
 
                     if command == .experimentalSDK {
-                        XCTAssertMatch(stdout, .contains(deprecationWarning))
+                        XCTAssertMatch(stderr, .contains(deprecationWarning))
                     }
 
                     (stdout, stderr) = try command.execute(
                         ["remove", "--swift-sdks-path", fixturePath.pathString, "test-artifact"])
 
                     if command == .experimentalSDK {
-                        XCTAssertMatch(stdout, .contains(deprecationWarning))
+                        XCTAssertMatch(stderr, .contains(deprecationWarning))
+                        XCTAssertNoMatch(stdout, .contains(deprecationWarning))
                     }
 
                     // We only expect tool's output on the stdout stream.
                     XCTAssertMatch(stdout, .contains("test-sdk.artifactbundle` was successfully removed from the file system."))
-                    XCTAssertEqual(stderr.count, 0)
 
                     (stdout, stderr) = try command.execute(
                         ["list", "--swift-sdks-path", fixturePath.pathString])
 
                     if command == .experimentalSDK {
-                        XCTAssertMatch(stdout, .contains(deprecationWarning))
+                        XCTAssertMatch(stderr, .contains(deprecationWarning))
+                        XCTAssertNoMatch(stdout, .contains(deprecationWarning))
                     }
 
                     // We only expect tool's output on the stdout stream.
                     XCTAssertNoMatch(stdout, .contains("test-artifact"))
-                    XCTAssertEqual(stderr.count, 0)
                 }
             }
         }