FoundationEssentials: correct callbacks for moveItem(atPath:toPath:) (#661)

In the case that the destination exists, we should check for continue
after error. If the source does not exist, simply do nothing.

Furthermore, adjust the test to ensure that we are using the path
spelling rather than the FSR.

Take the opportunity to correct an error in the tests where we would not
check the correct captured item set.

Author: compnerd

Sources/FoundationEssentials/FileManager/FileManager+Directories.swift

@@ -176,7 +176,7 @@ extension _FileManagerImpl {
                     var pwszFullPath: PWSTR? = nil
                     _ = PathAllocCombine(item.fileName, $0, PATHCCH_ALLOW_LONG_PATHS, &pwszFullPath)
                     defer { LocalFree(pwszFullPath) }
-                    return String(decodingCString: pwszFullPath!, as: UTF16.self).standardizingPath
+                    return String(decodingCString: pwszFullPath!, as: UTF16.self).standardizingPath.replacing("\\", with: "/")
                  })
             }
         }

Sources/FoundationEssentials/FileManager/FileOperations.swift

@@ -566,14 +566,21 @@ enum _FileOperations {
 
                 try source.withNTPathRepresentation { pwszSource in
                     var faSourceAttributes: WIN32_FILE_ATTRIBUTE_DATA = .init()
-                    guard GetFileAttributesExW(pwszSource, GetFileExInfoStandard, &faSourceAttributes) else {
-                        throw CocoaError.moveFileError(GetLastError(), src, dst)
+                    if !GetFileAttributesExW(pwszSource, GetFileExInfoStandard, &faSourceAttributes) {
+                        let error = CocoaError.moveFileError(GetLastError(), src, dst)
+                        guard fileManager._shouldProceedAfter(error: error, movingItemAtPath: source, to: destination) else {
+                            throw error
+                        }
+                        return
                     }
 
                     try destination.withNTPathRepresentation { pwszDestination in
                         var faDestinationAttributes: WIN32_FILE_ATTRIBUTE_DATA = .init()
-                        guard GetFileAttributesExW(pwszDestination, GetFileExInfoStandard, &faDestinationAttributes) else {
-                            throw CocoaError.moveFileError(GetLastError(), src, dst)
+                        if GetFileAttributesExW(pwszDestination, GetFileExInfoStandard, &faDestinationAttributes) {
+                            let error = CocoaError.moveFileError(GetLastError(), src, dst)
+                            guard fileManager._shouldProceedAfter(error: error, movingItemAtPath: source, to: destination) else {
+                                throw error
+                            }
                         }
 
                         // `MoveFileExW` does not work if the source and

Tests/FoundationEssentialsTests/FileManager/FileManagerTests.swift

@@ -374,11 +374,11 @@ final class FileManagerTests : XCTestCase {
             XCTAssertEqual(try $0.subpathsOfDirectory(atPath: ".").sorted(), ["dir2", "dir2/bar", "dir2/foo", "other_file"])
             XCTAssertEqual($0.contents(atPath: "dir2/foo"), data)
 
-            let rootDir = $0.currentDirectoryPath
+            let rootDir = URL(fileURLWithPath: $0.currentDirectoryPath).path
             XCTAssertEqual($0.delegateCaptures.shouldMove, [.init("\(rootDir)/dir", "\(rootDir)/dir2")])
-            
+
             try $0.moveItem(atPath: "does_not_exist", toPath: "dir3")
-            XCTAssertEqual($0.delegateCaptures.shouldProceedAfterCopyError, [])
+            XCTAssertEqual($0.delegateCaptures.shouldProceedAfterMoveError, [.init("\(rootDir)/does_not_exist", "\(rootDir)/dir3", code: .fileNoSuchFile)])
 
             try $0.moveItem(atPath: "dir2", toPath: "other_file")
             XCTAssertTrue($0.delegateCaptures.shouldProceedAfterMoveError.contains(.init("\(rootDir)/dir2", "\(rootDir)/other_file", code: .fileWriteFileExists)))