Improve metadata validation and remove exception cases

Updates to the normalize proposals in the swift-evolution repository
allow exceptions to removed and validation to improved.

- Validate that github profile links use https scheme
- Remove exception for profile using Previous Proposals incorrectly
- Remove exceptions for recent proposals missing Review header fields
- Update test snapshots with updated proposals and expected results

Author: dempseyatgithub

Sources/EvolutionMetadataExtraction/Extractors/FieldExtractors/PersonExtractor.swift

@@ -30,7 +30,7 @@ struct PersonExtractor: MarkupWalker {
         case reviewManager
     }
 
-    private var role: Role = .author
+    private var role: Role
 
     private var warnings: [Proposal.Issue] = []
     private var errors: [Proposal.Issue] = []

Sources/EvolutionMetadataExtraction/Extractors/ProposalMetadataExtractor.swift

@@ -68,11 +68,7 @@ struct ProposalMetadataExtractor {
             }
 
             proposal.upcomingFeatureFlag = extractValue(from: headerFieldsByLabel, with: UpcomingFeatureFlagExtractor.self)
-            
-            // Known issue with SE-0255, should be resolved by https://github.com/apple/swift-evolution/pull/2411
-            if proposalSpec.id != "SE-0255" {
-                proposal.previousProposalIDs = extractValue(from: headerFieldsByLabel, with: PreviousProposalExtractor.self)
-            }
+            proposal.previousProposalIDs = extractValue(from: headerFieldsByLabel, with: PreviousProposalExtractor.self)
             proposal.trackingBugs = extractValue(from: headerFieldsByLabel, with: TrackingBugExtractor.self)
             proposal.implementation = extractValue(from: headerFieldsByLabel, with: ImplementationExtractor.self)
 
@@ -163,11 +159,8 @@ struct LinkInfo {
         self.destination = destination
     }
 
-    // VALIDATION ENHANCEMENT: Consider requiring https//github.com style links for consistency
     var gitHubDestination: String? {
-        if destination.starts(with: /https?:\/\/github.com/) ||
-            destination.hasPrefix("//github.com") // protocol-relative URI
-        {
+        if destination.starts(with: "https://github.com") {
             return destination
         } else {
             return nil