Skip to content

Commit 16ab25b

Browse files
Update to extract implementation links from swiftlang organization
- Update tests - Resolves #41
1 parent 6b96f27 commit 16ab25b

File tree

2 files changed

+22
-22
lines changed

2 files changed

+22
-22
lines changed

Sources/EvolutionMetadataExtraction/Extractors/FieldExtractors/ImplementationExtractor.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ struct ImplementationExtractor: MarkupWalker, ValueExtractor {
7474
}
7575

7676
// VALIDATION ENHANCEMENT: The legacy tool lowercases the tested value. This is probably not necessary.
77-
guard account == "apple" else {
77+
guard account == "apple" || account == "swiftlang" else {
7878
warnings.append(.invalidImplementationLink)
7979
return
8080
}

Tests/ExtractionTests/Resources/AllProposals.evosnapshot/expected-results.json

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -9796,6 +9796,26 @@
97969796
}
97979797
],
97989798
"id" : "SE-0264",
9799+
"implementation" : [
9800+
{
9801+
"account" : "swiftlang",
9802+
"id" : "1089",
9803+
"repository" : "swift-evolution",
9804+
"type" : "pull"
9805+
},
9806+
{
9807+
"account" : "swiftlang",
9808+
"id" : "1090",
9809+
"repository" : "swift-evolution",
9810+
"type" : "pull"
9811+
},
9812+
{
9813+
"account" : "swiftlang",
9814+
"id" : "1091",
9815+
"repository" : "swift-evolution",
9816+
"type" : "pull"
9817+
}
9818+
],
97999819
"link" : "0264-stdlib-preview-package.md",
98009820
"reviewManagers" : [
98019821
{
@@ -9809,27 +9829,7 @@
98099829
"version" : ""
98109830
},
98119831
"summary" : "We propose changing the Swift Evolution process to publish accepted proposals as individual SwiftPM packages, as well as a `SwiftPreview` package that bundles these proposal packages together. This group of packages will form the initial landing spot for certain additions to the Swift standard library.",
9812-
"title" : "Standard Library Preview Package",
9813-
"warnings" : [
9814-
{
9815-
"code" : 0,
9816-
"kind" : "warning",
9817-
"message" : "Implementation links to a non-Swift repository.",
9818-
"suggestion" : ""
9819-
},
9820-
{
9821-
"code" : 0,
9822-
"kind" : "warning",
9823-
"message" : "Implementation links to a non-Swift repository.",
9824-
"suggestion" : ""
9825-
},
9826-
{
9827-
"code" : 0,
9828-
"kind" : "warning",
9829-
"message" : "Implementation links to a non-Swift repository.",
9830-
"suggestion" : ""
9831-
}
9832-
]
9832+
"title" : "Standard Library Preview Package"
98339833
},
98349834
{
98359835
"authors" : [

0 commit comments

Comments
 (0)