Fixes incorrect behavior of DispatchData.copyBytes() when the start … #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci Please test |
ktopley-apple
changed the title
moiseev
reviewed
Jan 25, 2017
Contributor
moiseev
left a comment
moiseev
left a comment
There was a problem hiding this comment.
Same comments about the usage of startIndex vs lowerBound apply. But other than that, looks good.
…index is not 0 and adds a test for that method. Please enter the commit message for your changes. Lines starting
Contributor
Author
|
Updated with review comments. |
Contributor
|
LGTM |
Contributor
Author
|
@swift-ci Please test |
1 similar comment
Member
|
@swift-ci Please test |
das
pushed a commit
that referenced
this pull request
Feb 21, 2017
Fixes incorrect behavior of DispatchData.copyBytes() when the start … Signed-off-by: Daniel A. Steffen <dsteffen@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes incorrect result of calling the DispatchData.copyBytes() method when the start index of the source range is not 0. Also fixes the behavior when the start index does not coincide with the start of a region.
Related to #7036.
rdar://problem/29005050